NBT integer var update wrong

[clowcadia]

I have an integer value i add to nbt, i inticilize and declare it in the class main structure, but when nbt reads and write and my entity onUpdates it becomes 0

[Leomelonseeds]

Post you code

[clowcadia]

a

Edited February 28, 2017 by clowcadia

[clowcadia]

package com.clowcadia.test.npc;

import com.clowcadia.test.GuiHandler;
import com.clowcadia.test.TestModHandler;
import com.clowcadia.test.utils.Utils;

import net.minecraft.block.ITileEntityProvider;
import net.minecraft.entity.EntityLiving;
import net.minecraft.entity.player.EntityPlayer;
import net.minecraft.nbt.NBTTagCompound;
import net.minecraft.network.NetworkManager;
import net.minecraft.network.play.server.SPacketUpdateTileEntity;
import net.minecraft.tileentity.TileEntity;
import net.minecraft.util.EnumFacing;
import net.minecraft.util.EnumHand;
import net.minecraft.util.math.BlockPos;
import net.minecraft.world.World;
import net.minecraftforge.common.capabilities.Capability;
import net.minecraftforge.common.capabilities.ICapabilityProvider;
import net.minecraftforge.items.CapabilityItemHandler;
import net.minecraftforge.items.ItemStackHandler;
import scala.reflect.internal.Trees.This;

public class Basic extends EntityLiving implements  ICapabilityProvider{
	
	private ItemStackHandler handler;
	public static Basic instance;
	public static int basicID; 
	private int stomach=800;	
	private int stomachCap = 800;
	
	public Basic(World world) 
	{			
		super(world);
		this.handler = new ItemStackHandler(9); 
		
		Utils.getLogger().info("basic constructor" +this.stomach);
	}
	
	@Override
	public void readFromNBT(NBTTagCompound compound) {
		this.handler.deserializeNBT(compound.getCompoundTag("ItemStackHandler"));
		this.stomach = compound.getInteger("Stomach");
		super.readFromNBT(compound);
	}
	
	@Override
	public NBTTagCompound writeToNBT(NBTTagCompound compound) {
		compound.setTag("ItemStackHandler", this.handler.serializeNBT());
		compound.setInteger("Stomach", this.stomach);
		return super.writeToNBT(compound);
	}	
	
	public void onDataPacket(NetworkManager net, SPacketUpdateTileEntity pkt) {
		this.readFromNBT(pkt.getNbtCompound());
	}

	public NBTTagCompound getUpdateTag() {
		NBTTagCompound compound = new NBTTagCompound();
		this.writeToNBT(compound);
		return compound;
	}
	
	public void handleUpdateTag(NBTTagCompound tag) {
		this.readFromNBT(tag);
	}

	public NBTTagCompound getTileData() {
		NBTTagCompound compound = new NBTTagCompound();
		this.writeToNBT(compound);
		return compound;
	}
	
	@Override
	public <T> T getCapability(Capability<T> capability, EnumFacing facing) {
		if(capability == CapabilityItemHandler.ITEM_HANDLER_CAPABILITY) return (T) this.handler;		
		return super.getCapability(capability, facing);
	}
	
	@Override
	public boolean hasCapability(Capability<?> capability, EnumFacing facing) {
		if(capability == CapabilityItemHandler.ITEM_HANDLER_CAPABILITY) return true;
		return super.hasCapability(capability, facing);
	}
	
	public boolean isUseableByPlayer(EntityPlayer player) {
		return true;
	}
	
	@Override
	public void onEntityUpdate() {
		if (this.world != null){
			if(!this.world.isRemote){
				if(stomach != stomachCap)Utils.getLogger().info(this.stomach+" "+stomachCap);
			}				
		}
			
			
		super.onEntityUpdate();
	}
	
	@Override
	public boolean processInteract(EntityPlayer player, EnumHand hand)
    {
		
		if (!this.world.isRemote)
		{			
			basicID = this.getEntityId(); //for inputing into x/y/z in the opne gui to pass the entety id
			System.out.println("Player has interacted with the mob");	
			player.openGui(TestModHandler.instance, GuiHandler.BASIC, this.world, basicID, (int)player.posY, (int)player.posZ);	
		}
		else
		{
			
			//player.openGui(ClowcadiaMod.modInstance, 0, this.world, (int) player.posX, (int)player.posY, (int)player.posZ);
		}
		return true;
    }




}

 

[clowcadia]

[23:52:12] [Server thread/INFO] [testmod]: basic constructor800
[23:52:13] [Server thread/INFO]: Preparing spawn area: 87%
[23:52:13] [Server thread/INFO] [testmod]: 0 800

 

[loordgek]

@Override
	public void readFromNBT(NBTTagCompound compound) {
		this.handler.deserializeNBT(compound.getCompoundTag("ItemStackHandler"));
		this.stomach = compound.getInteger("Stomach");
		super.readFromNBT(compound);
	}
	
	@Override
	public NBTTagCompound writeToNBT(NBTTagCompound compound) {
		compound.setTag("ItemStackHandler", this.handler.serializeNBT());
		compound.setInteger("Stomach", this.stomach);
		return super.writeToNBT(compound);
	}	

you only return the super NBTTagCompound that will not work

first read and write the super and than do the rest

[Choonster]

7 minutes ago, loordgek said:

@Override
	public void readFromNBT(NBTTagCompound compound) {
		this.handler.deserializeNBT(compound.getCompoundTag("ItemStackHandler"));
		this.stomach = compound.getInteger("Stomach");
		super.readFromNBT(compound);
	}
	
	@Override
	public NBTTagCompound writeToNBT(NBTTagCompound compound) {
		compound.setTag("ItemStackHandler", this.handler.serializeNBT());
		compound.setInteger("Stomach", this.stomach);
		return super.writeToNBT(compound);
	}	

you only return the super NBTTagCompound that will not work

first read and write the super and than do the rest

 

That code should work, since TileEntity#writeToNBT writes its data to and then returns its argument.

Edited February 28, 2017 by Choonster

[Gortart]

EntityLiving doesn't have readFromNBT or writeToNBT. Use readEntityFromNBT and writeEntityToNBT.

Did you just copy pasted from tile entity code?

[Choonster]

I completely missed the fact that this is an Entity rather than a TileEntity.

 

Still, overriding Entity#readFromNBT and Entity#writeToNBT should work (though you're meant to override Entity#readEntityFromNBT and Entity#writeEntityToNBT instead).

[clowcadia]

7 hours ago, Choonster said:

I completely missed the fact that this is an Entity rather than a TileEntity.

 

Still, overriding Entity#readFromNBT and Entity#writeToNBT should work (though you're meant to override Entity#readEntityFromNBT and Entity#writeEntityToNBT instead).

thank you.. whats going on lol

[clowcadia]

Write/ReadEniityToNBT methods still dont work

[clowcadia]

package com.clowcadia.test.npc;

import com.clowcadia.test.GuiHandler;
import com.clowcadia.test.TestModHandler;
import com.clowcadia.test.utils.Utils;

import net.minecraft.block.ITileEntityProvider;
import net.minecraft.entity.EntityLiving;
import net.minecraft.entity.player.EntityPlayer;
import net.minecraft.nbt.NBTTagCompound;
import net.minecraft.network.NetworkManager;
import net.minecraft.network.play.server.SPacketUpdateTileEntity;
import net.minecraft.tileentity.TileEntity;
import net.minecraft.util.EnumFacing;
import net.minecraft.util.EnumHand;
import net.minecraft.world.World;
import net.minecraftforge.common.capabilities.Capability;
import net.minecraftforge.common.capabilities.ICapabilityProvider;
import net.minecraftforge.items.CapabilityItemHandler;
import net.minecraftforge.items.ItemStackHandler;

public class Basic extends EntityLiving implements  ICapabilityProvider{
	
	private ItemStackHandler handler;
	public static Basic instance;
	public static int basicID; 
	private int stomach=800;	
	private int stomachCap = 800;
	
	public Basic(World world) 
	{			
		super(world);
		this.handler = new ItemStackHandler(9); 
		
		Utils.getLogger().info("basic constructor" +this.stomach);
	}
	
	@Override
	public void readEntityFromNBT(NBTTagCompound compound) {
		this.handler.deserializeNBT(compound.getCompoundTag("ItemStackHandler"));
		this.stomach = compound.getInteger("Stomach");
		super.readEntityFromNBT(compound);
	}
	
	@Override
	public void writeEntityToNBT(NBTTagCompound compound) {
		super.writeEntityToNBT(compound);
		compound.setTag("ItemStackHandler", this.handler.serializeNBT());
		compound.setInteger("Stomach", this.stomach);
		
	}	
	
	public void onDataPacket(NetworkManager net, SPacketUpdateTileEntity pkt) {
		this.readEntityFromNBT(pkt.getNbtCompound());
	}

	public NBTTagCompound getUpdateTag() {
		NBTTagCompound compound = new NBTTagCompound();
		this.writeEntityToNBT(compound);
		return compound;
	}
	
	public void handleUpdateTag(NBTTagCompound tag) {
		this.readEntityFromNBT(tag);
	}

	public NBTTagCompound getTileData() {
		NBTTagCompound compound = new NBTTagCompound();
		this.writeEntityToNBT(compound);
		return compound;
	}
	
	@Override
	public <T> T getCapability(Capability<T> capability, EnumFacing facing) {
		if(capability == CapabilityItemHandler.ITEM_HANDLER_CAPABILITY) return (T) this.handler;		
		return super.getCapability(capability, facing);
	}
	
	@Override
	public boolean hasCapability(Capability<?> capability, EnumFacing facing) {
		if(capability == CapabilityItemHandler.ITEM_HANDLER_CAPABILITY) return true;
		return super.hasCapability(capability, facing);
	}
	
	public boolean isUseableByPlayer(EntityPlayer player) {
		return true;
	}
	
	@Override
	public void onEntityUpdate() {
		if (this.world != null){
			if(!this.world.isRemote){
				if(stomach != stomachCap)Utils.getLogger().info(this.stomach+" "+stomachCap);
			}				
		}
			
			
		super.onEntityUpdate();
	}
	
	@Override
	public boolean processInteract(EntityPlayer player, EnumHand hand)
    {
		
		if (!this.world.isRemote)
		{			
			basicID = this.getEntityId(); //for inputing into x/y/z in the opne gui to pass the entety id
			System.out.println("Player has interacted with the mob");	
			player.openGui(TestModHandler.instance, GuiHandler.BASIC, this.world, basicID, (int)player.posY, (int)player.posZ);	
		}
		else
		{
			
			//player.openGui(ClowcadiaMod.modInstance, 0, this.world, (int) player.posX, (int)player.posY, (int)player.posZ);
		}
		return true;
    }




}

 

[clowcadia]

yes, the entity apears and everything just the that initial 800 turns to 0 after being initilized

[clowcadia]

so how do i get it update to its original value

[clowcadia]

when i initilize the value it is 800 but then when the update method goes on it becomes 0, how can i have the value to stay at 800 rather being 0, where should i modify code and what should i do, call the write nbt there or?

[clowcadia]

I dont i undestand what to do about it

[clowcadia]

Is get/setInteger not the tag setting?

[clowcadia]

is "Stomach" not the tag compound.setInteger("Stomach", this.stomach);

[Animefan8888]

When the world is loaded TE's have readFromNBT called and if the tag doesn't exist then it will return a default value for numbers that is 0. And then when the world will call writeToNBT at certain points and then save the tag making it exist, but it will be set to 0 because it was read as 0. So to check if the tag is there use NBTTagCompound#hasTag(String)

Edited March 1, 2017 by Animefan8888

[clowcadia]

did not see the post above

How does one set an NTB tag, i am having a hard time understanding thigns through my research . my findings are itemstack specific

Edited March 1, 2017 by clowcadia

[clowcadia]

15 hours ago, Animefan8888 said:

When the world is loaded TE's have readFromNBT called and if the tag doesn't exist then it will return a default value for numbers that is 0. And then when the world will call writeToNBT at certain points and then save the tag making it exist, but it will be set to 0 because it was read as 0. So to check if the tag is there use NBTTagCompound#hasTag(String)

what i dont understand is why

@Override
	public void readEntityFromNBT(NBTTagCompound compound) {
		Utils.getLogger().info("basic readNBT " +this.stomach);
		this.handler.deserializeNBT(compound.getCompoundTag("ItemStackHandler"));
		this.stomach = compound.getInteger("Stomach");

why it does this

[16:28:51] [Server thread/INFO] [testmod]: basic readNBT 800
[16:28:51] [Server thread/INFO]: Preparing spawn area: 56%
[16:28:52] [Server thread/INFO] [testmod]: 0 800

when

	@Override
	public void onEntityUpdate() {
		if (this.world != null){
			if(!this.world.isRemote){
				if(stomach != stomachCap)Utils.getLogger().info(this.stomach+" "+stomachCap);
			}				
		}
			
			
		super.onEntityUpdate();
	}

 

[clowcadia]

Just now, diesieben07 said:

If compound doesn't have an entry called "Stomach", it will return 0. Meaning you will set this.stomach to 0.

Thank you for clarification, as for the hasTag method, i cant seem to find it in NBTTagCompound class

[clowcadia]

Maybe getCompoundTag? getTag?

[clowcadia]

I do, i dont understand what your implying ? Maybe i can work on ur criticism

[clowcadia]

Using eclipse not JIdea, i belive it has a different interface

and i am runnign into syntax error

cannot make static referrence to non static method

if(NBTTagCompound.hasKey(tagStomach)){}

and no enclosign instance of NTB blah blah is accesible in scope

if(NBTTagCompound.this.hasKey(tagStomach)){}