[1.11.2] Message value is null / Capabilities

[Dragonisser]

Currently trying to sync my capabilities, the problem is the value im sending(IMana) is null even though its there when i create the message. Even the ByteBuf has the data.

 

Checked this thread here but cant find any difference.

 

 

Console output

[18:50:56] [Server thread/INFO] [RPGMOD]: Sending info to client
[18:50:56] [Server thread/INFO] [RPGMOD]: EntityPlayerMP['Dragonisser'/137993, l='New World', x=110.88, y=87.00, z=-2.19]
[18:50:56] [Server thread/INFO] [RPGMOD]: de.prwh.rpg.capabilities.mana.Mana@60173b3b
[18:50:56] [Server thread/INFO] [RPGMOD]: Mana isnt null
[18:50:56] [Server thread/INFO] [RPGMOD]: ManaNBTMessage: de.prwh.rpg.capabilities.mana.Mana@60173b3b
[18:50:56] [Server thread/INFO] [RPGMOD]: Save
[18:50:56] [Server thread/INFO] [RPGMOD]: CurrentMana: 3000.0
[18:50:56] [Server thread/INFO] [RPGMOD]: CurrentMaxMana: 250.0
3000.0
250.0
[18:50:56] [Netty Local Client IO #1/INFO] [RPGMOD]: Trying to synced Mana
[18:50:56] [Netty Local Client IO #1/INFO]: [STDOUT]: de.prwh.rpg.capabilities.mana.Mana@753c98de
[18:50:56] [Netty Local Client IO #1/INFO]: [STDOUT]: de.prwh.rpg.network.message.ManaNBTMessage@478f5a8
[18:50:56] [Netty Local Client IO #1/INFO]: [STDOUT]: null
[18:50:56] [Netty Local Client IO #1/INFO]: [STDOUT]: null
[18:50:56] [Netty Local Client IO #1/INFO] [RPGMOD]: Mana synced failed.
[18:50:56] [Netty Local Client IO #1/INFO] [RPGMOD]: IMana: de.prwh.rpg.capabilities.mana.Mana@753c98de
[18:50:56] [Netty Local Client IO #1/INFO] [RPGMOD]: Message: null
[18:50:56] [Netty Local Client IO #1/INFO] [RPGMOD]: IMana: true
[18:50:56] [Netty Local Client IO #1/INFO] [RPGMOD]: Message: false

 

 

Via server command

private IMana getManaInfo() {
		RPGMain.getLogger().info("Sending info to client");
		
		IMana manaInfo = player.getCapability(ManaProvider.MANA_CAP, null);
		RPGMain.getLogger().info(this.player);
		RPGMain.getLogger().info(manaInfo);
		
		ManaNBTMessage message = new ManaNBTMessage(manaInfo);
		RPGPacketDispatcher.sendTo(message, (EntityPlayerMP) this.player);
		
		return manaInfo;
	}

 

Message

package de.prwh.rpg.network.message;

import de.prwh.rpg.RPGMain;
import de.prwh.rpg.capabilities.mana.IMana;
import io.netty.buffer.ByteBuf;
import net.minecraftforge.fml.common.network.simpleimpl.IMessage;

/**
 * This message is sent to the client giving it the wanted bytes
 */
public class ManaNBTMessage implements IMessage {

	private IMana mana;

	public ManaNBTMessage() {
		this.mana = null;
	}

	public ManaNBTMessage(IMana mana) {
		setValue(mana);
		if(mana != null) {
			RPGMain.getLogger().info("Mana isnt null");
		} else {
			RPGMain.getLogger().info("Mana is null");
		}
		RPGMain.getLogger().info("ManaNBTMessage: " + this.mana);
	}

	@Override
	public void fromBytes(ByteBuf buf) {
		System.out.println(buf.readFloat());
		System.out.println(buf.readFloat());
		
		if (this.mana != null) {
			this.mana.setMana(buf.readFloat());
			this.mana.setMaxMana(buf.readFloat());
			RPGMain.getLogger().info("Load");
			RPGMain.getLogger().info("CurrentMana: " + mana.getMana());
			RPGMain.getLogger().info("CurrentMaxMana: " + mana.getMaxMana());
		}
	}

	@Override
	public void toBytes(ByteBuf buf) {
		if (this.mana != null) {
			buf.writeFloat(this.mana.getMana());
			buf.writeFloat(this.mana.getMaxMana());
			RPGMain.getLogger().info("Save");
			RPGMain.getLogger().info("CurrentMana: " + mana.getMana());
			RPGMain.getLogger().info("CurrentMaxMana: " + mana.getMaxMana());
		}
	}
	
	public void setValue(IMana mana) {
		this.mana = mana;
	}

	public IMana getValue() {
		return this.mana;
	}
}

 

Handler

package de.prwh.rpg.network.handler.client;

import de.prwh.rpg.RPGMain;
import de.prwh.rpg.capabilities.mana.IMana;
import de.prwh.rpg.capabilities.mana.ManaProvider;
import de.prwh.rpg.network.message.ManaNBTMessage;
import net.minecraft.entity.player.EntityPlayer;
import net.minecraftforge.fml.common.network.simpleimpl.IMessage;
import net.minecraftforge.fml.common.network.simpleimpl.MessageContext;

public class ManaNBTMessageHandler extends AbstractClientMessageHandler<ManaNBTMessage> {
	@Override
	public IMessage handleClientMessage(EntityPlayer player, ManaNBTMessage message, MessageContext ctx) {
		RPGMain.getLogger().info("Trying to synced Mana");
		if (player != null) {
			IMana mana = player.getCapability(ManaProvider.MANA_CAP, null);
			final IMana message_mana = message.getValue();
			try {
				
				System.out.println(mana);
				System.out.println(message);
				System.out.println(message.getValue());
				System.out.println(message_mana);
				
				if (mana != null && message_mana != null) {
					mana.setMana(message_mana.getMana());
					mana.setMaxMana(message_mana.getMaxMana());
					RPGMain.getLogger().info("Mana synced");
				} else {
					RPGMain.getLogger().info("Mana synced failed.");
					RPGMain.getLogger().info("IMana: " + mana);
					RPGMain.getLogger().info("Message: " + message_mana);
					RPGMain.getLogger().info("IMana: " + (mana != null));
					RPGMain.getLogger().info("Message: " + (message_mana != null));
				}
			} catch (Exception e) {
				e.printStackTrace();
			}

		}
		return null;
	}
}

 

 

 

 

 

[Dragonisser]

1 minute ago, diesieben07 said:

I wonder why it is null...

Even without it it is null. Thats one of the reason i wondered why the other code works.

Edited March 7, 2017 by Dragonisser

[Dragonisser]

28 minutes ago, diesieben07 said:

Yes, of course. Because fields are by default initialized to null.

So how can i send the whole in one with all data. Back with IEEP ive send the whole RpgPlayer

 

NVM. Seems to work like it should.

 

@Override
	public void fromBytes(ByteBuf buf) {

		byte[] bytes = new byte[buf.readableBytes()];
		buf.readBytes(bytes);

		try (ByteArrayInputStream bis = new ByteArrayInputStream(bytes); ObjectInputStream ois = new ObjectInputStream(bis)) {
			this.mana = (IMana) ois.readObject();
		} catch (ClassNotFoundException | IOException e) {
			RPGMain.getLogger().error("Couldnt sync player", e);
		}
	}

	@Override
	public void toBytes(ByteBuf buf) {
		if (this.mana != null) {

			try (ByteArrayOutputStream bos = new ByteArrayOutputStream(); ObjectOutputStream oos = new ObjectOutputStream(bos)) {
				oos.writeObject(this.mana);
				buf.writeBytes(bos.toByteArray());
			} catch (IOException e) {
				RPGMain.getLogger().error("Couldnt sync player with client", e);
			}
		}
	}

 

Edited March 7, 2017 by Dragonisser

[Jay Avery]

40 minutes ago, Dragonisser said:

System.out.println(buf.readFloat());

A ByteBuf is always read completely in order. When you read it in these printlns, you are 'using up' the values you want to read. Then when you try to read them in order to set the actual message data, there's nothing left in the ByteBuf to read. Try commenting out these printlns and see if the behaviour is the same

[Dragonisser]

Just now, Jay Avery said:

A ByteBuf is always read completely in order. When you read it in these printlns, you are 'using up' the values you want to read. Then when you try to read them in order to set the actual message data, there's nothing left in the ByteBuf to read. Try commenting out these printlns and see if the behaviour is the same

Yep it also didnt worked before using those printIn. But now im using the code above which works, suddenly.