I'm trying to make a mod with some sword that should emit sound only once at its equip. Detection of slot change works like this: last item in player's hand being written to static variable lastSlotItem, and then if  equipped item on next tick != lastSlotItem means that slot is changed. And by some unknown reason onPlayerTick is being called like this:

First change tick: item == sword

Second change tick: item == previous item (why does it goes back to prev. item on this tick?)

Third change tick: item == sword (again)

 

There's my code:

onPlayerTick:

Spoiler

public class FMLEventHandler
{
	public static Item lastSlotItem;
	
	@SubscribeEvent
	public void onPlayerTick(PlayerTickEvent event)
	{
		if(event.phase == TickEvent.Phase.START)
		{
			ItemStack itemStack = event.player.getCurrentEquippedItem();
			if(itemStack != null)
			{
				Item item = itemStack.getItem();
				if(item instanceof ItemTestSword)
				{
					if(lastSlotItem != null) event.player.addChatComponentMessage(new ChatComponentText(item.getClass().getName()));
					if(lastSlotItem != item)
					{
						event.player.addChatComponentMessage(new ChatComponentText("Test sword!"));
					}
				}
				lastSlotItem = item;
			}
			else lastSlotItem = null;
		}
	}
}

 

 

preInit:

Spoiler

@EventHandler
public void preInit(FMLPreInitializationEvent event)
{
    MinecraftForge.EVENT_BUS.register(new ModEventHandler());
    FMLCommonHandler.instance().bus().register(new FMLEventHandler());
    ModItems.init();
}

 

 

And even if i trying to handle slot change detection with onUpdate override in my sword class it does the same thing.

Sword Class:

Spoiler

public class ItemTestSword extends ModItemSword
{
	public List itemDescription = Arrays.asList(new String[]
			{
					"Some",
					"Description",
              		"Here"
			});
	
	public boolean isHeld;
	
	public ItemTestSword(String unlocalizedName, ToolMaterial material)
	{
        super(material);
        this.setUnlocalizedName(unlocalizedName);
	}
	
	@Override
	public void addInformation(ItemStack itemStack, EntityPlayer entityPlayer, List list, boolean bool)
	{
		list.addAll(itemDescription);
	}
	
	@Override
    public ItemStack onItemRightClick(ItemStack itemStack, World world, EntityPlayer entityPlayer)
    {
		return itemStack;
    }
	
	public void onUpdate(ItemStack itemStack, World world, Entity entity, int integer, boolean bool)
	{
      	if(entity instanceof EntityPlayer)
        {
            if(bool && !isHeld)
            {
                    EntityPlayer ep = (EntityPlayer)entity;
                    ep.addChatMessage(new ChatComponentText("Test sword!"));
                    isHeld = true;
            }
            else if(!bool && isHeld) isHeld = false;
        }
	}
}

 

 

Sorry, but 1.7.10 is no longer supported here. Please update!

That's bad... I need to create mod on 1.7.10 because of some other mods are still on this version, like GregTech or Extra Bees (Binnie's mods).

But maybe someone can help me with this thing?.. I don't know what to do...

Edited May 16, 20178 yr by exys

Moved to 1.11.2 with latest forge. Still absolutely same thing, no matter which forge or mc version is installed.

You shouldn't be using any static fields and Item fields for that.

Learn to use capabilities as data storage.

https://mcforge.readthedocs.io/en/latest/datastorage/capabilities/

Thanks, i'll check this later.

5 minutes ago, exys said:

Thanks, i'll check this later.

Note: Using Capabilities requires upgrading past 1.7.10

Ooh ;(