[1.12] Figuring out registries

[BeardlessBrady]

So I'm trying my best to figure out how the registries work but I'm having a hard time.

 

Common Proxy: https://github.com/BeardlessBrady/Currency-Mod/blob/master-1.12/src/main/java/gunn/modcurrency/mod/proxy/CommonProxy.java#L32-L33

ModBlock Class: https://github.com/BeardlessBrady/Currency-Mod/blob/master-1.12/src/main/java/gunn/modcurrency/mod/block/ModBlocks.java

ModItem Class https://github.com/BeardlessBrady/Currency-Mod/blob/master-1.12/src/main/java/gunn/modcurrency/mod/item/ModItems.java

 

Console Output; https://pastebin.com/cR1P39fG

 

 

Edited July 1, 2017 by BeardlessBrady

[IceMetalPunk]

You've handed us your code, but you haven't explained what's wrong. Are you getting errors? If so, what are those errors? Or are you not getting errors, but something isn't working properly? If so, what's not working, and what should it be doing that it's not (or what is it doing that it shouldn't)?

[BeardlessBrady]

Im assuming the way Im doing it is completely wrong. No need for sass, was just asking for help on the right way to use the new registry system since there arent many examples out there.

[IceMetalPunk]

It wasn't sass at all. If your code works, you're probably doing it right. If it doesn't work, then we need to know what problems you're having before we can help you figure out what you're doing wrong.

[BeardlessBrady]

I added the console output.

[Choonster]

You're calling Item.getItemFromBlock before you actually create and register the ItemBlocks, so it returns Items.AIR. You need to create and register the ItemBlocks in the RegistryEvent.Register<Item> handler method.

Edited July 1, 2017 by Choonster

[loordgek]

instead of    Item.getItemFromBlock(blockExchanger)  do    new ItemBlock(blockExchanger)

[BeardlessBrady]

Hmm now it is spouting out an issue about null names regarding the ItemBlocks.

https://github.com/BeardlessBrady/Currency-Mod/blob/master-1.12/src/main/java/gunn/modcurrency/mod/block/ModBlocks.java#L29

 

https://pastebin.com/aKphMdNk

[Choonster]

You must set the registry name of an IForgeRegistryEntry with IForgeRegistryEntry#setRegistryName before registering it. For ItemBlocks, use the Block's registry name.

Edited July 1, 2017 by Choonster

[BeardlessBrady]

where do I do that? in the event right before I register each block?

[Draco18s]

44 minutes ago, BeardlessBrady said:

where do I do that? in the event right before I register each block?

Yes

[BeardlessBrady]

Im not understanding what Im calling .setRegistryName from, surely not event.setRegistryName, so what?

[Draco18s]

I dunno, maybe block.setRegistryName(...)

[BeardlessBrady]

Ok I didn't realize you guys were telling me to set the Blocks registry name, I thought it was an extra step for something else. I already set the registry name in the blocks constructor method, so when I create the new block should the registry name not already be set?

[Draco18s]

You have to set the ItemBlock's registry name too.

[BeardlessBrady]

Ah now that makes sense, sorry I didn't quite understand. Thanks for helping me through it