[1.12] Can not register to a locked registry

[Chuckinator]

I have the error above. It says the error is on line 72 which says

Public void init (FMLInitializationEvent e){

registerItems ();

}

The registerItems method is made with this code 

Public void registerItems (RegistryEvent.Register <Item> event){

       event.getRegistry ().register (new Item ().setRegistryName ("testmod", "testitem"));

        event.getRegistry ().register (new ItemSword (Item.ToolMaterial.DIAMOND).setRegistryName ("flashmod", "flash_sword"));

[That_Martin_Guy]

Do not manually call registerItems. Just annotate it with SubscribeEvent and its class with Mod#EventBusSubscriber and it will automatically be called as long as it's static (it currently isn't).

Edited July 6, 2017 by That_Martin_Guy

[Chuckinator]

When I try to add static to either class is says its not allowed

[Chuckinator]

It still says static doesnt belong

[That_Martin_Guy]

Show code.

[Chuckinator]

I

inits.java

Main.java

[Kokkie]

Do you know java?

[That_Martin_Guy]

public void registerItems(RegistryEvent.Register<Item>event)

You wrote the type and parameter name in the same word twice in different classes. This will never work. Also, you need to store the items in variables, you can't just do create new objects and be done with it. If you ever want to check if the player is holding your sword, for example, you can't because you don't have it stored in a variable.

[Chuckinator]

I do know java. I had commented that part out in main and moved to init.

14 minutes ago, That_Martin_Guy said:

public void registerItems(RegistryEvent.Register<Item>event)

You wrote the type and parameter name in the same word twice in different classes. This will never work. Also, you need to store the items in variables, you can't just do create new objects and be done with it. If you ever want to check if the player is holding your sword, for example, you can't because you don't have it stored in a variable.

How do I do that?

[That_Martin_Guy]

Making variables is the most fundemental property of any programming language. Please, do look up a java tutorial before starting to mod. You will not make any progress otherwise.

[Chuckinator]

I KNOW FRICKIN JAVA. I HAVE BEEN DOING FOR YEARS I AM NEW TO MODDING , THIS WOULD GO ALOT FASTER IF PEOPLE WOULD HELP NOT JUDGE PEOPLE ON HOW THEY THINK THEIR LEVEL OF JAVA IS.

Edited July 6, 2017 by Chuckinator

[Alpvax]

27 minutes ago, Chuckinator said:

Quote

Also, you need to store the items in variables, you can't just do create new objects and be done with it.

How do I do that?

 

6 minutes ago, Chuckinator said:

I KNOW FRICKIN JAVA.

That doesn't look like you know java, and people don't want to waste their time teaching people basic java concepts, so please try to explain exactly what you are struggling with, rather than just complaining that people are judging you. The more information you give, the more we can help.

[Draco18s]

30 minutes ago, Chuckinator said:

I KNOW FRICKIN JAVA. I HAVE BEEN DOING FOR YEARS

No you don't, not when you ask questions like "how do I make a variable?"

[Kokkie]

Also, you tried to make an import static, nice java knowledge mate...

[That_Martin_Guy]

10 minutes ago, Kokkie said:

Also, you tried to make an import static, nice java knowledge mate...

Imports can be static. Also, let's not go out of our way to call out this guy on every mistake he makes. Whether he's new to java or not, we should not get abusive.

[Kokkie]

4 minutes ago, That_Martin_Guy said:

Imports can be static. Also, let's not go out of our way to call out this guy on every mistake he makes. Whether he's new to java or not, we should not get abusive.

Sorry, didn't look well enough... And please don't talk about abusive... Sorry that was just.. Something...

[Chuckinator]

57 minutes ago, Draco18s said:

No you don't, not when you ask questions like "how do I make a variable?"

I asked that because I already had the variable there.

[That_Martin_Guy]

Ah, now I see that variable. Your code is all over the place as far as I can tell from these files, and it's a bit hard to find them.

 

All you should have to do, besides the things we've already told you about, is pass the variable into event#getRegistry#register.

 

Also, not directly related, but don't use Item#registerItems. This is minecraft code to be used on minecraft items only. Do not call this method yourself. You should not even import it.

 

Also also, correct me if I'm wrong, but you don't need/should use GameRegistry#ObjectHolder. It just makes the code look ugly AFAIK (again, could be wrong).

[larsgerrits]

1 hour ago, That_Martin_Guy said:

Also also, correct me if I'm wrong, but you don't need/should use GameRegistry#ObjectHolder. It just makes the code look ugly AFAIK (again, could be wrong).

I think using @ObjectHolder is the intended way of using registries, and seeing that every test mod using registries uses them @ObjectHolder, it would make sense to use it as well. Also, the docs say this is the recommended way.

Edited July 6, 2017 by larsgerrits

[Chuckinator]

2 hours ago, That_Martin_Guy said:

Ah, now I see that variable. Your code is all over the place as far as I can tell from these files, and it's a bit hard to find them.

 

All you should have to do, besides the things we've already told you about, is pass the variable into event#getRegistry#register.

 

Also, not directly related, but don't use Item#registerItems. This is minecraft code to be used on minecraft items only. Do not call this method yourself. You should not even import it.

 

Also also, correct me if I'm wrong, but you don't need/should use GameRegistry#ObjectHolder. It just makes the code look ugly AFAIK (again, could be wrong).

Whats with the hastags?

And I dont know what passing a variable through is?

[Kokkie]

9 minutes ago, Chuckinator said:

Whats with the hastags?

It means a field/method etc. is static.

 

10 minutes ago, Chuckinator said:

And I dont know what passing a variable through is?

You need to call

2 hours ago, That_Martin_Guy said:

event#getRegistry#register

using the variable as a parameter.

[Draco18s]

20 minutes ago, Kokkie said:

It means a field/method etc. is static

No, no it does not. It means the exact opposite. 

[Chuckinator]

This is my code I am getting an error at getRegistry.

Main.java

[larsgerrits]

RegisterEvent.Register#getRegistry() is a method. You need to call it like a method.

Edited July 6, 2017 by larsgerrits

[Chuckinator]

I am still getting an error at get Registry

Main.java