Replace Biome X by Biome Y on Biome X spawn

[Dylem]

Hey,

 

I'd like to replace every biome of a certain ID by my own biome, is there an easy way to do that with events, or should I make a GenLayer file ?

The only event I found on biome spawn is WolrdTypeEvent.BiomeSize but it only concerns the size of biomes

[IceMetalPunk]

I don't know if this is the best way, but there is a Biome Registry (Biome#REGISTRY) which maps all the resource locations to biome classes. You could, I suppose, replace the class associated with the resource location of your choosing with your own biome class. The registry is public, so you should be able to just call, for instance, Biome.REGSITRY.register(plainsID, new ResourceLocation("minecraft", "plains"), new MyNewPlainsBiome()) or something similar. The plainsID is the ID of the plains biome (1), but depending on which biome you're replacing, you'll need to change that to the proper ID (they can all be found in the Biome#registerBiomes method). That should work (though I'm not 100% sure, so test it out).

 

Never mind; there's a much better way to do this. Just call Biome.registerBiome(ID_TO_OVERWRITE, "biome_name", new YourBiome()), with the arguments changed to the appropriate values (ID_TO_OVERWRITE being the IDs from Biome#registerBiomes, same with the name, and then an instance of your actual biome class).

Edited July 7, 2017 by IceMetalPunk
Fixed registration to be more responsible.

[Dylem]

10 minutes ago, IceMetalPunk said:

I don't know if this is the best way, but there is a Biome Registry (Biome#REGISTRY) which maps all the resource locations to biome classes. You could, I suppose, replace the class associated with the resource location of your choosing with your own biome class. The registry is public, so you should be able to just call, for instance, Biome.REGSITRY.register(plainsID, new ResourceLocation("minecraft", "plains"), new MyNewPlainsBiome()) or something similar. The plainsID is the ID of the plains biome (1), but depending on which biome you're replacing, you'll need to change that to the proper ID (they can all be found in the Biome#registerBiomes method). That should work (though I'm not 100% sure, so test it out).

 

Never mind; there's a much better way to do this. Just call Biome.registerBiome(ID_TO_OVERWRITE, "biome_name", new YourBiome()), with the arguments changed to the appropriate values (ID_TO_OVERWRITE being the IDs from Biome#registerBiomes, same with the name, and then an instance of your actual biome class).

That would be nice, but I want the biome to be replaced with a random factor (to explain, I want to replace jungle hills with my own biome but it should be rare enough that the player doesn't feel like my mod changes the game).

[IceMetalPunk]

6 minutes ago, Dylem said:

That would be nice, but I want the biome to be replaced with a random factor (to explain, I want to replace jungle hills with my own biome but it should be rare enough that the player doesn't feel like my mod changes the game).

So you want to replace only *some* Jungle Hills with your biome, but not all? That's the opposite of what you said ("every biome of a certain type").

I'd suggest you use the same method, but before you overwrite the Jungle Hills registry entry, you grab it and store it with Biome.getBiomeForId(int id) (for Jungle Hills, the registerBiomes method shows an ID of 22, for reference). Then replace the registry entry with your own, passing the captured Jungle Hills biome to the constructor for storage. Then, in your own Biome class, you can call the default Biome's methods whenever you want (for instance, call the default 90% of the time, but skip that and call your own the other 10%).

Edited July 7, 2017 by IceMetalPunk

[LexManos]

No, Biomes are a full registry, use the Register<Biome> event and just register yours as the name that you wanna override.

All other methods are hacky and you shouldn't do it.

 

But it more sounds like you just want to add a variant to the jungle biome instead of overriding it... Just make them 1/10th the weight of the vanilla one.

[IceMetalPunk]

13 hours ago, LexManos said:

No, Biomes are a full registry, use the Register<Biome> event and just register yours as the name that you wanna override.

All other methods are hacky and you shouldn't do it.

 

But it more sounds like you just want to add a variant to the jungle biome instead of overriding it... Just make them 1/10th the weight of the vanilla one.

The RegistryEvents were added after my last modding project (from 1.7.10) -- is there a list somewhere of which classes have a full registry and fire Register<T> events? Or does an event fire for every class that implements IForgeRegistryEntry, including IRecipes?

[Draco18s]

It is fired for everything.

[IceMetalPunk]

10 minutes ago, Draco18s said:

It is fired for everything.

That is good to know! Thank you.

[Dylem]

On 7/7/2017 at 9:15 AM, IceMetalPunk said:

So you want to replace only *some* Jungle Hills with your biome, but not all? That's the opposite of what you said ("every biome of a certain type").

I'd suggest you use the same method, but before you overwrite the Jungle Hills registry entry, you grab it and store it with Biome.getBiomeForId(int id) (for Jungle Hills, the registerBiomes method shows an ID of 22, for reference). Then replace the registry entry with your own, passing the captured Jungle Hills biome to the constructor for storage. Then, in your own Biome class, you can call the default Biome's methods whenever you want (for instance, call the default 90% of the time, but skip that and call your own the other 10%).

Yes sorry, only few should be replaced. That method would override gen layers on jungler hills I think

 

On 7/7/2017 at 9:55 AM, LexManos said:

No, Biomes are a full registry, use the Register<Biome> event and just register yours as the name that you wanna override.

All other methods are hacky and you shouldn't do it.

 

But it more sounds like you just want to add a variant to the jungle biome instead of overriding it... Just make them 1/10th the weight of the vanilla one.

 

I want to replace the jungle hills biome because I want my biome to be surrounded by jungle. But I'm making a GenLayer, sounds easier now..