[1.8] Cannot find my custom biome!

[Animefan8888]

Just now, Arionas_MC said:

Their height is 5+random.nextInt(5)

Not the height, but the width and depth.

[Arionas_MC]

1 minute ago, Animefan8888 said:

Not the height, but the width and depth.

2+random.nextInt(3)

[Animefan8888]

21 minutes ago, Arionas_MC said:

2+random.nextInt(3)

Try limiting it to one tree per chunk.

[Jacky2611]

Wouldn't be surprised if your trees leaves started growing over the chunk border triggering the next chunks generation. Comment out the decoration part of your custom biome and see if you can find it. Once we know that your biome is working we can help you to get your trees working.

 

Btw, if you want you could upload your project to github. Forge already comes with a gitignore file and a dependency management system, so all you have to do is follow a simple tutorial on how to upload to a repository. It would make it a lot easier if I could run your code on my own device. Plus you have a backup in case something happens to your machine.

[Draco18s]

1 hour ago, Arionas_MC said:

Their height is 5+random.nextInt(5)

Height had nothing to do with the stated problem. It is X and Z that need to be offset. 

[Arionas_MC]

1 hour ago, Jacky2611 said:

Wouldn't be surprised if your trees leaves started growing over the chunk border triggering the next chunks generation. Comment out the decoration part of your custom biome and see if you can find it. Once we know that your biome is working we can help you to get your trees working.

 

Btw, if you want you could upload your project to github. Forge already comes with a gitignore file and a dependency management system, so all you have to do is follow a simple tutorial on how to upload to a repository. It would make it a lot easier if I could run your code on my own device. Plus you have a backup in case something happens to your machine.

Hey, I just uploaded the src folder of my mod on github. You can find it here: https://github.com/ArionasMC/-1.8-MyBiomes-Mod

[Jacky2611]

Ok, thx. Now please also upload the .gitignore, build.gradle, gradlew and gradlew.bat files to make sure that we run the same version of forge.

Once you did all that it should look something like this.

(And please don't judge me for the content of this rep. All my more recent projects are on bitbucket.)

[Arionas_MC]

2 hours ago, Jacky2611 said:

Ok, thx. Now please also upload the .gitignore, build.gradle, gradlew and gradlew.bat files to make sure that we run the same version of forge.

Once you did all that it should look something like this.

(And please don't judge me for the content of this rep. All my more recent projects are on bitbucket.)

I uploaded all these files but '.gitingnore', because it says:  "#Seriously guys, stop commiting this to your git repo!"

[Jacky2611]

Give me a moment, I am pulling it now...

Damn, you are running a outdated forge version. I am currently updating everything to the recommended version for 1.8

Edited July 18, 2017 by Jacky2611

[Kokkie]

39 minutes ago, Arionas_MC said:

I uploaded all these files but '.gitingnore', because it says:  "#Seriously guys, stop commiting this to your git repo!"

It wasn't talking about the .gitignore, but about the files stated in the .gitignore.

[Jacky2611]

Sry, had to finish something else first.

I added an item that tells me the biomes position when I rightclick something with it and found this in just a few minutes. (changed the top_block of your biome to diamond to make it easier to see)

The problem definitely are your trees.

You can probably fix it if you check if the chunk has already been generated before you place any blocks in it. I tried to reupload the entire project (with a newer forge version, a fixed file structure and my (terrible) BiomeFinder) but it looks like github is down. I will do it as soon as possible.

 

Edited July 18, 2017 by Jacky2611

[Jacky2611]

And what is 

			while (world.isAirBlock(pos.down()) && pos.getY() > 55)
			{
				pos.subtract(new Vec3i(0, 1, 0));
			}
			if (!world.isAirBlock(pos))
				return false;

 

supposed to do?

 

I am guessing that you plan to go down from the highest block until you find on that is not air. The problem is that your pos y value is 0 at the start of the generate function.

Replace it with something like:

pos = new BlockPos(pos.getX(), world.getTopSolidOrLiquidBlock(pos).getY(), pos.getZ());