Advancement NBT question?

[drok0920]

Hello again,

I have finally gotten my advancements to work but now i need a functionality that im not sure exists.  I have an item that has an integer stored in its nbt and i would like my advancement to trigger when it is above a certain value.  Under some circumstances i could just list every number above the number i want but since the number can range from 0 to 100 that would not be reasonable.  So my question is how can i trigger the advancement when said value is greater than a certain amount.

[Draco18s]

In the code that modifies that integer (I mean...you wrote it...)...check to see if that integer is greater than the desired number and if so, give the player the advancement (check vanilla code for how to award advancements).

[drok0920]

  On 8/19/2017 at 3:06 PM, Draco18s said:

In the code that modifies that integer (I mean...you wrote it...)...check to see if that integer is greater than the desired number and if so, give the player the advancement (check vanilla code for how to award advancements).

Expand  

Well i was hoping to have that as one requirement and another requirement if possible.  But if this is the only way to do it other than making a custom trigger or something then i will just split the advancement in half.

[Choonster]

You should be able to extend ItemPredicate, override ItemPredicate#test and then register it with ItemPredicates.register.

 

You can then use this anywhere an item predicate is expected (e.g. in the inventory_changed trigger).

[drok0920]

  On 8/19/2017 at 3:25 PM, Choonster said:

You should be able to extend ItemPredicate, override ItemPredicate#test and then register it with ItemPredicates.register.

 

You can then use this anywhere an item predicate is expected (e.g. in the inventory_changed trigger).

Expand  

Can you explain a bit more?  Im confused.

[Choonster]

  On 8/19/2017 at 4:43 PM, drok0920 said:

Can you explain a bit more?  Im confused.

Expand  

 

Was there one part in particular that you didn't understand?

[drok0920]

  On 8/19/2017 at 4:47 PM, Choonster said:

 

Was there one part in particular that you didn't understand?

Expand  

What is an item predicate and how do i use one.

[Choonster]

  On 8/19/2017 at 4:48 PM, drok0920 said:

What is an item predicate and how do i use one.

Expand  

 

Item predicates are used by advancement criteria like inventory_changed to determine whether or not the item matches the requirements. The inventory_changed criterion will be met when all of the specified item predicates match the item in any slot of the player's inventory (i.e. the player has every required item).

 

The vanilla JSON format is documented on the wiki. For the inventory_changed criterion, each object in the items array is an item predicate.

 

If you set the type element of an item predicate to a string, Forge will use the custom ItemPredicate factory that was registered with that name (via ItemPredicates.register) instead of creating a vanilla ItemPredicate instance.

[drok0920]

Eclipse is saying that ItemPredicates is not a class so i am unable to register it.  Is it called something else now?

[Animefan8888]

  On 8/19/2017 at 7:41 PM, drok0920 said:

Eclipse is saying that ItemPredicates is not a class so i am unable to register it.  Is it called something else now?

Expand  

ItemPredicate not ItemPredicates.

[drok0920]

  On 8/19/2017 at 7:42 PM, Animefan8888 said:

ItemPredicate not ItemPredicates.

Expand  

There is no register method in ItemPredicate either.

[drok0920]

Not trying to be pushy but i still haven't fixed the issue.  How do i register the predicate?

[jabelar]

I spent some time to figure out what Choonster is talking about but couldn't follow the code in a meaningful way. As mentioned, there is no ItemPredicates class and ItemPredicate doesn't have a register method. So I'm assuming that he's created his own custom factory or registry class that he calls ItemPredicates but for the life of me I can't see where the various JSON derserializer methods will look for custom ItemPredicates. So I guess we'll have to wait for Choonster to clarify what he's talking about -- he usually knows what he's talking about!

[Choonster]

The ItemPredicates class was added in commit ee449e4 (version 1.12.1-14.22.0.2452). Make sure you're using the latest version of Forge.

[jabelar]

Okay, cool. I update almost weekly, so looks like that just came in. Nice.

[jabelar]

Actually, I usually update from the Forge download site. The "latest" there is still 14.21.1.2443. Do you really recommend downloading from github instead or weiting until it is posted at the official download site?

Edited August 20, 2017 by jabelar

[Choonster]

  On 8/20/2017 at 4:29 AM, jabelar said:

Actually, I usually update from the Forge download site. The "latest" there is still 14.21.1.2443. Do you really recommend downloading from github instead or weiting until it is posted at the official download site?

Expand  

 

You're looking at 1.12 (the current recommended version), you need to go to the 1.12.1 page.

[jabelar]

Doh, that would do it. I guess 1.12.1 got going a couple weeks ago and I missed that transition. Thanks for point it out.

[drok0920]

How do i use the register method?  It asks for a function what should i give it?

[drok0920]

Bump

[Choonster]

  On 8/21/2017 at 3:29 PM, drok0920 said:

How do i use the register method?  It asks for a function what should i give it?

Expand  

 

It needs a Function<JsonObject, ItemPredicate>, i.e. a function that takes a JsonObject and deserialises it into an ItemPredicate. You can implement this with a lambda, method reference (e.g. a constructor method reference) or an anonymous class.

 

Look at the static initialiser block in ItemPredicates and the OredictItemPredicate constructor it references for an example of this.

[drok0920]

So i think i have gotten it to work but would this be how i use the predicate:

{
    "display": {
        "icon": {
            "item": "minecraft:stone"
        },
        "title": "Stone Age",
		"description": "Hunter - Gatherers"
    },
    "criteria": {
        "tick": {
            "trigger": "modid:predicateregistryname"
			{
				"item": "poverhaul:rock",
				"quality": 1
			}
        }
    }
}

Assuming that my predicate class is the fallowing:

	package net.drok.poverhaul.predicate;
	import javax.annotation.Nullable;
	import com.google.gson.JsonObject;
	import net.drok.poverhaul.ModRegistry;
import net.drok.poverhaul.item.ItemRock;
import net.minecraft.advancements.critereon.ItemPredicate;
import net.minecraft.item.Item;
import net.minecraft.item.ItemStack;
import net.minecraft.util.JsonUtils;
	public class ItemQualityPredicate extends ItemPredicate {
	    private final Item item;
    private final Integer quality;
    
    public ItemQualityPredicate(JsonObject jsonObject) {
        this(JsonUtils.getItem(jsonObject, "item"), JsonUtils.getInt(jsonObject, "quality"));
        
    }
	    public ItemQualityPredicate(@Nullable Item i, int q)
    {
        this.item = i;
        this.quality = q;
    }
    
    @Override
    public boolean test(ItemStack stack)
    {
        if(this.item != null && stack.getItem() == this.item) {
            ItemRock rock = (ItemRock) ModRegistry.rock;
            int q = rock.getQuality(stack);
            
            if(q >= this.quality) {
                return true;
            }
        } else if(stack.getItem() == this.item) {
            ItemRock rock = (ItemRock) ModRegistry.rock;
            int q = rock.getQuality(stack);
            
            if(q >= this.quality) {
                return true;
            }
        }
        return false;
    }
    
}
 
	

Edited August 22, 2017 by drok0920

[Choonster]

What you've created is an item predicate, not a criterion trigger. You need to use an existing criterion trigger like inventory_changed but use your custom item predicate instead of the vanilla one.

 

As I said before, each object in the items array for the inventory_changed criterion is an item predicate. You need to set the type element of an item predicate object to the registry name of your custom item predicate.

[drok0920]

So would this be correct:

 

{
    "display": {
        "icon": {
            "item": "minecraft:stick"
        },
        "title": "Sticks and Stones",
		"description": "Find your first basic materials scattered around your world."
    },
    "parent": "poverhaul:stoneage/sticks_and_stones",
    "criteria": {
		"rock": {
            "trigger": "minecraft:inventory_changed",
            "conditions": {
                "items": [
                    {
                        "item": "poverhaul:rock"
                    },
					{
						"type": "poverhaul:quality",
						"quality": 1
					}
                ]
            }
        }
    }
}

 

Edit:

I got a chance to test it and it works great.  Thank you for all your help!

Edited August 22, 2017 by drok0920