[1.12] What event should Ore Dictionary registrations happen?

[jabelar]

I previously followed the advice in the forge documentation (https://mcforge.readthedocs.io/en/latest/utilities/oredictionary/) to register the ore dictionary entries "during the FMLPreInitializationEvent phase, after initializing the blocks and items that you will register".

 

However, now the blocks and items have their own registry events and I believe (based on looking at my console output) that the PreInit is actually before these registry events. So I'm guessing that ore dictionary should be registered in the item registry event after the items? Or is there a dedicated ore registry event?

 

On a related note, how can I tell which things have now have registry events? I tried to follow the code but most of it seems to give generics and I could only find where the block, item and recipe events were fired. But I think potions and biomes are also now using registry events? What is best way to see list of what has such events?

[V0idWa1k3r]

1 hour ago, jabelar said:

Or is there a dedicated ore registry event?

No, there isn't.

 

1 hour ago, jabelar said:

So I'm guessing that ore dictionary should be registered in the item registry event after the items?

You do it whenever you want. Since other mods might query oredict to enable some kind of compatibility I would suggest duing it during init(as mod compatibility should happen in post-init according to docs anyway) or in registry event directly as you've suggested.

 

1 hour ago, jabelar said:

On a related note, how can I tell which things have now have registry events?

If it implements IForgeRegistryEntry(or extends IForgeRegistryEntry.Impl) then it has a registry event(well actually rather if it has a registry then there is an event but in vanilla there is a registry for evey IForgeRegistryEntry implementation). Just lookup the usages in your IDE.

Edited August 29, 2017 by V0idWa1k3r

[Draco18s]

8 hours ago, V0idWa1k3r said:

You do it whenever you want. Since other mods might query oredict to enable some kind of compatibility I would suggest duing it during init(as mod compatibility should happen in post-init according to docs anyway) or in registry event directly as you've suggested.

Honestly, you should probably do it "as early as you can."

[jabelar]

5 minutes ago, Draco18s said:

Yeah, I was debating with myself whether I should do it in the Item registry event or the IRecipe registry event. I think at the end of the Item registry event is best because that is sure to happen after my items are registered but before my mod or any other mod registers their recipes. So then another mod presumably could register ore dictionary recipes against my ore dictionary entries.  Since the registries use string keys, perhaps the order doesn't matter so much but seems safest to me.

EDIT: Actually giving it more thought, I think it depends on whether you want to register ores against other mods or vice versa. If you want your stuff to act like another mod you'll probably want to ensure the other mod's items are already registered, so then the IRecipe registry event might be better.

Edited August 29, 2017 by jabelar

[Draco18s]

You done gone fucked up trying to quote me and put your rely inside the quote.

 

In any case, in theory, a recipe registered with an oredict reference will work even if that oredict entry doesn't exist at the time of recipe creation (but does later) because the recipe actually operates on those strings when you use the crafting table. I've never messed around with it though.

 

But it might screw up something else (e.g. "don't register this recipe unless oredict entry exists")

Edited August 29, 2017 by Draco18s

[LexManos]

Register<Item>

[jabelar]

Cool, thanks for the clarification Lex.

 

Draco, yes I also expect it is somewhat tolerant since it registers string keys rather than actual instances so probably works in various orders.

[Draco18s]

1 hour ago, jabelar said:

Draco, yes I also expect it is somewhat tolerant since it registers string keys rather than actual instances so probably works in various orders.

Mhm.

Of course, I've intentionally delayed one particular oredict registration before, as I needed to know "has any mod registered X?" before I registered my own, having registered my own it would have been more troublesome to figure out (as mine was going to get registered anyway, but I had to do another operation first).