Jump to content

Recommended Posts

Posted

My mod has some multi-block structures. In a structure, most blocks are invisible and used as placeholders, only one block has a visible model (huge one, much bigger than 1x1x1).

In most case, it just works fine, however the structure becomes invisible when I look at it from some perspective.

I believe the game thinks that this block can not be seen by the player, so the entire structure is not being rendered.

Is there any way to force the game to render a block? (Of course I can split my huge model into smaller ones, but it is going to take a lot of time and effort, and not elegant QAQ!!!)

TTTThanks in advance

My mod: SimElectricity - High Voltages, Electrical Power Transmission & Distribution

https://github.com/RoyalAliceAcademyOfSciences/SimElectricity

Posted
1 hour ago, gummby8 said:

Not sure if it exists in blocks, but for entities you set ignoreFrustumCheck to true

true, for entities/tileentities, it is easy to do.

The reason why im not using TESR is the performance loss, my model is stationary. No animated parts.

 

I had a look at the vanilla rendering code, Minecraft does not render RenderChunks(16x16x16 instead of 16x256x16!) which are considered to be invisible to the player.

RenderGlobal#renderContainer holds a list of visible chunks, only these chunks will be rendered.

ChunkRendering.thumb.png.38aa078457c49efcd71bcffb75731bef.png

Seems that its impossible to attach any other RenderChunk to the list. RenderGlobal#renderContainer is private and there's also no way to get an instance of a RenderChunk from BlockPos. Vanilla clear the list before collecting visible chunks and after rendering them. If forge can have a hook inserted just before this.renderBlockLayer(blockLayerIn), its going to be tremendously helpful!!

My mod: SimElectricity - High Voltages, Electrical Power Transmission & Distribution

https://github.com/RoyalAliceAcademyOfSciences/SimElectricity

Posted

I think you should just create a stationary invisible entity placed at the source block location, give it the model, and ignore the frustum check.

 

Of course that would only take care of the issue of seeing the structure. In both cases, as block model or entity model, you'll have to do some tricky stuff to add collision boxes where necessary.

Check out my tutorials here: http://jabelarminecraft.blogspot.com/

Posted
19 hours ago, diesieben07 said:

You might as well use a TESR at that point...

TESR is resource consuming QAQ I try not to use TESR to render stationary stuff.

And break down the whole model into submodels...I dont think thats an elegant solution....

 

If I can insert a line of code inside a vanilla class, that is going to help a lot, and perhaps help to solve similar problems like this one.

I might end up with writing a coremod or submit a Forge PR QAQ

 

Also, I noticed that there's something new called FastTESR, is possible to render a bakedmodel in a FastTESR? and how is the performance?(compare to ordinary block model rendering and TESR)

My mod: SimElectricity - High Voltages, Electrical Power Transmission & Distribution

https://github.com/RoyalAliceAcademyOfSciences/SimElectricity

Posted (edited)

Also, although it is good to think about performance the reality is that modern computers are getting faster and faster and a performance problem is only going to arise if you have a lot of something (or if you have big, recursive loops in your code, like scanning over lots of locations for something).

 

In programming it is usually recommended to do things the "proper" way first -- meaning the typical, expected and readable way -- since that usually avoids introducing new bugs and makes it more easy to maintain. Then you should profile your code and see if there are any areas of undue performance burden and the rewrite those if needed.

 

In other words, beds, chests, signs and other common minecraft stuff already use TESRs, so unless you expect to have a lot of your structures in the game then it shouldn't be much worse.

 

Lastly, I hope that each version of minecraft gets performance improvements. I know sometimes they go backwards -- I remember that 1.8 had a bunch of lag issues -- but generally would expect it to get better. For example, maybe TESRs are more efficient in 1.12.1. Only way to know is to profile.

 

Yes it is good to consider performance, but if you're going to go to coremods without even knowing how bad the performance is I suggest that you do more testing first.

Edited by jabelar
  • Like 2

Check out my tutorials here: http://jabelarminecraft.blogspot.com/

Posted (edited)

One of my friend points out a possible solution: at the end of the model baking phase, the huge baked model is splitted into smaller models, (each small model occupies a volume of a block) and then assign these smaller models to blocks. (I already have some invisible blocks to make collision boxes working properly). I'm thinking about doing this, so I don't have to modify my .obj model file.

 

Back to 1.7.10. I used to have a lot of TESRs to render my power poles, if I have lots of them, the fps can drop by about 15. (At that time my graphic card was HD3000). After migrating the rendering stuff to ISimpleBlockRenderHandler(ISBRH), the fps no longer drop that much. So I conclude that TESR degrade the performance.

Edited by Rikka0_0

My mod: SimElectricity - High Voltages, Electrical Power Transmission & Distribution

https://github.com/RoyalAliceAcademyOfSciences/SimElectricity

Posted

Apparently I'm a complete and utter jerk and come to this forum just like to make fun of people, be confrontational, and make your personal life miserable.  If you think this is the case, JUST REPORT ME.  Otherwise you're just going to get reported when you reply to my posts and point it out, because odds are, I was trying to be nice.

 

Exception: If you do not understand Java, I WILL NOT HELP YOU and your thread will get locked.

 

DO NOT PM ME WITH PROBLEMS. No help will be given.

Join the conversation

You can post now and register later. If you have an account, sign in now to post with your account.
Note: Your post will require moderator approval before it will be visible.

Guest
Unfortunately, your content contains terms that we do not allow. Please edit your content to remove the highlighted words below.
Reply to this topic...

×   Pasted as rich text.   Restore formatting

  Only 75 emoji are allowed.

×   Your link has been automatically embedded.   Display as a link instead

×   Your previous content has been restored.   Clear editor

×   You cannot paste images directly. Upload or insert images from URL.

Announcements



  • Recently Browsing

    • No registered users viewing this page.
  • Posts

    • I will keep adding to this thread with more information in case anyone can help, or at the very least I can keep my troubleshooting organized. I decided to downgrade to 54.1.0 in the hopes that this would fix the issue but it didn't. At least now I am on a "recommended" version. The crash report did confirm my earlier post that the Exception is coming from effectiveDescriptionId(). I'll continue to see if I can find a way to set the ID manually.   Caused by: java.lang.NullPointerException: Item id not set         at java.base/java.util.Objects.requireNonNull(Objects.java:259) ~[?:?]         at TRANSFORMER/[email protected]/net.minecraft.world.item.Item$Properties.effectiveDescriptionId(Item.java:465) ~[forge-1.21.4-54.1.0-client.jar!/:?]         at TRANSFORMER/[email protected]/net.minecraft.world.item.Item.<init>(Item.java:111) ~[forge-1.21.4-54.1.0-client.jar!/:?]         at TRANSFORMER/[email protected]/com.example.shotgunmod.ShotgunItem.<init>(ShotgunItem.java:19) ~[shotgunmod-1.0.0.jar!/:1.0.0]         at TRANSFORMER/[email protected]/com.example.shotgunmod.ModItems.lambda$static$0(ModItems.java:15) ~[shotgunmod-1.0.0.jar!/:1.0.0]         at TRANSFORMER/[email protected]/net.minecraftforge.registries.DeferredRegister$EventDispatcher.lambda$handleEvent      
    • It just randomly stop working after a rebooted my dedicated server PLEASE HELP!   com.google.gson   Failed to start the minecraft server com.google.gson.JsonSyntaxException: Expected a com.google.gson.JsonObject but was com.google.gson.JsonPrimitive; at path $  
    • It was working perfectly fine last night but now I'm getting an exit code -1 with the textbox: The game crashed: rendering overlay Error: net.minecraftforge.fml.ModLoadingException: Supplementaries (supplementaries) encountered an error during the done event phase Here's the crash log: https://pastebin.com/KmesArYS Any help is apricated
    • Link to Crashlog: https://pastebin.com/bKqH9fx2 Trying to set up a custom mod pack, was going smoothly up until recently as the WorldLoader screen, (the one that appears when you select "create new world" in Singleplayer), was clicked to test that it was running fine. Most Recent Few mods added were; - Create (+ its addons) - Immersive Weathering [Forge] I've tried all I could think of since loading up the game worked fine and I've never had this issue before.  Any help is appreciated.  
    • Digging in to the source, in this case net.minecraft.world.item.Item.Properties, I see these functions are the error source:         protected String effectiveDescriptionId() {             return this.descriptionId.get(Objects.requireNonNull(this.id, "Item id not set"));         }         public ResourceLocation effectiveModel() {             return this.model.get(Objects.requireNonNull(this.id, "Item id not set"));         } Can anyone share more information on how to set the Id properly? Is this something I have to do explicitly by calling the setId() function? My understanding is the ID is set implictly with these calls:       public static final DeferredRegister<Item> ITEMS = DeferredRegister.create(ForgeRegistries.ITEMS, ShotgunMod.MODID);     private static final Item.Properties p = new Item.Properties().durability(100).stacksTo(1);     public static final RegistryObject<Item> SHOTGUN = ITEMS.register("shotgun", () -> new ShotgunItem(p)); From net.minecraft.world.item.Item.Properties;  public Item.Properties setId(ResourceKey<Item> pId) {             this.id = pId;             return this;   } Thank you for your help
  • Topics

×
×
  • Create New...

Important Information

By using this site, you agree to our Terms of Use.