[1.12.1] How would I prevent 'cascading worldgen lag' during worldgen

[JJ42001]

So what I am having issues with is generating Limestone into the world in big veins. Unfortunately every time I go into the hundreds for 'blockCount' when I go to load new chunks in a pre-existing world I get no visible chunk loading / generation at all, and the game just stops all world interaction. (Can still do commands, but not exit the world) When creating a new world it just stays on the generating world loading screen. Both loading new chunks after updating 'blockCount', and creating a new world throw this too many times to count (but with a different x / y coords):

 

[00:15:56] [Server thread/WARN]: PDS loaded a new chunk (1475, 1  Dimension: 0) during chunk population, causing cascading worldgen lag. Please report this to the mod's issue tracker. This log can be disabled in the Forge config.

Here is the worldGen code:

Spoiler

package jtb.isdev.pds.util;

import jtb.isdev.pds.init.PDSBlocks;
import net.minecraft.util.math.BlockPos;
import net.minecraft.world.World;
import net.minecraft.world.chunk.IChunkProvider;
import net.minecraft.world.gen.IChunkGenerator;
import net.minecraft.world.gen.feature.WorldGenMinable;
import net.minecraft.world.gen.feature.WorldGenerator;
import net.minecraftforge.fml.common.IWorldGenerator;

import java.util.Random;

public class WorldGen implements IWorldGenerator {

private WorldGenerator limestone_overworld;

public WorldGen() {
  limestone_overworld = new WorldGenMinable(PDSBlocks.BLOCKS[1].getDefaultState(), 800);
}

private void runGenerator(WorldGenerator generator, World world, Random rand, int chunk_X,
                          int chunk_Z, int chancesToSpawn, int minHeight, int maxHeight) {
  if (minHeight < 0 || maxHeight > 256 || minHeight > maxHeight)
    throw new IllegalArgumentException("Illegal Height Arguments for WorldGenerator");

  int heightDiff = maxHeight - minHeight + 1;
  for (int i = 0; i < chancesToSpawn; i++) {
    int x = chunk_X * 16 + rand.nextInt(16);
    int y = minHeight + rand.nextInt(heightDiff);
    int z = chunk_Z * 16 + rand.nextInt(16);
    generator.generate(world, rand, new BlockPos(x, y, z));
  }
}

@Override
public void generate(Random random, int chunkX, int chunkZ, World world, IChunkGenerator chunkGenerator,
                     IChunkProvider chunkProvider) {
  switch (world.provider.getDimension()) {
    case 0:
      runGenerator(limestone_overworld, world, random, chunkX, chunkZ, 1, 42, 46);
      break;
    case -1:

      break;
    case 1:

      break;
  }
}
}

This is the only way I know how to generate blocks into the world, so any help on this would be helpful. Thanks in advance, Sincerely JJ42001

[Draco18s]

See:

 

[JJ42001]

Alright well that shows me whats causing the issue, but I'm still not quite sure what to do to fix it.

 

Quote

Correct world generation offsets everything by +8, +8 so that all generation happens in the middle of loaded chunks, and has a low chance of spilling out.

Because I am trying to generate such a large number of blocks in a single instance, that one instance takes up about 4-9 chunks every time that a limestone patch is generated, wouldn't centering the generation still cause overlapped generation to load the other chunks?

 

Quote

If you use vanilla classes like WorldGenMinable then the offset is already built in, but if you have a custom one make sure it is generating properly.

I am using

worldGenMinable

Am I using it correctly?

 

Edit:

Quote

Yeah, one thing I didn't mention in the original post is that if your worldgen structure is bigger than a chunk it's going to always overflow, so you need more advanced strategies.

I'll keep looking deeper into it.

Edited September 14, 2017 by JJ42001

[LexManos]

Your core concept of generating things cross chunks is bad.

You should work on your system and figure out a way to generate things within the chunk boundaries.

[jeffryfisher]

In other words, look at how large structures (fortress, mine, stronghold) are generated. Devise a way to generate only the portion within the called chunk and the neighboring edges of the chunks to the South & East. Even when generating within the called chunk, take care to avoid changing any blocks along the north or west edges.

 

Alternatively, it might be possible to cheat by setting a flag while generating a vein and clearing the flag after the vein and all of its chunks are complete. Don't allow a new vein to generate if the flag is already set. You'd have to experiment to see if this would contain the spread. Even then, it would mean that your world would be non-deterministic in that the positions of these veins would depend partly on the order in which players explore the world.

[JJ42001]

Interesting, I'll have to try that, and I'll keep poking at it and trying things until I find out how to get it working.

[JJ42001]

How would I go about finding the generation of strongholds, mine shafts and nether fortresses?

[JJ42001]

So, I still cant figure out how to see minecraft's worldGen codes, but I've been changing and adding things in my code here and there and still can't quite get it to function.

 

This is what I currently have, which what I thought would only spawn the portion of the vein if 'isLoaded' returns true, but when I load up a world, there are none to be found....anywhere.

Quote

package jtb.isdev.pds.util;

import jtb.isdev.pds.init.PDSBlocks;
import net.minecraft.client.multiplayer.ChunkProviderClient;
import net.minecraft.util.math.BlockPos;
import net.minecraft.world.World;
import net.minecraft.world.chunk.IChunkProvider;
import net.minecraft.world.gen.IChunkGenerator;
import net.minecraft.world.gen.feature.WorldGenMinable;
import net.minecraft.world.gen.feature.WorldGenerator;
import net.minecraftforge.fml.common.IWorldGenerator;

import java.util.Random;

import static jtb.isdev.pds.DataMain.MLOG;

public class WorldGen implements IWorldGenerator {

private WorldGenerator limestone_overworld;

public WorldGen() {
  limestone_overworld = new WorldGenMinable(PDSBlocks.BLOCKS[1].getDefaultState(), 256);
}

private void limestoneGenerator(WorldGenerator generator, World world, Random rand, int chunkXPos, int chunkZPos, int chanceToSpawn, int height) {
  if (height < 0 || height > 256)
    throw new IllegalArgumentException("Illegal Height Arguments for WorldGenerator");

  int doGen = rand.nextInt(chanceToSpawn);
  if (doGen == chanceToSpawn) {
    int y = height;
    int cx = chunkXPos * 16 + rand.nextInt(16);
    int cz = chunkZPos * 16 + rand.nextInt(16);

    BlockPos veinPos = new BlockPos(cx, y, cz);
    boolean isLoaded = new ChunkProviderClient(world).isChunkGeneratedAt(cx, cz);

    if (isLoaded) {
      generator.generate(world, rand, veinPos);
      Utils.getLogger().info(MLOG + ": Limestone vein at: x= " + cx + " y= " + y + " z= " + cz);
    }
  }
}

@Override
public void generate(Random random, int chunkX, int chunkZ, World world, IChunkGenerator chunkGenerator,
                     IChunkProvider chunkProvider) {
  switch (world.provider.getDimension()) {
    case 0:
      limestoneGenerator(limestone_overworld, world, random, chunkX, chunkZ, 5, 48);
      break;
    case -1:

      break;
    case 1:

      break;
  }
}
}

Even when I remove the if statement I still get no veins to generate.

 

Edited September 15, 2017 by JJ42001

[Choonster]

Look at the net.minecraft.world.gen package for Minecraft's world generation classes. Structures like the Stronghold, Mineshaft and Nether Fortress are in the net.minecraft.world.gen.structure package.

[jeffryfisher]

23 hours ago, JJ42001 said:

int doGen = rand.nextInt(chanceToSpawn)

; if (doGen == chanceToSpawn) {...

 

nextInt will always return 0-(n-1), so its result will never equal n.

Edited September 16, 2017 by jeffryfisher