[1.12] Help registering a block

[Big_Bad_E]

I feel really nooby(Is that even a word?) asking this, but I cannot seem to get a block to register. I followed forge documentation then looked at choonster's TestMod3 and tried that method, but no luck.

Main Class:

@Mod(modid = "modid", version = "v1.0.0 - Mc 1.12", name = "mod")
public class Mod {

}

Registry class:

public static final SaltOre saltOre = new SaltOre();
	
	public static void registerBlocks(final RegistryEvent.Register<Block> event) {
		final IForgeRegistry<Block> registry = event.getRegistry();

		final Block[] blocks = {
				saltOre,
		};
		registry.registerAll(blocks);
	}
		@SubscribeEvent
		public static void registerItemBlocks(final RegistryEvent.Register<Item> event) {
			final ItemBlock[] items = {
					new ItemBlock(saltOre),
			};
		}

Block class:

     super(Material.ROCK);
        setUnlocalizedName("saltOre");
        setRegistryName("SaltOre");
        setCreativeTab(CreativeTabs.BUILDING_BLOCKS);
    }

Idk what I am forgetting, it's probably something obvious though.

EDIT: I have tried it with the way in the forge Docs and without the registerItemBlocks

Edited September 30, 2017 by Big_Bad_E

[Draco18s]

1 hour ago, Big_Bad_E said:

setRegistryName("SaltOre");

Registry name needs to be all lower case.

 

1 hour ago, Big_Bad_E said:

setUnlocalizedName("saltOre");

Unlocalized name should contain your mod ID, most people do this by setting the registry name and then calling setUnlocalizedName(getRegistryName().toString())

[Big_Bad_E]

i'm not even going to try to find an excuse for forgetting to use lower cases...

 

Also, Still not working, I think it is the registry. I don't know how it works at all. I changed the registry code a bit, here's my new classes:

Registry:

package Big_Bad_E;

import net.minecraft.block.Block;
import net.minecraftforge.event.RegistryEvent;
import net.minecraftforge.fml.common.eventhandler.SubscribeEvent;
import Big_Bad_E.Blocks.SaltOre;

public class Registery {

	public static final SaltOre saltore = new SaltOre();
	
	@SubscribeEvent
	public void registerBlocks(RegistryEvent.Register<Block> event) {
		event.getRegistry().registerAll(saltore);
	}
}

Block Class:

package Big_Bad_E.Blocks;

import net.minecraft.block.Block;
import net.minecraft.block.material.Material;
import net.minecraft.creativetab.CreativeTabs;

public class SaltOre extends Block {

	public SaltOre() {
        super(Material.ROCK);
        setUnlocalizedName(getRegistryName().toString());
        setRegistryName("saltore");
        setCreativeTab(CreativeTabs.BUILDING_BLOCKS);
    }
}

 

[Big_Bad_E]

1 hour ago, Draco18s said:

Registry name needs to be all lower case.

 

Unlocalized name should contain your mod ID, most people do this by setting the registry name and then calling setUnlocalizedName(getRegistryName().toString())

Any other problems you notice?

[Draco18s]

You don't have a ModelRegistryEvent, meaning your block in the inventory will be black and purple.

[LexManos]

1) dont statically inialize your blocks thats bad

2) You need to set the unlocalized name AFTER the registry name if they depend on it

3) You should pass in your modid to the registry name.

 

[Draco18s]

7 hours ago, LexManos said:

3) You should pass in your modid to the registry name.

Uh, Lex. You don't have to. setRegistryName already handles it. Line 9:

 

1.        public final T setRegistryName(String name)
2.        {
3.            if (getRegistryName() != null)
4.                throw new IllegalStateException("Attempted to set registry name with existing registry name! New: " + name + " Old: " + getRegistryName());
5.            int index = name.lastIndexOf(':');
6.            String oldPrefix = index == -1 ? "" : name.substring(0, index);
7.            name = index == -1 ? name : name.substring(index + 1);
8.            ModContainer mc = Loader.instance().activeModContainer();
9.            String prefix = mc == null || (mc instanceof InjectedModContainer && ((InjectedModContainer)mc).wrappedContainer instanceof FMLContainer) ? "minecraft" : mc.getModId().toLowerCase();
10.            if (!oldPrefix.equals(prefix) && oldPrefix.length() > 0)
11.            {
12.                FMLLog.bigWarning("Dangerous alternative prefix `{}` for name `{}`, expected `{}` invalid registry invocation/invalid name?", oldPrefix, name, prefix);
13.                prefix = oldPrefix;
14.            }
15.            this.registryName = new ResourceLocation(prefix, name);
16.            return (T)this;
17.        }

Unless you're telling us that you're going to make it not do that, throw warnings, or similar.

[Big_Bad_E]

I did it already, I tried what you said, but in the end I got it myself.

[LexManos]

1 hour ago, Draco18s said:

Uh, Lex. You don't have to. setRegistryName already handles it. Line 9:

I know I wrote the code. There is a difference between what the code supports, and what you SHOULD do.

[Draco18s]

11 minutes ago, LexManos said:

There is a difference between what the code supports, and what you SHOULD do.

If a modder should do something, then it should throw warnings when they don't. If there's no error or warning, then it's assumed to be correct.

 

I'm not going to bother with the string concatenation that isn't required just because you said I should even though it'll just get split into two strings again.

Edited October 1, 2017 by Draco18s

[LexManos]

Thats one train of thought, for a sane programming environment.

Minecraft is full of kids who complain if you even think of trying to apply a standard.

Not to mention nobody cares about warnings {See Every Mod Pack Ever having 10,000+ warning at startup}

So this is what we have.

Just take it on the word of the guy who wrote the damn thing what the intention was.