As I understand it, the currently recommended practice is to both instantiate and register all IForgeRegistryEntry implementations during the appropriate registry event and use @ObjectHolder to inject them into fields.

 

When attempting to refactor my code to this pattern, I ran into an issue: I need to create PotionTypes for all of my mod's Potions during RegistryEvent.Register<PotionType>, but the @ObjectHolder fields storing my Potions are still null at this point because object holders aren't applied between RegistryEvent.Register<Potion> and RegistryEvent.Register<PotionType>.

 

What should I do here? Should I just look up the Potions from the registry manually? Should I apply object holders? Should Forge apply object holders after each registry event?

Seems to me like Forge should apply object holders after each registry event.

 

Is there a similar problem between Register<Block> and Register<Item>?

cpw was adamant about not reapplying object holders to all registries until the end.

Blocks and Item are special cased because "reasons"

If you need something from a old registry for a new one, either store it in a temporary variable, or read it from the other registry.

 

1 hour ago, LexManos said:

cpw was adamant about not reapplying object holders to all registries until the end.

Blocks and Item are special cased because "reasons"

If you need something from a old registry for a new one, either store it in a temporary variable, or read it from the other registry.

 

Thanks, I'll just look up the Potion from the registry manually.