[1.11.2][UNSOLVED] Custom Crafting Block Not Crafting

[ModMCdl]

3 minutes ago, Draco18s said:

Instead of using Slot you use SlotItemHandler and instead of casting to IInventory you use getCapability().

Would I be replacing every instance of Slot? Or would just setting it in SlotPestleOutput.java do that? This sounds like a basic java question to be asking...

[Draco18s]

Your TE's slots only. The Player's inventory is still an IInventory.

[ModMCdl]

1 minute ago, Draco18s said:

Your TE's slots only. The Player's inventory is still an IInventory.

But I would extend Slot still?(In my custom output slot) And where am I adding the getCapability() method? If I'm not casting anything, how would this work to fix it?

[Differentiation]

10 minutes ago, ModMCdl said:

But I would extend Slot still?(In my custom output slot) And where am I adding the getCapability() method? If I'm not casting anything, how would this work to fix it?

[Side comment: all readers except OP may ignore this]

Cool signature!

Edited November 4, 2017 by Differentiation

[ModMCdl]

2 minutes ago, Differentiation said:

[Side comment: all readers except OP may ignore this]

Cool signature!

Thank... you?

[Differentiation]

Just now, ModMCdl said:

Thank... you?

No probs. bud., I mean it

Edited November 4, 2017 by Differentiation

[Draco18s]

1 hour ago, ModMCdl said:

But I would extend Slot still?(In my custom output slot)

If you need your own custom slot class, extend SlotItemHandler. It already extends Slot for you and does 99% of what you need to interact with the ItemHandlerCapability in a GUI.

Quote

 And where am I adding the getCapability() method? If I'm not casting anything, how would this work to fix it?

Anywhere you are doing world.getTileEntity() and casting to IInventory. You instead call .getCapability() on the TE (instead of casting), passing in CapabilityItemHandler.ITEM_HANDLER_CAPABILITY object as the Capability to get. That capability is then the ItemStackHandler object that is your inventory (magic!). You would also pass in a side, but for GUI stuff, null is appropriate (represents "self" or similar, if you don't actually care about sided inventories, then it doesn't matter at all).

Edited November 4, 2017 by Draco18s

[ModMCdl]

8 hours ago, Draco18s said:

If you need your own custom slot class, extend SlotItemHandler. It already extends Slot for you and does 99% of what you need to interact with the ItemHandlerCapability in a GUI.

Anywhere you are doing world.getTileEntity() and casting to IInventory. You instead call .getCapability() on the TE (instead of casting), passing in CapabilityItemHandler.ITEM_HANDLER_CAPABILITY object as the Capability to get. That capability is then the ItemStackHandler object that is your inventory (magic!). You would also pass in a side, but for GUI stuff, null is appropriate (represents "self" or similar, if you don't actually care about sided inventories, then it doesn't matter at all).

So, I would then have to create this as a method in my individual TileEntity. Alright. Would I still be implementing nothing? Or would I now need to implementICapabilityProvider?

[ModMCdl]

36 minutes ago, diesieben07 said:

TileEntity already implements ICapabilityProvider.

Well I was only asking because my container errors on me calling the two getCapability() here, saying to create the method in my TileEntity, when my TileEntity already overrides that method:

ContainerPestle(InventoryPlayer player, TileEntityPestle tileentity) { //CustomSlots
		this.tileentity = tileentity;
		this.addSlotToContainer(new SlotItemHandler(tileentity.getCapability(CapabilityItemHandler.ITEM_HANDLER_CAPABILITY), 0, 32, 25));
		this.addSlotToContainer(new SlotItemHandler(tileentity.getCapability(CapabilityItemHandler.ITEM_HANDLER_CAPABILITY), 1, 67, 44));
		this.addSlotToContainer(new SlotPestleOutput(player.player, tileentity, 2, 124, 35));

My TileEnitity:

	@Override
    public boolean hasCapability(Capability capability, EnumFacing facing)
    {
        if (capability == CapabilityItemHandler.ITEM_HANDLER_CAPABILITY) return true;
        return super.hasCapability(capability, facing);
    }

    @Override
    public <T> T getCapability(Capability<T> capability, EnumFacing facing) {
    	if (capability == CapabilityItemHandler.ITEM_HANDLER_CAPABILITY) return (T) inventory;
        return super.getCapability(capability, facing);
    }

 

Edited November 4, 2017 by ModMCdl

[loordgek]

getCapability needs a EnumFacing

look at ICapabilityProvider

Edited November 4, 2017 by loordgek

[ModMCdl]

Just now, loordgek said:

getCapability needs a EnumFacing

So, I would return this as "null" since I don't care about the direction. Aha! So while all of these "fixes" have cleaned up all of my errors, they haven't actually solved my issue, and have created more. My GUI no longer shows up, and still nothing can be crafted.

[Differentiation]

On 11/4/2017 at 11:49 AM, ModMCdl said:

I would return this as "null" since I don't care about the direction.

That's obvious... most of the time you don't even use EnumFacing in getCapability() anyway so you just set it to null.

Edited November 9, 2017 by Differentiation

[ModMCdl]

7 minutes ago, Differentiation said:

That's obvious... most of the time you don't even use EnumFacing in getCapability() anyway so you just set it to null.

Hence why I didn't know I needed it. It was an oversight on my part. Was trying to focus on fixing all of the problems that this "conversion" made for me, and just overlooked that argument.

 

Everything here was working fine except for the crafting, which I think could've been caused by me forgetting to call something somewhere. Considering my code was literally pulled from the furnace block, I feel like most of what I've been told here was more of "use this new fancy way" rather than trying to actually fix the problem at hand with the code I supplied. Old ways of doing things work fine if they're implemented correctly, and since I'm going to be the one working on it, it doesn't matter that it's sloppy. I feel like a lot of people don't get that here.

[larsgerrits]

7 minutes ago, ModMCdl said:

I feel like most of what I've been told here was more of "use this new fancy way" rather than trying to actually fix the problem at hand with the code I supplied.

We did both. Using "this new fancy way" eliminated a lot of the problems the IInventory system can cause, so we can more easily figure out what the issue actually is.

 

Also, if you don't use the capability system, a lot of machines won't be able to interact with your block (e.g. for automating).

 

7 minutes ago, ModMCdl said:

since I'm going to be the one working on it, it doesn't matter that it's sloppy.

That's right, until you have to ask a question here and other people need to work with your code as well.

Edited November 9, 2017 by larsgerrits

[ModMCdl]

Just now, larsgerrits said:

We did both. Using "this new fancy way" eliminated a lot of the problems the IInventory system can cause. Also, if you don't use the capability system, a lot of machines won't be able to interact with your block.

But now you've left me with a new system to learn, while I had most of if not all of the work done with the older system.

1 minute ago, larsgerrits said:

That's right, until you have to ask a question here and other people need to work with your code as well.

I guess, but that's not really what I meant. I meant more of using the old code. Plenty of the experienced modders here like you and others who help can pick through it, because you know the methods and the old ways. It just seems that everywhere I look these are being forced on others because they're new. I don't need my mortar and pestle to work with other machines. I need it to be able to combine two ingredients, and the furnace's code seems the most likely candidate to do that. 

-

Attempting to implement IItemHandler broke the entirety of my code. My TileEntity, the GUI, my Container, and my Block no longer work the way they're supposed to. I understand that this forum hates code chunks, and people writing other's code or working with it, but for some things, especially when they're new, it's incredibly difficult and frustrating. I know modding isn't for beginner programmers, but even for veterans like me, moving from a system of rigid structure to this (arguably) sloppy mess, is very hard.

 

Essentially, yes, I know HOW to do that, but WHY and WHERE do I do that?