Hello, i use event PlayerEvent.Clone for saving items with death, but if i use that code, my mc has been crashed.

@SubscribeEvent
    public void onClone(PlayerEvent.Clone e)
    {
        if (e.wasDeath)
        {
            ItemStack backStack = null;

            for (ItemStack stack : e.original.inventory.mainInventory)
            {
                if (stack != null && (stack.getItem() instanceof ModGun || stack.getItem() instanceof ModTool))
                {
                    backStack = stack;
                }
            }

            if (backStack != null)
            {
                e.entityPlayer.inventory.addItemStackToInventory(backStack);
            }
        }
    }

What's the problem?

What's the crash?

dont know it is the problem

stack in 1.11 and up are not null check for isEmpty()

15 minutes ago, loordgek said:

dont know it is the problem

stack in 1.11 and up are not null check for isEmpty()

Amended

49 minutes ago, Draco18s said:

What's the crash?

So, isEmpty corrects this, but items is not saving:/

10 hours ago, diesieben07 said:

Look at EntityPlayerMP::copyFrom to see how data is copied over in case of a non-death copy. Then apply that to the death copy.

Yes, but this copy inventory, not a specific item.

52 minutes ago, WildHeart said:

Yes, but this copy inventory, not a specific item.

Just compare each item in the inventory with the one you want and if it is in the inventory copy it.

20 minutes ago, jabelar said:

Just compare each item in the inventory with the one you want and if it is in the inventory copy it.

So, if (st.getItem() instanceof MyItem)

{

 e.entityPlayer.inventory.copyInv(e.original.inventory);

}

Edited December 8, 20177 yr by WildHeart

3 hours ago, diesieben07 said:

No. Look at what copyInventory does and adapt it for your needs.

@SubscribeEvent
    public void onClone(PlayerEvent.Clone e)
    {
        if (e.wasDeath)
        {
            InventoryPlayer inv = e.entityPlayer.inventory; 
            
            for (int i = 0; i < inv.getSizeInventory(); ++i)
            {
                if (inv.getStackInSlot(i).getItem() instanceof CustomArmor || 
                        inv.getStackInSlot(i).getItem() instanceof CustomWeapon)
                {
                    inv.setInventorySlotContents(i, e.original.inventory.getStackInSlot(i));
                }
            }
        }
    }

?

Why are you getting from and setting to the same inventory?

3 minutes ago, Draco18s said:

Why are you getting from and setting to the same inventory?

Ups, my fail. Corrected.

@SubscribeEvent
    public void onClone(PlayerEvent.Clone e)
    {
        if (e.wasDeath)
        {
            InventoryPlayer orig = e.original.inventory;

            for (int i = 0; i < orig.getSizeInventory(); ++i)
            {
                if (orig.getStackInSlot(i).getItem() instanceof CustomArmor ||
                        orig.getStackInSlot(i).getItem() instanceof CustomWeapon)
                {
                    e.entityPlayer.inventory.setInventorySlotContents(i, orig.getStackInSlot(i));
                }
            }
        }
    }

 

Solved!