Help registering block!

[Big_Bad_E]

This question is probably asked every five seconds, but I quit Forge for a while to learn basic Java and OOP principals and stuff like that, but I can't seem to figure out how to register a block.

 

So I have my main class, no proxy (yet):

@Mod(name = "Name", version = "1.0.0", modid = "modid")
public class Main {
	
	@EventHandler
	public void PreInitializationEvent(FMLPreInitializationEvent event) {
		
	}
	
	@EventHandler
	public void InitializationEvent(FMLInitializationEvent event) {
		
	}
	
	@EventHandler
	public void PostInitializationEvent(FMLPostInitializationEvent event) {
		
	}
}

My Block Class:

public class MyBlock extends Block {

	public MyBlock(Material material) {
		super(material);
		this.setHarvestLevel("Pickaxe", 2);
		this.setCreativeTab(CreativeTabs.BUILDING_BLOCKS);
		this.setUnlocalizedName("myblock");
	}

}

Registry:

public class BlockRegistry {
	public static final Block myblock = new MyBlock(Material.ROCK);
	
	@SubscribeEvent
	public void registerBlocks(RegistryEvent.Register<Block> event) {
	    event.getRegistry().registerAll(myblock);
	}
	
	@SubscribeEvent
	public void registerBlockItems(RegistryEvent.Register<Item> event) {
	    event.getRegistry().registerAll(new ItemBlock(myblock));
	}
}

I am taking an educated guess and saying I need to call my registry in my proxies (and make one ) but I don't know what methods to use.

Any help is appreciated!

Probably not needed but I got no errors except the one from connecting to realms.

Edited December 8, 2017 by Big_Bad_E
item, block, no difference!

[Big_Bad_E]

Removed the static, don't know why it was there from some random code snippet I used .-.

[Silly511]

Your BlockRegistry class is never registered as an event handler. Change all the registry methods to static and annotate the class with @EventBusSubscriber.

[Draco18s]

You also never set a registry name for your block (and item).

You also should set your unlocalized name to the registry name using getRegistryName() so that your mod ID is part of the unlocalized name to avoid naming conflicts with other mods.

[Big_Bad_E]

Changed my code for your suggestions, new code:

public class Main {
	
	@EventHandler
	public void PreInitializationEvent(FMLPreInitializationEvent event) {
		
	}
	
	@EventHandler
	public void InitializationEvent(FMLInitializationEvent event) {
		
	}
	
	@EventHandler
	public void PostInitializationEvent(FMLPostInitializationEvent event) {
		
	}
}

Block:

public class MyBlcok extends Block {

	public MyBlock(Material material) {
		super(material);
		this.setHarvestLevel("Pickaxe", 2);
		this.setCreativeTab(CreativeTabs.BUILDING_BLOCKS);
		this.setUnlocalizedName(getRegistryName() + ":myblock");
	}

}

Registry:

@EventBusSubscriber
public class BlockRegistry {
	public static final Block myblock = new MyBlock(Material.ROCK);
	
	
	public static void registerBlocks(RegistryEvent.Register<Block> event) {
	    event.getRegistry().registerAll(myblock);
	}
	
	public static void registerBlockItems(RegistryEvent.Register<Item> event) {
	    event.getRegistry().registerAll(new ItemBlock(myblock));
	}
}

Should I register the event? idk any ideas are appreciated.

[loordgek]

10 hours ago, Draco18s said:

You also never set a registry name for your block (and item).

 

 

you need @SubscribeEvent on the event methods

https://github.com/loordgek/Extragenarators/blob/trytofix/src/main/java/loordgek/extragenarators/event/CommonEventHandler.java#L14

[Big_Bad_E]

8 minutes ago, loordgek said:

 

 

you need @SubscribeEvent on the event methods

https://github.com/loordgek/Extragenarators/blob/trytofix/src/main/java/loordgek/extragenarators/event/CommonEventHandler.java#L14

oops lol missed that part, but two questions:

 

1. Do I use @SubscribeEvent like I did at first, or @EventBusSubscriber?

 

2. What is the suggested registry name? do I do modid:item or is it the modid: + resource location to the .png of the texture? idk

[Ugdhar]

Just now, Big_Bad_E said:

1. Do I use @SubscribeEvent like I did at first, or @EventBusSubscriber?

Both

 

Just now, Big_Bad_E said:

2. What is the suggested registry name? do I do modid:item or is it the modid: + resource location to the .png of the texture? idk

registry name is the name of the thing, it will append the modid for you. then you can setUnlocalizedName(getRegistryName.toString())

The registry name will be the name of the textures/models

[loordgek]

@EventBusSubscriber tells forge "hey this is a class that has event methods"

 

@SubscribeEvent tells forge "hey this method needs to recessive the event"

[Big_Bad_E]

5 hours ago, Ugdhar said:

Both

 

registry name is the name of the thing, it will append the modid for you. then you can setUnlocalizedName(getRegistryName.toString())

The registry name will be the name of the textures/models

 

5 hours ago, loordgek said:

@EventBusSubscriber tells forge "hey this is a class that has event methods"

 

@SubscribeEvent tells forge "hey this method needs to recessive the event"

Oh... I thought I had to do the whole register event thing, but this works too. that's real cool!

Thanks for the help