Register Blocks with Enum still not fixed

[shane020482]

Has anybody figured out how to register Blocks with Property Enum on 1.12.2, Old code https://pastebin.com/aBguc6T3 Problem is GameRegistry.register is now hidden and now requires either ForgeRegistries constants Or the registry passed in during the RegistryEvent.Register<T> event and i cant figure out how to get this to work.

 

Edit: I hate to be such a bother but I'v gotten the Blocks and ItemBlocks in game however I'm still getting Item Inventory console errors and it doesn't work with Forge Blockstates so I must still have something wrong in my ItemBlock Registry.

ItemBlock Registry

https://pastebin.com/xYVjuwCA

Console

https://pastebin.com/iJpb3LpQ

Edited May 27, 2018 by shane020482
Update

[diesieben07]

http://mcforge.readthedocs.io/en/latest/concepts/registries/

[shane020482]

I know how to register basic blocks, I actually like the new method of registering but to register a block that uses a enum is where im having trouble. Iv tried several diff ways to register a enum block using the event registry without any luck.

[Draco18s]

52 minutes ago, shane020482 said:

I know how to register basic blocks, I actually like the new method of registering but to register a block that uses a enum is where im having trouble. Iv tried several diff ways to register a enum block using the event registry without any luck.

Enum? Do you mean a block with a state property? Its done exactly the same way...

[shane020482]

So your saying i dont need a special register with a for loop to cove the diff values of the enum

[Draco18s]

The only loop you would need would be to register models for the ItemBlock variants, if applicable.

For all variant blocks, you can use this:

https://github.com/Draco18s/ReasonableRealism/blob/1.12.1/src/main/java/com/draco18s/hardlib/client/ClientEasyRegistry.java#L65-L71

(Line 70 eventually resolves to ModelLoader.setCustomModelResourceLocation(iblock, block.getMetaFromState(state), new ModelResourceLocation(block.getRegistryName(), str)); )

Edited May 21, 2018 by Draco18s

[LexManos]

Honestly, you're being so vague it'd difficult to understand what you're trying to do.

Show all your code related to what you're trying to do. 

[shane020482]

I am trying to register a block that uses PropertyEnum. 

Block: https://pastebin.com/WA2AGKJ6 

Init/Regester: https://pastebin.com/25VsFxc8

[Draco18s]

Register the block: looks fine

Register the item: looks fine

Register the item's model: see prior post

[shane020482]

3 minutes ago, Draco18s said:

Register the block: looks fine

Register the item: looks fine

Register the item's model: see prior post

Yea i cant for the life of me figure out how to incorporate your code into mine

[Draco18s]

Take my code, put it inside of your line 95, replacing my line 70 with the equivalent in my prior post. Which I have to edit, because I forgot the new ModelResourceLocation bit.

[shane020482]

Im getting a error

The method _registerBlockWithCustomItem(Block, Block, String) is undefined for the type Object

[Draco18s]

Yes. You didn't do this:

55 minutes ago, Draco18s said:

replacing my line 70 with the equivalent in my prior post.

[shane020482]

public void _registerBlockWithCustomItem(Block block, ItemBlock iBlock, String registryname) {
		super._registerBlockWithCustomItem(block, iBlock, registryname);
		StateMapperBase b = new DefaultStateMapper();
		net.minecraft.block.state.BlockStateContainer bsc = block.getBlockState();
		ImmutableList<IBlockState> values = bsc.getValidStates();
		for(IBlockState state : values) {
			String str = b.getPropertyString(state.getProperties());
			ModelLoader.setCustomModelResourceLocation(iBlock, block.getMetaFromState(state), new ModelResourceLocation(block.getRegistryName(), str)); 
		}
	}

 

[Draco18s]

That should work. You still need to invoke that method of course, but it looks correct.

And it needs to be client-side-only, as does all other model registration code.

[shane020482]

nope

[Draco18s]

29 minutes ago, shane020482 said:

nope

 

You don't need that line. I only highlighted lines 65 through 71, that was from line 64.

[shane020482]

still only showing up as 1 block maybe i just need a break 

[diesieben07]

That has nothing to do with models. ItemBlock by default only works for blocks without variants. Look at the vanilla blocks that have variants and the ItemBlock classes they use.

[shane020482]

Finally got the blocks in game, just like i did in older versions created my own itemblockenun class then just register like normal in 1.12 but call the itemblockenum class instead of ItemBlock. Still need to get the item models to register but that shouldn't be too hard

@SubscribeEvent
    public static void registerItemBlocks(RegistryEvent.Register<Item> event)
    {
        event.getRegistry().registerAll(new ItemBlock(block_test).setRegistryName(block_test.getRegistryName()));
         
        event.getRegistry().registerAll(new itemblockenum(block_test_enum).setRegistryName(block_test_enum.getRegistryName()));
    }  

 

[shane020482]

and here it is my current Init/Registry class https://pastebin.com/b0eJhrF1
with the new 1.12 registry system it is so much cleaner and easier when you figure it out

[shane020482]

9 hours ago, diesieben07 said:

That has nothing to do with models. ItemBlock by default only works for blocks without variants. Look at the vanilla blocks that have variants and the ItemBlock classes they use.

This is what i needed i was just overthinking this and needed someone to tell me to go back and look at the basics. Thanks