Jump to content
Search the Forums BEFORE making a new post.
Currently supported: All versions

[Solved][1.10.2]Get problem with block rendering.

bxzsj

By bxzsj
in Modder Support

 Share

Recommended Posts

bxzsj Tree Puncher

bxzsj

Posted
Posted (edited)

I'm trying to define a block use vanilla cube model to render with 7 variant,but got some problem that block not be right render.

No error show in log(here).(block registry name is "energy_block")
Item renders well, but block got wrong.

block state in the following picture are correct.
no error "Exception loading model for variant" about this block(energy_block).

I'm sorry, I don't understand how json to model and connect with block state.


I'm not sure if I've done the wrong thing that use a wrong register Block State Mapper(here)
source code:

block(here)

Spoiler 

package com.bxzmod.someusefulthings.blocks;

import com.bxzmod.someusefulthings.EnumIO;
import com.bxzmod.someusefulthings.UnlistedPropertyIO;
import com.bxzmod.someusefulthings.core.energy.IEnergySide;
import com.bxzmod.someusefulthings.tileentity.EnergyBlockTileEntity;
import com.google.common.collect.Lists;
import com.google.common.primitives.Booleans;

import net.minecraft.block.properties.IProperty;
import net.minecraft.block.properties.PropertyDirection;
import net.minecraft.block.properties.PropertyEnum;
import net.minecraft.block.state.BlockStateContainer;
import net.minecraft.block.state.IBlockState;
import net.minecraft.entity.EntityLivingBase;
import net.minecraft.item.ItemStack;
import net.minecraft.tileentity.TileEntity;
import net.minecraft.util.EnumFacing;
import net.minecraft.util.math.BlockPos;
import net.minecraft.world.IBlockAccess;
import net.minecraft.world.World;
import net.minecraftforge.common.property.ExtendedBlockState;
import net.minecraftforge.common.property.IExtendedBlockState;
import net.minecraftforge.common.property.IUnlistedProperty;

public class EnergyBlock extends BaseBlockContainer
{
	public static final PropertyDirection FACING = PropertyDirection.create("facing", Lists.newArrayList(EnumFacing.values()));
	public static final PropertyEnum<EnumIO> UP = PropertyEnum.create("up", EnumIO.class);
	public static final PropertyEnum<EnumIO> DOWN = PropertyEnum.create("down", EnumIO.class);
	public static final PropertyEnum<EnumIO> NORTH = PropertyEnum.create("north", EnumIO.class);
	public static final PropertyEnum<EnumIO> SOUTH = PropertyEnum.create("south", EnumIO.class);
	public static final PropertyEnum<EnumIO> EAST = PropertyEnum.create("east", EnumIO.class);
	public static final PropertyEnum<EnumIO> WEST = PropertyEnum.create("west", EnumIO.class);

	public EnergyBlock()
	{
		super();
		this.setRegistryName("energy_block");
		this.setUnlocalizedName("energyBlock");
		this.setDefaultState(this.createBlockState().getBaseState().withProperty(FACING, EnumFacing.NORTH));
	}

	@Override
	public TileEntity createNewTileEntity(World worldIn, int meta)
	{
		return new EnergyBlockTileEntity();
	}

	@Override
	public IBlockState getStateFromMeta(int meta)
	{
		int a;
		a = meta % 3;
		EnumFacing facing = EnumFacing.getHorizontal(a);
		return this.getDefaultState().withProperty(FACING, facing);
	}

	@Override
	public int getMetaFromState(IBlockState state)
	{
		int facing = state.getValue(FACING).getIndex();
		return facing;
	}
	
	@Override
	public IBlockState getStateForPlacement(World world, BlockPos pos, EnumFacing facing, float hitX, float hitY,
			float hitZ, int meta, EntityLivingBase placer, ItemStack stack)
	{
		IBlockState origin = super.getStateForPlacement(world, pos, facing, hitX, hitY, hitZ, meta, placer, stack);
		return origin.withProperty(FACING, placer.getHorizontalFacing().getOpposite());
	}

	@Override
	protected BlockStateContainer createBlockState()
	{
//		return new ExtendedBlockState(this, new IProperty[] { FACING, NORTH, SOUTH, WEST, EAST, UP, DOWN },
//				new IUnlistedProperty[] {});
		return new BlockStateContainer(this, FACING, NORTH, SOUTH, WEST, EAST, UP, DOWN);
	}

//	@Override
//	public IBlockState getExtendedState(IBlockState state, IBlockAccess world, BlockPos pos)
//	{
//		TileEntity te = world.getTileEntity(pos);
//		//IExtendedBlockState s = (IExtendedBlockState) state;
//		//state.withProperty(FACING, state.getValue(FACING));
//		if (te instanceof IEnergySide)
//		{
//			IEnergySide config = (IEnergySide) te;
//			System.out.println(Booleans.asList(config.getAllEnergySide()).toString());
//			for(EnumFacing side:EnumFacing.VALUES)
//				state.withProperty(this.getProperty(side), config.canReceive(side) ? EnumIO.INPUT : EnumIO.OUTPUT);
//		}
//		return super.getExtendedState(state, world, pos);
//	}
	
	@Override
	public IBlockState getActualState(IBlockState state, IBlockAccess worldIn, BlockPos pos)
	{
		TileEntity te = worldIn.getTileEntity(pos);
		if (te instanceof IEnergySide)
		{
			IEnergySide config = (IEnergySide) te;
			//System.out.println(Booleans.asList(config.getAllEnergySide()).toString());
			for(EnumFacing side:EnumFacing.VALUES)
				state.withProperty(this.getProperty(side), config.canReceive(side) ? EnumIO.INPUT : EnumIO.OUTPUT);
		}
		return state;
	}

	public PropertyEnum<EnumIO> getProperty(EnumFacing from)
	{
		switch (from)
		{
		case UP:
			return this.UP;
		case DOWN:
			return this.DOWN;
		case NORTH:
			return this.NORTH;
		case SOUTH:
			return this.SOUTH;
		case WEST:
			return this.WEST;
		case EAST:
			return this.EAST;
		default:
			return null;
		}

	}

}

 

blockstate json(here)

Spoiler 

{
    "forge_marker": 1,
    "defaults": {
        "model": "cube",
        "textures": {
            "down": "someusefulthings:blocks/remove_enchantment_side",
            "up": "someusefulthings:blocks/remove_enchantment_side",
            "north": "someusefulthings:blocks/eye_generator_on",
            "south": "someusefulthings:blocks/remove_enchantment_side",
            "west": "someusefulthings:blocks/remove_enchantment_side",
            "east": "someusefulthings:blocks/remove_enchantment_side"
        }
    },
    "variants": {
        "inventory": [{
             "textures": { "down": "someusefulthings:blocks/remove_enchantment_side",
            "up": "someusefulthings:blocks/remove_enchantment_side",
            "north": "someusefulthings:blocks/eye_generator_on",
            "south": "someusefulthings:blocks/remove_enchantment_side",
            "west": "someusefulthings:blocks/remove_enchantment_side",
            "east": "someusefulthings:blocks/remove_enchantment_side" }
        }],
        "facing": {
            "east": { "y": 90, "uvlock": true },
            "north": {},
            "south": { "y": 180, "uvlock": true },
            "west": { "y": 270, "uvlock": true },
            "down": {},
            "up": {}
        },
        "up":{
        "input": { "textures": { "up": "someusefulthings:blocks/copy_enchantment_on" } },
        "output": { "textures": { "up": "someusefulthings:blocks/copy_enchantment_off" } },
        "all": { },
        "not": { }
        },
        "down":{
        "input": { "textures": { "down": "someusefulthings:blocks/copy_enchantment_on" } },
        "output": { "textures": { "down": "someusefulthings:blocks/copy_enchantment_off" } },
        "all": { },
        "not": { }
        },
        "north":{
        "input": { "textures": { "north": "someusefulthings:blocks/copy_enchantment_on" } },
        "output": { "textures": { "north": "someusefulthings:blocks/copy_enchantment_off" } },
        "all": { },
        "not": { }
        },
        "south":{
        "input": { "textures": { "south": "someusefulthings:blocks/copy_enchantment_on" } },
        "output": { "textures": { "south": "someusefulthings:blocks/copy_enchantment_off" } },
        "all": { },
        "not": { }
        },
        "west":{
        "input": { "textures": { "west": "someusefulthings:blocks/copy_enchantment_on" } },
        "output": { "textures": { "west": "someusefulthings:blocks/copy_enchantment_off" } },
        "all": { },
        "not": { }
        },
        "east":{
        "input": { "textures": { "east": "someusefulthings:blocks/copy_enchantment_on" } },
        "output": { "textures": { "east": "someusefulthings:blocks/copy_enchantment_off" } },
        "all": { },
        "not": { }
        }
    }
}

 

 

error_render.png

Edited by bxzsj
solved
Draco18s Reality Controller

Draco18s

Posted
Posted

You should always check the log.

And then scroll down the log some more until you see something helpful.

If you still don't, then post here, and include the log.

 

Apparently I'm a complete and utter jerk and come to this forum just like to make fun of people, be confrontational, and make your personal life miserable.  If you think this is the case, JUST REPORT ME.  Otherwise you're just going to get reported when you reply to my posts and point it out, because odds are, I was trying to be nice.

 

Exception: If you do not understand Java, I WILL NOT HELP YOU and your thread will get locked.

 

DO NOT PM ME WITH PROBLEMS. No help will be given.

bxzsj Tree Puncher

bxzsj

Posted
  • Author
Posted

the full log is here, nothing about "energy_block"

20 minutes ago, bxzsj said:

No error show in log(here).(block registry name is "energy_block")

 

Draco18s Reality Controller

Draco18s

Posted
Posted

Sorry, I missed that. It was a little buried.

Nothing in the log...
https://github.com/bxz2311196368/someusefulthings/blob/1.10.2/src/main/java/com/bxzmod/someusefulthings/blocks/BlockRenderLoader.java#L18

Why are you registering state mappers at all? You're using the default state mapper, you shouldn't need to do this.

 

Apparently I'm a complete and utter jerk and come to this forum just like to make fun of people, be confrontational, and make your personal life miserable.  If you think this is the case, JUST REPORT ME.  Otherwise you're just going to get reported when you reply to my posts and point it out, because odds are, I was trying to be nice.

 

Exception: If you do not understand Java, I WILL NOT HELP YOU and your thread will get locked.

 

DO NOT PM ME WITH PROBLEMS. No help will be given.

bxzsj Tree Puncher

bxzsj

Posted
  • Author
Posted
15 minutes ago, Draco18s said:

Sorry, I missed that. It was a little buried.

Nothing in the log...
https://github.com/bxz2311196368/someusefulthings/blob/1.10.2/src/main/java/com/bxzmod/someusefulthings/blocks/BlockRenderLoader.java#L18

Why are you registering state mappers at all? You're using the default state mapper, you shouldn't need to do this.

 

Sorry, I don't know what is a right way to register block state mapper,can you give me some document or tutorials about it?

This is the only way I learned from a tutorial. I still haven't figured out how this part works.

Draco18s Reality Controller

Draco18s

Posted
Posted (edited)
8 minutes ago, bxzsj said:

Sorry, I don't know what is a right way to register block state mapper,can you give me some document or tutorials about it?

This is the only way I learned from a tutorial. I still haven't figured out how this part works.

Its not about the proper way to register a block state mapper, my point is YOU DO NOT NEED TO DO THIS AT ALL EVER unless you are doing something like "I want to split my blockstate file into two files based on X property."1

 

How did I register my blocks in 1.10?

Like this:

https://github.com/Draco18s/ReasonableRealism/blob/master/src/main/java/com/draco18s/hardlib/client/ClientEasyRegistry.java#L33-L42

https://github.com/Draco18s/ReasonableRealism/blob/master/src/main/java/com/draco18s/hardlib/client/ClientEasyRegistry.java#L80-L83

Do you see anything about a custom block state mapper?

 

1 This being a thing I actually did.

Edited by Draco18s

Apparently I'm a complete and utter jerk and come to this forum just like to make fun of people, be confrontational, and make your personal life miserable.  If you think this is the case, JUST REPORT ME.  Otherwise you're just going to get reported when you reply to my posts and point it out, because odds are, I was trying to be nice.

 

Exception: If you do not understand Java, I WILL NOT HELP YOU and your thread will get locked.

 

DO NOT PM ME WITH PROBLEMS. No help will be given.

bxzsj Tree Puncher

bxzsj

Posted
  • Author
Posted

I understand, if I don't need to load blockstate json from separated files, it's no need to register block state mapper.

Now I removed register block state mapper, but it still don't work.

new log

error_render.png

Animefan8888 Reality Controller

Animefan8888

Posted
Posted
13 hours ago, bxzsj said:

I understand, if I don't need to load blockstate json from separated files, it's no need to register block state mapper.

Now I removed register block state mapper, but it still don't work.

new log

3

You do not have any models/block folder and therefore none of your blocks will have a texture.

VANILLA MINECRAFT CLASSES ARE THE BEST RESOURCES WHEN MODDING

I will be posting 1.15.2 modding tutorials on this channel. If you want to be notified of it do the normal YouTube stuff like subscribing, ect.

Forge and vanilla BlockState generator.

bxzsj Tree Puncher

bxzsj

Posted
  • Author
Posted
5 hours ago, Animefan8888 said:

You do not have any models/block folder and therefore none of your blocks will have a texture.

what you mean, I'm using vanilla "cube" model

Animefan8888 Reality Controller

Animefan8888

Posted
Posted
On 6/5/2018 at 2:40 AM, bxzsj said:

what you mean, I'm using vanilla "cube" model

Never mind I did not look into your blockstate json. Have you tried anything else since then?

VANILLA MINECRAFT CLASSES ARE THE BEST RESOURCES WHEN MODDING

I will be posting 1.15.2 modding tutorials on this channel. If you want to be notified of it do the normal YouTube stuff like subscribing, ect.

Forge and vanilla BlockState generator.

bxzsj Tree Puncher

bxzsj

Posted
  • Author
Posted

I made a stupid mistake. 

this.setDefaultState(this.createBlockState().getBaseState().withProperty(FACING, EnumFacing.NORTH));


That makes the state in game never equal state in  

BlockModelShapes.blockStateMapper


Sorry to waste your time.

Join the conversation

You can post now and register later. If you have an account, sign in now to post with your account.
Note: Your post will require moderator approval before it will be visible.

Guest
Unfortunately, your content contains terms that we do not allow. Please edit your content to remove the highlighted words below.
Reply to this topic...

×   Pasted as rich text.   Restore formatting

  Only 75 emoji are allowed.

×   Your link has been automatically embedded.   Display as a link instead

×   Your previous content has been restored.   Clear editor

×   You cannot paste images directly. Upload or insert images from URL.

×
 Share
Go to topic listing

Announcements



  • Recently Browsing

    • No registered users viewing this page.

  • Posts

    • TEMICCLOL
      TEMICCLOL

      By TEMICCLOL · Posted

      круто
    • BananaRebel
      Dependency Issues with Custom Portal API [Forge]

      By BananaRebel · Posted

      Hi,  I'm using Forge 47.3.0 for Minecraft 1.20.1 I apologise if this is obvious I am very new to modding for Minecraft. I sucessfully made a mod that launched without errors or crashes (without it doing anything) but in order to add the features I need, I need to add "Custom Portal API [Forge]" as a dependency. However no matter the way I've tried to acheive this, it crashes. I am pretty sure it's not the way I'm putting it in the repositories, the dependencies or the way I'm refrencing it, as I've a hundred diffrent combinations and multiple Maven methods. And on all those diffrent variations I still get this crash: pastebin.com/UhumzZCZ Any tips would be invaluable as I've been loosing my mind over this!
    • xLorkin
      Forge 54.1.1 Missing Textures please help

      By xLorkin · Posted

      Hi, i'm really having problems trying to set the texture to my custom item. I thought i'm doing everything correctly, but all i see is the missing texture block for my item. I am trying this for over a week now and getting really frustrated. The only time i could make the texture work, was when i used an older Forge version (52.0.1) for Minecraft (1.21.4). Was there a fundamental change for textures and models somewhere between versions that i'm missing? I started with Forge 54.1.0 and had this problem, so in my frustration i tried many things: Upgrading to Forge 54.1.1, created multiple new projects, workspaces, redownloaded everything and setting things up multiple times, as it was suggested in an older thread. Therea are no errors in the console logs, but maybe i'm blind, so i pasted the console logs to pastebin anyway: https://pastebin.com/zAM8RiUN The only time i see an error is when i change the models JSON file to an incorrect JSON which makes sense and that suggests to me it is actually reading the JSON file.   I set the github repository to public, i would be so thankful if anyone could take a look and tell me what i did wrong: https://github.com/xLorkin/teleport_pug_forge   As a note: i'm pretty new to modding, this is my first mod ever. But i'm used to programming. I had some up and downs, but through reading the documentation, using google and experimenting, i could solve all other problems. I only started modding for Minecraft because my son is such a big fan and wanted this mod.
    • Ugdhar
      My CodeChickenLib mod is giving me an error message and i just can't solve it!

      By Ugdhar · Posted

      Please read the FAQ (link in orange bar at top of page), and post logs as described there.
    • MinecraftSearch
      New Website for Quick & Easy Minecraft Info

      By MinecraftSearch · Posted

      Hello fellow Minecrafters! I recently returned to Minecraft and realized I needed a wiki that displays basic information easily and had great user navigation. That’s why I decided to build: MinecraftSearch — a site by a Minecraft fan, for Minecraft fans. Key Features So Far Straight-to-the-Point Info: No extra fluff; just the essentials on items, mobs, recipes, loot and more. Clean & Intuitive Layout: Easy navigation so you spend less time scrolling and more time playing. Optimized Search: Search for anything—items, mobs, blocks—and get results instantly. What I’m Thinking of Adding More data/information: Catch chances for fishing rod, traveling villager trades, biomes info and a lot more. The website is still under development and need a lot more data added. Community Contributions: Potential for user-uploaded tips for items/mobs/blocks in the future. Feature Requests Welcome: Your ideas could shape how the wiki evolves! You can see my roadmap at the About page https://minecraftsearch.com/about I’d love for you to check out MinecraftSearch and see if it helps you find the info you need faster. Feedback is crucial—I want to develop this further based on what the community needs most, so please let me know what you think. Thanks, and happy crafting!

  • Topics

  • Who's Online (See full list)

    • There are no registered users currently online
×
×
  • Create New...

Important Information

By using this site, you agree to our Terms of Use.

  I accept