[Solved].....Crash creating items

[TheMysticMinecart Myles]

so i started modding for 1.8 recreating a mod i made in 1.7.10, but after i made a third item the game would not load here's the crashed report it says something about the same item being registered twice crash-2018-06-26_09.55.26-client.txt

Edited June 26, 2018 by TheMysticMinecart Myles

[Draco18s]

...code?

Also, 1.8 is ancient. If you want to use 1.8, at least use 1.8.9

[TheMysticMinecart Myles]

24 minutes ago, Draco18s said:

...code?

Also, 1.8 is ancient. If you want to use 1.8, at least use 1.8.9

ture but i want to make my mods available for many version plus people use 1.7.10 and 1.10 allot still so my plan was to update my mods from 1.7 to 1.8 to 1.9 ect. 

code(do you only need the item code?):

package mysticmyles.Anime_Dekokurafuto.init;

import mysticmyles.Anime_Dekokurafuto.Reference;
import net.minecraft.client.Minecraft;
import net.minecraft.client.resources.model.ModelResourceLocation;
import net.minecraft.item.Item;
import net.minecraftforge.fml.common.registry.GameRegistry;

public class AnimeItems {
	
	public static Item uchiha_logo_item;
	public static Item yugioh_cardback_item;
	public static Item dragon_ball_logo0_item;
	
	public static void init() {
		uchiha_logo_item = new Item().setUnlocalizedName("uchiha_logo_item");
		yugioh_cardback_item = new Item().setUnlocalizedName("yugioh_cardback_item");
		dragon_ball_logo0_item = new Item().setUnlocalizedName("dragon_ball_logo0_item");
	}
	
	public static void register()
	{
		GameRegistry.registerItem(uchiha_logo_item, uchiha_logo_item.getUnlocalizedName().substring(5));
		GameRegistry.registerItem(yugioh_cardback_item, yugioh_cardback_item.getUnlocalizedName().substring(5));
		GameRegistry.registerItem(yugioh_cardback_item, dragon_ball_logo0_item.getUnlocalizedName().substring(5));
	}
	public static void registerRenders()
	{
		registerRender(uchiha_logo_item);
		registerRender(yugioh_cardback_item);
		registerRender(dragon_ball_logo0_item);
	}
	
	public static void registerRender(Item item)
	{
		Minecraft.getMinecraft().getRenderItem().getItemModelMesher().register(item, 0, new ModelResourceLocation(Reference.MOD_ID + ":" + item.getUnlocalizedName().substring(5), "inventory"));
	}
}

 

[Ugdhar]

6 minutes ago, TheMysticMinecart Myles said:

GameRegistry.registerItem(yugioh_cardback_item, yugioh_cardback_item.getUnlocalizedName().substring(5)); GameRegistry.registerItem(yugioh_cardback_item, dragon_ball_logo0_item.getUnlocalizedName().substring(5));

Looks like you're registering yugioh_cardback_item twice.

 

I'm guessing copy & paste are to blame.

[TheMysticMinecart Myles]

6 minutes ago, Ugdhar said:

Looks like you're registering yugioh_cardback_item twice.

 

I'm guessing copy & paste are to blame.

wait what 0.0,

omg i am so stupid XD wow that was a dumb mistake on my part.... well that's embarrassing 

i guess this is solved oops  

[TheMysticMinecart Myles]

9 minutes ago, Ugdhar said:

Looks like you're registering yugioh_cardback_item twice.

 

I'm guessing copy & paste are to blame.

thanks XD

[Draco18s]

Also, don't set the registry name to the unlocalized name. Set the unlocaled name to the registry name. Unlocalized names should be used for displaying the item's name only.

 

Problematic Code #7

[TheMysticMinecart Myles]

18 minutes ago, Draco18s said:

Also, don't set the registry name to the unlocalized name. Set the unlocaled name to the registry name. Unlocalized names should be used for displaying the item's name only.

 

Problematic Code #7

so do i just do it like it's done in (1.7.10 the unlocalized name) and how different is 1.8.9 to 1.8

[Draco18s]

item.setUnlocalizedName(item.getRegistryName().toString());

[TheMysticMinecart Myles]

On 6/26/2018 at 1:43 PM, Draco18s said:

item.setUnlocalizedName(item.getRegistryName().toString());

uchiha_logo_item = new Item().setUnlocalizedName(item.getRegistryName().toString());

do you mean like this?

[Draco18s]

item is a local variable. So no, your code there won't work.