Jump to content
Search the Forums BEFORE making a new post.
Currently supported: All versions

Two different versions of my item [1.12]

Severed_Infinity

By Severed_Infinity
in Modder Support

 Share

Recommended Posts

Severed_Infinity Tree Puncher

Severed_Infinity

Posted
Posted

Getting back into modding using the new guidelines. I've created a single item (so far), added it's texture, json, and registered. In game (in creative) opening inventory and adding my idea works no problem, the issue is with the /give command. When using the /give command I get a different untextured item that is not considered the same as the one from inventory.

Animefan8888 Reality Controller

Animefan8888

Posted
Posted
3 minutes ago, Severed_Infinity said:

Getting back into modding using the new guidelines. I've created a single item (so far), added it's texture, json, and registered. In game (in creative) opening inventory and adding my idea works no problem, the issue is with the /give command. When using the /give command I get a different untextured item that is not considered the same as the one from inventory.

It's hard to answer your question without seeing the code also post the text you used as the command.

VANILLA MINECRAFT CLASSES ARE THE BEST RESOURCES WHEN MODDING

I will be posting 1.15.2 modding tutorials on this channel. If you want to be notified of it do the normal YouTube stuff like subscribing, ect.

Forge and vanilla BlockState generator.

Animefan8888 Reality Controller

Animefan8888

Posted
Posted
4 minutes ago, Severed_Infinity said:

My apologies I was having trouble doing basic input to text field for some reason.

 

A gist to the list of class I believe are important to the issue.

I would like to see the command you entered and the ItemIngotCopper class.

VANILLA MINECRAFT CLASSES ARE THE BEST RESOURCES WHEN MODDING

I will be posting 1.15.2 modding tutorials on this channel. If you want to be notified of it do the normal YouTube stuff like subscribing, ect.

Forge and vanilla BlockState generator.

Animefan8888 Reality Controller

Animefan8888

Posted
Posted
2 minutes ago, Severed_Infinity said:

and the command "/give @p tn:ingot_copper 1 2"

I believe you are giving it with a metadata value, which in turn you did not register a model/texture to.

VANILLA MINECRAFT CLASSES ARE THE BEST RESOURCES WHEN MODDING

I will be posting 1.15.2 modding tutorials on this channel. If you want to be notified of it do the normal YouTube stuff like subscribing, ect.

Forge and vanilla BlockState generator.

Animefan8888 Reality Controller

Animefan8888

Posted
Posted
4 minutes ago, Severed_Infinity said:

Yeah, I am thinking that it is the case myself but I can't figure it out, changing the 2 to any other number or removing it still gives me a blank textured alternative version of my item. Very strange.

Could you put all of your code on github? And that is strange you should try looking through it with you're IDE's debugger.

VANILLA MINECRAFT CLASSES ARE THE BEST RESOURCES WHEN MODDING

I will be posting 1.15.2 modding tutorials on this channel. If you want to be notified of it do the normal YouTube stuff like subscribing, ect.

Forge and vanilla BlockState generator.

Draco18s Reality Controller

Draco18s

Posted
Posted

Also:

  • IHasModel is stupid. All items need models. ALL ITEMS.
  • ModelRegistryEvent is client side only. This will crash the dedicated server.
  • This can be done externally (i.e. not inside the class) just fine: Technium.proxy.registerItemRender(item, 0, "inventory");
  • If your item classes look like this, you don't need them at all.
  • The fuck? You used the IProxy interface (good) method and a common proxy (bad)?

Apparently I'm a complete and utter jerk and come to this forum just like to make fun of people, be confrontational, and make your personal life miserable.  If you think this is the case, JUST REPORT ME.  Otherwise you're just going to get reported when you reply to my posts and point it out, because odds are, I was trying to be nice.

 

Exception: If you do not understand Java, I WILL NOT HELP YOU and your thread will get locked.

 

DO NOT PM ME WITH PROBLEMS. No help will be given.

Severed_Infinity Tree Puncher

Severed_Infinity

Posted
  • Author
Posted
6 hours ago, Draco18s said:

Also:

  • IHasModel is stupid. All items need models. ALL ITEMS.
  • ModelRegistryEvent is client side only. This will crash the dedicated server.
  • This can be done externally (i.e. not inside the class) just fine: Technium.proxy.registerItemRender(item, 0, "inventory");
  • If your item classes look like this, you don't need them at all.
  • The fuck? You used the IProxy interface (good) method and a common proxy (bad)?

Based a lot of that off of the most recent mod tutorials I could find.

Severed_Infinity Tree Puncher

Severed_Infinity

Posted
  • Author
Posted
9 hours ago, diesieben07 said:

FMLLog is deprecated. Use your own log as described in the class' Javadoc. Also, don't spam the log like that. Nobody cares that your pre init completed. FML already logs this. If you want to log it, don't do it at info level.

this is more for me, which I can remove at a later date.

9 hours ago, diesieben07 said:

"tn" is a terrible mod id. Make it longer.

just going by what I've seen in the past, present, and documentation that I've found.

Draco18s Reality Controller

Draco18s

Posted
Posted (edited)
12 minutes ago, Severed_Infinity said:

Based a lot of that off of the most recent mod tutorials I could find

Just because it's a tutorial doesn't mean it's "right" or "best." In fact, most Minecraft modding tutorials are written by people who don't actually know what they're doing, but they managed to cobble something together that appears to work, so they did a video about it...as evidenced by comments like this one:

loremaster.png

10 minutes ago, Severed_Infinity said:

just going by what I've seen in the past, present, and documentation that I've found.

1) See prior comments

2) Mod IDs can be pretty long. Not super long, but certainly long enough for "technium" (it's eight characters, if that was too long we'd have run out of possible mod IDs already!) Edit: the limit is 64 characters.

3) What D7 said.

Edited by Draco18s

Apparently I'm a complete and utter jerk and come to this forum just like to make fun of people, be confrontational, and make your personal life miserable.  If you think this is the case, JUST REPORT ME.  Otherwise you're just going to get reported when you reply to my posts and point it out, because odds are, I was trying to be nice.

 

Exception: If you do not understand Java, I WILL NOT HELP YOU and your thread will get locked.

 

DO NOT PM ME WITH PROBLEMS. No help will be given.

Severed_Infinity Tree Puncher

Severed_Infinity

Posted
  • Author
Posted
10 hours ago, diesieben07 said:

I seriously hope there are no tutorials that tell people to use a two-letter mod ID. A mod ID is meant to be unique. "tn" is not very unique, it could be the abbreviation for tons of things.

 

10 hours ago, Draco18s said:

1) See prior comments

2) Mod IDs can be pretty long. Not super long, but certainly long enough for "technium" (it's eight characters, if that was too long we'd have run out of possible mod IDs already!) Edit: the limit is 64 characters.

3) What D7 said.

I did not know that, thanks for letting me know.
I've been watching lore's videos recently but i see what you mean

Severed_Infinity Tree Puncher

Severed_Infinity

Posted
  • Author
Posted

UPDATE: after making some of the suggested changes you guys mention I found when loading up I got an error screen to say my item could not be found (due to obvious reasons like changing modid) but I found that my item was listed as "minecraft:item:tn:ingot_copper" instead of "tn:ingot_copper" (or rather should be now "technium:ingot_copper").

Draco18s Reality Controller

Draco18s

Posted
Posted
5 hours ago, Severed_Infinity said:

I've been watching lore's videos recently but i see what you mean

Mhm. I gathered.

Apparently I'm a complete and utter jerk and come to this forum just like to make fun of people, be confrontational, and make your personal life miserable.  If you think this is the case, JUST REPORT ME.  Otherwise you're just going to get reported when you reply to my posts and point it out, because odds are, I was trying to be nice.

 

Exception: If you do not understand Java, I WILL NOT HELP YOU and your thread will get locked.

 

DO NOT PM ME WITH PROBLEMS. No help will be given.

Severed_Infinity Tree Puncher

Severed_Infinity

Posted
  • Author
Posted
5 hours ago, diesieben07 said:

Please update your Git repository.

I've done so, was out for most of the day only got around to it now. the duplicate item issue is gone now but now the texture doesn't render.

I took your advice and I believe I rewrote most the code in a better way but again I could be entirely wrong.

Join the conversation

You can post now and register later. If you have an account, sign in now to post with your account.
Note: Your post will require moderator approval before it will be visible.

Guest
Unfortunately, your content contains terms that we do not allow. Please edit your content to remove the highlighted words below.
Reply to this topic...

×   Pasted as rich text.   Restore formatting

  Only 75 emoji are allowed.

×   Your link has been automatically embedded.   Display as a link instead

×   Your previous content has been restored.   Clear editor

×   You cannot paste images directly. Upload or insert images from URL.

×
 Share
Go to topic listing

Announcements



  • Recently Browsing

    • No registered users viewing this page.

  • Posts

    • TEMICCLOL
      TEMICCLOL

      By TEMICCLOL · Posted

      круто
    • BananaRebel
      Dependency Issues with Custom Portal API [Forge]

      By BananaRebel · Posted

      Hi,  I'm using Forge 47.3.0 for Minecraft 1.20.1 I apologise if this is obvious I am very new to modding for Minecraft. I sucessfully made a mod that launched without errors or crashes (without it doing anything) but in order to add the features I need, I need to add "Custom Portal API [Forge]" as a dependency. However no matter the way I've tried to acheive this, it crashes. I am pretty sure it's not the way I'm putting it in the repositories, the dependencies or the way I'm refrencing it, as I've a hundred diffrent combinations and multiple Maven methods. And on all those diffrent variations I still get this crash: pastebin.com/UhumzZCZ Any tips would be invaluable as I've been loosing my mind over this!
    • xLorkin
      Forge 54.1.1 Missing Textures please help

      By xLorkin · Posted

      Hi, i'm really having problems trying to set the texture to my custom item. I thought i'm doing everything correctly, but all i see is the missing texture block for my item. I am trying this for over a week now and getting really frustrated. The only time i could make the texture work, was when i used an older Forge version (52.0.1) for Minecraft (1.21.4). Was there a fundamental change for textures and models somewhere between versions that i'm missing? I started with Forge 54.1.0 and had this problem, so in my frustration i tried many things: Upgrading to Forge 54.1.1, created multiple new projects, workspaces, redownloaded everything and setting things up multiple times, as it was suggested in an older thread. Therea are no errors in the console logs, but maybe i'm blind, so i pasted the console logs to pastebin anyway: https://pastebin.com/zAM8RiUN The only time i see an error is when i change the models JSON file to an incorrect JSON which makes sense and that suggests to me it is actually reading the JSON file.   I set the github repository to public, i would be so thankful if anyone could take a look and tell me what i did wrong: https://github.com/xLorkin/teleport_pug_forge   As a note: i'm pretty new to modding, this is my first mod ever. But i'm used to programming. I had some up and downs, but through reading the documentation, using google and experimenting, i could solve all other problems. I only started modding for Minecraft because my son is such a big fan and wanted this mod.
    • Ugdhar
      My CodeChickenLib mod is giving me an error message and i just can't solve it!

      By Ugdhar · Posted

      Please read the FAQ (link in orange bar at top of page), and post logs as described there.
    • MinecraftSearch
      New Website for Quick & Easy Minecraft Info

      By MinecraftSearch · Posted

      Hello fellow Minecrafters! I recently returned to Minecraft and realized I needed a wiki that displays basic information easily and had great user navigation. That’s why I decided to build: MinecraftSearch — a site by a Minecraft fan, for Minecraft fans. Key Features So Far Straight-to-the-Point Info: No extra fluff; just the essentials on items, mobs, recipes, loot and more. Clean & Intuitive Layout: Easy navigation so you spend less time scrolling and more time playing. Optimized Search: Search for anything—items, mobs, blocks—and get results instantly. What I’m Thinking of Adding More data/information: Catch chances for fishing rod, traveling villager trades, biomes info and a lot more. The website is still under development and need a lot more data added. Community Contributions: Potential for user-uploaded tips for items/mobs/blocks in the future. Feature Requests Welcome: Your ideas could shape how the wiki evolves! You can see my roadmap at the About page https://minecraftsearch.com/about I’d love for you to check out MinecraftSearch and see if it helps you find the info you need faster. Feedback is crucial—I want to develop this further based on what the community needs most, so please let me know what you think. Thanks, and happy crafting!

  • Topics

×
×
  • Create New...

Important Information

By using this site, you agree to our Terms of Use.

  I accept