Trying to make a musket but wont shoot [1.12.2]

[JDtheman19]

Been trying to make the gun shoot but im not sure what im doing wrong and im not sure if i did the sound right

https://pastebin.com/6nayD6aK

[JDtheman19]

3 minutes ago, diesieben07 said:

Entity classes cannot be inner classes, because their constructors will have an implicit argument generated for the outer class instance. This prevents the client and the world-loading code from instantiating the entity class.

Alright I put EntityBullet into its own class but it still won't fire

[JDtheman19]

11 minutes ago, diesieben07 said:

Use the debugger. Is your entity spawned? Is it spawned on the client?

no nothing, My idea was that you hold down right click it won't charge but it will move the item in your hand like a bow does but when you let go anytime an entity bullet that I made shoots out and goes far but not so quick to shoot the next shot. I've been looking everywhere for anything like it and I found nothing

Edited July 6, 2018 by JDtheman19

[JDtheman19]

8 minutes ago, diesieben07 said:

So did you actually use the debugger? Please provide your findings.

nothing shows up

 

[JDtheman19]

3 minutes ago, diesieben07 said:

What does this even mean? Please clarify what you have done exactly.

[15:59:25] [pool-2-thread-1/WARN] [mojang/YggdrasilMinecraftSessionService]: Couldn't look up profile properties for com.mojang.authlib.GameProfile@69fa0cd4[id=fd09468e-08e7-31aa-bab7-195a6ef31320,name=Player434,properties={},legacy=false]
com.mojang.authlib.exceptions.AuthenticationException: The client has sent too many requests within a certain amount of time
    at com.mojang.authlib.yggdrasil.YggdrasilAuthenticationService.makeRequest(YggdrasilAuthenticationService.java:79) ~[YggdrasilAuthenticationService.class:?]
    at com.mojang.authlib.yggdrasil.YggdrasilMinecraftSessionService.fillGameProfile(YggdrasilMinecraftSessionService.java:180) [YggdrasilMinecraftSessionService.class:?]
    at com.mojang.authlib.yggdrasil.YggdrasilMinecraftSessionService$1.load(YggdrasilMinecraftSessionService.java:60) [YggdrasilMinecraftSessionService$1.class:?]
    at com.mojang.authlib.yggdrasil.YggdrasilMinecraftSessionService$1.load(YggdrasilMinecraftSessionService.java:57) [YggdrasilMinecraftSessionService$1.class:?]
    at com.google.common.cache.LocalCache$LoadingValueReference.loadFuture(LocalCache.java:3716) [guava-21.0.jar:?]
    at com.google.common.cache.LocalCache$Segment.loadSync(LocalCache.java:2424) [guava-21.0.jar:?]
    at com.google.common.cache.LocalCache$Segment.lockedGetOrLoad(LocalCache.java:2298) [guava-21.0.jar:?]
    at com.google.common.cache.LocalCache$Segment.get(LocalCache.java:2211) [guava-21.0.jar:?]
    at com.google.common.cache.LocalCache.get(LocalCache.java:4154) [guava-21.0.jar:?]
    at com.google.common.cache.LocalCache.getOrLoad(LocalCache.java:4158) [guava-21.0.jar:?]
    at com.google.common.cache.LocalCache$LocalLoadingCache.get(LocalCache.java:5147) [guava-21.0.jar:?]
    at com.google.common.cache.LocalCache$LocalLoadingCache.getUnchecked(LocalCache.java:5153) [guava-21.0.jar:?]
    at com.mojang.authlib.yggdrasil.YggdrasilMinecraftSessionService.fillProfileProperties(YggdrasilMinecraftSessionService.java:170) [YggdrasilMinecraftSessionService.class:?]
    at net.minecraft.client.Minecraft.getProfileProperties(Minecraft.java:3179) [Minecraft.class:?]
    at net.minecraft.client.resources.SkinManager$3.run(SkinManager.java:138) [SkinManager$3.class:?]
    at java.util.concurrent.Executors$RunnableAdapter.call(Executors.java:511) [?:1.8.0_171]
    at java.util.concurrent.FutureTask.run(FutureTask.java:266) [?:1.8.0_171]
    at java.util.concurrent.ThreadPoolExecutor.runWorker(ThreadPoolExecutor.java:1149) [?:1.8.0_171]
    at java.util.concurrent.ThreadPoolExecutor$Worker.run(ThreadPoolExecutor.java:624) [?:1.8.0_171]
    at java.lang.Thread.run(Thread.java:748) [?:1.8.0_171]

 

thats is all that shows up but its not when i use the item

[JDtheman19]

7 minutes ago, diesieben07 said:

What part of "use the debugger" did you not understand?

I am using the debug and nothing is happening

[JDtheman19]

23 minutes ago, diesieben07 said:

Did you set breakpoints? You know how to use the debugger, right? If not: Look it up.

I set breakpoints and still nothing all I wanted was some help making the gun shoot ok? im new to this and I don't understand a lot of things and i looked it up and still nothing

[Cadiboo]

2 minutes ago, JDtheman19 said:

I set breakpoints and still nothing all I wanted was some help making the gun shoot ok? im new to this and I don't understand a lot of things and i looked it up and still nothing

If u set up breakpoints and nothing happened... then none of your code is getting called

[Cadiboo]

Just now, Cadiboo said:

If u set up breakpoints and nothing happened... then none of your code is getting called

Are you 100% sure you were using the debugger? What IDE are you using?

[JDtheman19]

Just now, Cadiboo said:

Are you 100% sure you were using the debugger? What IDE are you using?

Eclipse and yes im sure

[DaemonUmbra]

How did you start the debugging process, how did you launch minecraft?

[JDtheman19]

1 minute ago, DaemonUmbra said:

How did you start the debugging process, how did you launch minecraft?

by pressing debug and selecting the client

[Cadiboo]

1 minute ago, JDtheman19 said:

by pressing debug and selecting the client

Try setting a breakpoint at some code that you know 100% will be called (a registry event maybe) does the debugger  pause the program?

[JDtheman19]

3 minutes ago, Cadiboo said:

Try setting a breakpoint at some code that you know 100% will be called (a registry event maybe) does the debugger  pause the program?

I did and still nothing! im not joking here like seriously nothing and yes it suspends the game and i can press the play and it plays 

[JDtheman19]

Like I said y idea was that you hold down right click it won't charge but it will move the item in your hand like a bow does but when you let go anytime an entity bullet that I made shoots out and goes far but not so quick to shoot the next shot

[DaemonUmbra]

It suspends?

Are you saying this happens in your code or JUST the registry event?

Ignore me

Edited July 7, 2018 by DaemonUmbra

[Animefan8888]

7 minutes ago, JDtheman19 said:

Like I said y idea was that you hold down right click it won't charge but it will move the item in your hand like a bow does but when you let go anytime an entity bullet that I made shoots out and goes far but not so quick to shoot the next shot

What happens and what do you want to happen exactly? Is the bullet entity spawning at all, is it spawning repeatedly?

[JDtheman19]

1 minute ago, Animefan8888 said:

What happens and what do you want to happen exactly? Is the bullet entity spawning at all, is it spawning repeatedly?

when I right click with the item it kinda uses the item like it goes down the back up like your placing a block. what I want to happen is when you hold down right click you have the bow kinda animation and whenever you release right-click it shoots but doesn't change the distance the bullet goes like the distance

[Animefan8888]

Just now, JDtheman19 said:

when I right click with the item it kinda uses the item like it goes down the back up like your placing a block. what I want to happen is when you hold down right click you have the bow kinda animation and whenever you release right-click it shoots but doesn't change the distance the bullet goes like the distance

look at ItemBow, it uses onPlayerStoppedUsing to spawn and fire the arrow, this is the code that happens after releasing right click, but it doesn't care if you have held it down for the full amount of time. onItemUseFinish waits until the whole time has completed. And it has some code in onItemRightClick to see if it can be fired and setting the active hand.

[Cadiboo]

2 minutes ago, Animefan8888 said:

look at ItemBow, it uses onPlayerStoppedUsing to spawn and fire the arrow, this is the code that happens after releasing right click, but it doesn't care if you have held it down for the full amount of time. onItemUseFinish waits until the whole time has completed. And it has some code in onItemRightClick to see if it can be fired and setting the active hand.

Also look at maxUseDuration or whatever it’s called.

 

copying the entire ItemBow class and modifying it to shoot your projectile would be a good way to get familiar with the methods

[JDtheman19]

5 minutes ago, Animefan8888 said:

look at ItemBow, it uses onPlayerStoppedUsing to spawn and fire the arrow, this is the code that happens after releasing right click, but it doesn't care if you have held it down for the full amount of time. onItemUseFinish waits until the whole time has completed. And it has some code in onItemRightClick to see if it can be fired and setting the active hand.

 

 

6 minutes ago, Cadiboo said:

Also look at maxUseDuration or whatever it’s called.

 

copying the entire ItemBow class and modifying it to shoot your projectile would be a good way to get familiar with the methods

thank you thats all i was asking 

[JDtheman19]

I updated the paste bin how would I make it shoot the bullet entity I made its just a ball but how would I make it so the velocity never changes  https://pastebin.com/6nayD6aK

[Animefan8888]

12 minutes ago, JDtheman19 said:

how would I make it shoot the bullet entity I made its just a ball

You need to create and register a renderer for your Entities class.

13 minutes ago, JDtheman19 said:

how would I make it so the velocity never change

Look at EntityArrow#onUpdate it is where the motionX/Y/Z variables are modified.

[JDtheman19]

java.util.concurrent.ExecutionException: java.lang.ClassCastException: JDtheman19.jdsweirdbutusefulmod.item.ItemBase cannot be cast to net.minecraft.item.ItemArrow
    at java.util.concurrent.FutureTask.report(FutureTask.java:122) ~[?:1.8.0_171]
    at java.util.concurrent.FutureTask.get(FutureTask.java:192) ~[?:1.8.0_171]
    at net.minecraft.util.Util.runTask(Util.java:54) [Util.class:?]
    at net.minecraft.server.MinecraftServer.updateTimeLightAndEntities(MinecraftServer.java:798) [MinecraftServer.class:?]
    at net.minecraft.server.MinecraftServer.tick(MinecraftServer.java:743) [MinecraftServer.class:?]
    at net.minecraft.server.integrated.IntegratedServer.tick(IntegratedServer.java:192) [IntegratedServer.class:?]
    at net.minecraft.server.MinecraftServer.run(MinecraftServer.java:592) [MinecraftServer.class:?]
    at java.lang.Thread.run(Thread.java:748) [?:1.8.0_171]
Caused by: java.lang.ClassCastException: JDtheman19.jdsweirdbutusefulmod.item.ItemBase cannot be cast to net.minecraft.item.ItemArrow
    at JDtheman19.jdsweirdbutusefulmod.item.tools.ToolWeapons.onPlayerStoppedUsing(ToolWeapons.java:119) ~[ToolWeapons.class:?]
    at net.minecraft.item.ItemStack.onPlayerStoppedUsing(ItemStack.java:628) ~[ItemStack.class:?]
    at net.minecraft.entity.EntityLivingBase.stopActiveHand(EntityLivingBase.java:3092) ~[EntityLivingBase.class:?]
    at net.minecraft.network.NetHandlerPlayServer.processPlayerDigging(NetHandlerPlayServer.java:692) ~[NetHandlerPlayServer.class:?]
    at net.minecraft.network.play.client.CPacketPlayerDigging.processPacket(CPacketPlayerDigging.java:56) ~[CPacketPlayerDigging.class:?]
    at net.minecraft.network.play.client.CPacketPlayerDigging.processPacket(CPacketPlayerDigging.java:12) ~[CPacketPlayerDigging.class:?]
    at net.minecraft.network.PacketThreadUtil$1.run(PacketThreadUtil.java:21) ~[PacketThreadUtil$1.class:?]
    at java.util.concurrent.Executors$RunnableAdapter.call(Executors.java:511) ~[?:1.8.0_171]
    at java.util.concurrent.FutureTask.run(FutureTask.java:266) ~[?:1.8.0_171]
    at net.minecraft.util.Util.runTask(Util.java:53) ~[Util.class:?]
    ... 5 more

 

 

ill update my entitybullet and toolweapon in the pastepin

https://pastebin.com/6nayD6aK

[Cadiboo]

51 minutes ago, Animefan8888 said:

You need to create and register a renderer for your Entities class.

Look at EntityArrow#onUpdate it is where the motionX/Y/Z variables are modified.

In your custom entity class (your custom entity class will probably end up extending entityArrow due to some interesting bugs that happen if you don’t extend it) you can call onEntityUpdate() in your onUpdate method, instead of having to call super.onUpdate()

 

These two examples of code might help you

https://github.com/Cadiboo/WIPTech/blob/master/src/main/java/cadiboo/wiptech/entity/projectile/EntityParamagneticProjectile113.java

 

https://github.com/Cadiboo/WIPTech/blob/master/src/main/java/cadiboo/wiptech/entity/projectile/EntityParamagneticProjectile.java