Jump to content

Changing the exhaustion level gained from doing actions


Alekseyev

Recommended Posts

Hey all, I have a question once again:

 

How would I go about doing the following: I want to have players with a certain variable set only use up food half as quickly. Now the setting, storing, retrieving of said variable via the capability system is not an issue, my problem lies with the food mechanics. (As found in FoodStats.java)

 

There is no method to get the exhaustion level from outside, and also no check preventing the addExhaustion method from reducing the exhaustion value to negative values.

 

What I'm looking for is either: a) a way to intercept the calling of "addExhaustion" from outside, halving its value if other conditions are met, or b) some enlightenment on how you'd implement a system of reduced food consumption (while also keeping the original consumption system in place for when the conditions aren't met)

 

Regards!

Link to comment
Share on other sites

27 minutes ago, Alekseyev said:

Thanks for the answer. However... how exactly would I go about doing that? (Taking in the original instance/overwriting it)

Create a new class that extends FoodStats and have the constructor take an instance of FoodStats from EntityPlayer in the event Diesieben mentioned.

VANILLA MINECRAFT CLASSES ARE THE BEST RESOURCES WHEN MODDING

I will be posting 1.15.2 modding tutorials on this channel. If you want to be notified of it do the normal YouTube stuff like subscribing, ect.

Forge and vanilla BlockState generator.

Link to comment
Share on other sites

Sorry for being so obtuse.

 

Currently I have this code:

	@SubscribeEvent
	public void entityJoinWorld(EntityJoinWorldEvent event)
	{
		if (event.getEntity() instanceof EntityPlayer)
		{
			CustomFoodStats newFoodStats = new CustomFoodStats((EntityPlayer)event.getEntity());
		}
	}

And then the CustomFoodStats class:
 

public class CustomFoodStats extends FoodStats
{
	boolean isIce;
	FoodStats oldStats;

	public CustomFoodStats(EntityPlayer player)
	{
		super();
		if (getHandler(player).getElement() == BioElements.ICE)
		{
			isIce = true;
		}
		oldStats = player.getFoodStats();
	}

	@Override
	public void addExhaustion(float exhaustion) {
		if (isIce)
		{
			super.addExhaustion(exhaustion*20); // For testing purposes, will be /2 later
		}
		else
		{
			super.addExhaustion(exhaustion);
		}
	}
}



But... how to actually replace the old FoodStats with the custom, new one?

Link to comment
Share on other sites

Thanks to you both for your answers. I think I'm making progress: I used reflection to replace the variable:

	@SubscribeEvent
	public void entityJoinWorld(EntityJoinWorldEvent event)
	{
		if (event.getEntity() instanceof EntityPlayer)
		{
			System.out.println("entityJoinWorld: Entity is EntityPlayer");
			EntityPlayer evPlayer = (EntityPlayer)event.getEntity();
			FoodStats oldFoodStats = evPlayer.getFoodStats();
			CustomFoodStats newFoodStats = new CustomFoodStats(oldFoodStats, getHandler(evPlayer).getElement() == BioElements.ICE);

			System.out.println("Starting Reflection");
			ReflectionHelper.setPrivateValue(EntityPlayer.class, evPlayer, newFoodStats, 15);
		}
	}

and changed the CustomFoodClass as follows:

Spoiler

public class CustomFoodStats extends FoodStats
{
	boolean isIce;
	FoodStats oldStats;

	public CustomFoodStats(FoodStats oldStats, boolean isIce)
	{
		this.isIce = isIce;
		this.oldStats = oldStats;
	}

	@Override
	public void addStats(int foodLevelIn, float foodSaturationModifier)
	{
		oldStats.addStats(foodLevelIn, foodSaturationModifier);
	}

	@Override
	public void addStats(ItemFood foodItem, ItemStack stack)
	{
		oldStats.addStats(foodItem, stack);
	}

	@Override
	public void onUpdate(EntityPlayer player)
	{
		oldStats.onUpdate(player);
	}

	@Override
	public void readNBT(NBTTagCompound compound)
	{
		oldStats.readNBT(compound);
	}

	@Override
	public void writeNBT(NBTTagCompound compound)
	{
		oldStats.writeNBT(compound);
	}

	@Override
	public int getFoodLevel()
	{
		return oldStats.getFoodLevel();
	}

	@Override
	public boolean needFood()
	{
		return oldStats.needFood();
	}

	@Override
	public void addExhaustion(float exhaustion)
	{
		System.out.println("CustomFoodStats addExhaustion is called");
		if (isIce)
		{
			oldStats.addExhaustion(exhaustion*20); // For testing purposes, will be /2 later
		}
		else
		{
			oldStats.addExhaustion(exhaustion);
		}
	}

	@Override
	public float getSaturationLevel()
	{
		return oldStats.getSaturationLevel();
	}

	@Override
	public void setFoodLevel(int foodLevelIn)
	{
		oldStats.setFoodLevel(foodLevelIn);
	}

	@Override
	public void setFoodSaturationLevel(float foodSaturationLevelIn)
	{
		oldStats.setFoodSaturationLevel(foodSaturationLevelIn);
	}
}

 

I see the addExhaustion method being called a lot, which indicates to me that the replacement worked. However, while eating does correctly increase my food meter, I cannot seem to decrease it by any means - do you have any ideas on what could cause that?

Link to comment
Share on other sites

1 hour ago, diesieben07 said:
  • Please do not use the index-based field access, it is very unstable, as coremods and other evil things might add fields to the EntityPlayer class. Use the name based access and make sure to provide both the unobfuscated and SRG name.
  • Your modification to addExhaustion only means that exhaustion will last longer, which means your food level (and saturation first) will go down faster when running, etc.

Alright, I'll look into the names.

About the second thing: If you give the player 1 exhaustion per tick, the food bar will deplete in mere seconds. Using the same thing rerouted over CustomFoodStats does not have the same effect, regardless of calling it with or without the multiplier.

I.e. I have this:
 

	@SubscribeEvent
	public void playerTick(TickEvent.PlayerTickEvent event)
	{
		event.player.getFoodStats().addExhaustion(1.0F);
	}

for debug reasons. With the original, non-replaced FoodStats, it gives the desired effect of emptying your hunger bar in the blink of an eye. However, after I replaced the FoodStats with CustomFoodStats as decribed above, it ceases to work.

Edited by Alekseyev
fixed part of code for readability, didn't change content
Link to comment
Share on other sites

I'm a little embarrassed, now. Should have thought of debugging myself, but for some reason I often forget about that feature when doing stuff for Minecraft.

 

Anyway, it seems like I somehow built up an insane stack of negative exhaustion (talking 6 figure negative number here), after resetting that to be positive, it works as intended.

One thing I am wondering about, though: Will the player's FoodStats be reset to the vanilla class on every new joining of the world? Otherwise, the reflection triggered by each EntityJoinWorldEvent would loop and you'd get a deeply nested FoodStat under all those CustomFoodStats, right?

 

Link to comment
Share on other sites

1 hour ago, diesieben07 said:

Actually, that is a good point. You might want to use an instanceof check on the existing FoodStats before replacing it.

You'd want to make sure that the food stats isn't your own before replacing it.

Of course, this means that if another mod overrides yours in the same way after you do, and then the JoinWorld happens later without resetting it to the vanilla copy, your code would then wrap the other mod's in another copy of yours....

Apparently I'm a complete and utter jerk and come to this forum just like to make fun of people, be confrontational, and make your personal life miserable.  If you think this is the case, JUST REPORT ME.  Otherwise you're just going to get reported when you reply to my posts and point it out, because odds are, I was trying to be nice.

 

Exception: If you do not understand Java, I WILL NOT HELP YOU and your thread will get locked.

 

DO NOT PM ME WITH PROBLEMS. No help will be given.

Link to comment
Share on other sites

Yeah, there's not really a Good Way To Be Sure. :\

Apparently I'm a complete and utter jerk and come to this forum just like to make fun of people, be confrontational, and make your personal life miserable.  If you think this is the case, JUST REPORT ME.  Otherwise you're just going to get reported when you reply to my posts and point it out, because odds are, I was trying to be nice.

 

Exception: If you do not understand Java, I WILL NOT HELP YOU and your thread will get locked.

 

DO NOT PM ME WITH PROBLEMS. No help will be given.

Link to comment
Share on other sites

What I did for now is to check if the foodstats of the player are an instance of CustomFoodStats. If that's the case, print a short notification, otherwise proceed as normal and replace it. Of course it's not perfect, as @Draco18s pointed out, but during debugging it did indeed seem like the stats are reverted to vanilla each time the world is joined, as the replacement always takes place.

 

Thanks a lot for the help! :)

Link to comment
Share on other sites

Join the conversation

You can post now and register later. If you have an account, sign in now to post with your account.
Note: Your post will require moderator approval before it will be visible.

Guest
Unfortunately, your content contains terms that we do not allow. Please edit your content to remove the highlighted words below.
Reply to this topic...

×   Pasted as rich text.   Restore formatting

  Only 75 emoji are allowed.

×   Your link has been automatically embedded.   Display as a link instead

×   Your previous content has been restored.   Clear editor

×   You cannot paste images directly. Upload or insert images from URL.

Announcements



  • Recently Browsing

    • No registered users viewing this page.
  • Posts

    • hola thanks for answering  i set some system outs to test and see whats going on      @Override     protected void saveAdditional( CompoundTag nbt ){                  nbt.put("itemhandler", itemhandler.serializeNBT() );         nbt.putInt("progress", this.progress );         System.out.println("saveAdditional(nbt)");                 System.out.println(NbtUtils.prettyPrint(nbt)); //<-- this is whats getting saved         super.saveAdditional( nbt );     }     @Override     public void load( CompoundTag nbt ){         itemhandler.deserializeNBT( nbt.getCompound("itemhandler") );         this.progress = nbt.getInt("progress" );         System.out.println(NbtUtils.prettyPrint(nbt)); //<-- this is whats minecraft is giving back to the entity          System.out.println("load(nbt)");         super.load( nbt );     }   This dead adventurer body  has two parts a block and a block Item  both has their own item-handlers and their own menus all of that seems fine  Testing remarks : *when i change some element inside the gui  it triggers the saveAdditional(nbt) system out and shows a pretty print of the data being saved  *when the world map loads it triggers the load(nbt) system out and shows a pretty print of the data minecraft is giving to this Block Entity For the testing i gonna set mi BlockEntityBodyBlock, save something in it, close minecraft, fireup the game again and check if the items remain      ################ first try set the block entity (dead adventurer body like shaped) and left only a weath seed  in the slot 10 the console says its all right    close minecraft, launch it again i see the system out whit the data returned to the entity and its look good theres is only a weed seed  ################ Second try, now i gonna change the seed for two arrows  the console says its all right the two arrows are being saved    ######### Now close and run again bam Error  minecraft returns the original data whit only a wheat seed the two arrows has been loss   ########## try again now i gonna put 3 wheat seeds Console system out says it gets it and is saving the data   ############## but after close fire again  wheat seed,  data losed once more time  and it just throw the original   ####################################################################################### sorry for the long post and the crappy video  this is the reason why i say its saving the Block Entity data only when it feels like  coze its saves data when it feels like  ¿ its something wrong whit mi BlockEntity.saveAdditional()  if  i keep trying eventually it updates and the data chages      i alredy try to  level.removeBlockEntity(pos); level.setBlockEntity(pos, bebb);     BlockEntityBodyBlock.class   BlockEntityInit.class     body_blockitem.class                  
    • Yesterday I buy a minecraft server to play with my friends you know... One of my friends send me the list of mods to add and then i start to dowload them, when i add them to the server it start crashing but i don't know about this things because it's my first time buying a minecraft server This is the error: https://paste.ee/p/sJf7B
    • Discovering that a trusted colleague had accessed my Bitcoin account and transferred $30,000 worth of bitcoins was a devastating blow. It shattered the trust I had placed in them and left me feeling vulnerable and betrayed. However, in the face of adversity, I turned to MUYERN TRUST HACKER for assistance in reclaiming control over my finances and holding the perpetrators accountable for their actions. One of the standout features of MUYERN TRUST HACKER was its ability to provide real-time alerts and notifications, keeping me informed every step of the way. With the support of MUYERN TRUST HACKER, I was able to gather irrefutable evidence of the perpetrator's actions and hold them accountable for their crimes. Armed with the information provided by the platform, I pursued legal recourse and ensured that justice was served. The perpetrator faced severe consequences for their actions, including legal penalties and financial restitution. Beyond its role in facilitating the recovery process, MUYERN TRUST HACKER provided me with a sense of empowerment and resilience in the face of adversity. While the experience was undoubtedly challenging, it ultimately served as a testament to the importance of vigilance and the power of technology in safeguarding our digital assets. Thanks to MUYERN TRUST HACKER, I emerged stronger and more resilient, ready to face whatever challenges the future may hold. Mail; muyerntrusted[At] mail-me .c o m
    • Discovering that a trusted colleague had accessed my Bitcoin account and transferred $30,000 worth of bitcoins was a devastating blow. It shattered the trust I had placed in them and left me feeling vulnerable and betrayed. However, in the face of adversity, I turned to MUYERN TRUST HACKER web [ ht tps:// muyerntrusthack.solutions/ ] for assistance in reclaiming control over my finances and holding the perpetrators accountable for their actions. One of the standout features of MUYERN TRUST HACKER was its ability to provide real-time alerts and notifications, keeping me informed every step of the way. With the support of MUYERN TRUST HACKER, I was able to gather irrefutable evidence of the perpetrator's actions and hold them accountable for their crimes. Armed with the information provided by the platform, I pursued legal recourse and ensured that justice was served. The perpetrator faced severe consequences for their actions, including legal penalties and financial restitution. Beyond its role in facilitating the recovery process, MUYERN TRUST HACKER provided me with a sense of empowerment and resilience in the face of adversity. While the experience was undoubtedly challenging, it ultimately served as a testament to the importance of vigilance and the power of technology in safeguarding our digital assets. Thanks to MUYERN TRUST HACKER, I emerged stronger and more resilient, ready to face whatever challenges the future may hold. Mail; muyerntrusted[At] mail-me .c o m  
    • Do you have still this problem? (I have it too so I want to know if you did something with it)  
  • Topics

×
×
  • Create New...

Important Information

By using this site, you agree to our Terms of Use.