Jump to content

Confusion with CapabilityItemHandler and sidedness


pkmnfrk

Recommended Posts

I have a block that acts as a storage provider based on an ephemeral inventory; it doesn't use ItemStackHandler or anything because the inventory is virtual. So, I'm implementing IItemHandlerModifiable manually. However, I'm getting a crash on the client side because the data that I use to calculate the ephemeral storage is on the server, not the client*.

 

I'm not looking for help diagnosing the specific issue, but for help in understanding where it is expected that these capabilities should run properly. Should I be wrapping getSlots(), etc in

if(!world.isRemote)

? Or is it expected that this should all work correctly on the client side too?

 

Or (and this is the most likely scenario) am I completely misunderstanding how this all works?

 

My code, if it helps, is here: https://github.com/pkmnfrk/equivalentintegrations. If it helps, the crash happens here, because the cachedKnowledge List isn't populated, because the client never gets to load the data it would need to do this.

 

 

* - Unimportant background: I'm extending ProjectE and hooking into transmutation data. Technically this is in fact synced to the client, but I'm adding the possibility to use other player's data, which obviously would not be synced. So, I'm try to assume that this is server-side only.

Link to comment
Share on other sites

3 minutes ago, pkmnfrk said:

Or is it expected that this should all work correctly on the client side too?

This is true.

 

3 minutes ago, pkmnfrk said:

List isn't populated, because the client never gets to load the data it would need to do this.

Use packets to sync your data to the client.

VANILLA MINECRAFT CLASSES ARE THE BEST RESOURCES WHEN MODDING

I will be posting 1.15.2 modding tutorials on this channel. If you want to be notified of it do the normal YouTube stuff like subscribing, ect.

Forge and vanilla BlockState generator.

Link to comment
Share on other sites

Hm... I guess I'm struggling to see why that would be necessary.

 

I guess I didn't mention explicitly, but there's no way for the player to directly interact with this inventory; it's strictly meant for automation purposes. So, there should be no circumstance when the client is trying to view it...

 

*tries things*

 

Oh, actually it turns out that I'm just an idiot, the crash was happening on the server side because I forgot to create the hash map. It has nothing to do anything. ?

Link to comment
Share on other sites

4 minutes ago, pkmnfrk said:

Oh, actually it turns out that I'm just an idiot, the crash was happening on the server side because I forgot to create the hash map. It has nothing to do anything. ?

I've been there.

5 minutes ago, pkmnfrk said:

I guess I didn't mention explicitly, but there's no way for the player to directly interact with this inventory; it's strictly meant for automation purposes. So, there should be no circumstance when the client is trying to view it... 

Then you don't need to do anything on/for the client.

VANILLA MINECRAFT CLASSES ARE THE BEST RESOURCES WHEN MODDING

I will be posting 1.15.2 modding tutorials on this channel. If you want to be notified of it do the normal YouTube stuff like subscribing, ect.

Forge and vanilla BlockState generator.

Link to comment
Share on other sites

By the way, you mentioned that you don't use ItemStackHandler because your inventory is "virtual" - there's still nothing to stop you using it, and if you just need a simple inventory to hold a collection of items, it's by far the best option; you get some robust and well-tested code for free.  If you need any custom handling (e.g. only allow certain items in certain slots), there's also nothing stopping you from subclassing it.

 

(Of course, there may be good reasons to have a custom IItemHandlerModifiable implementation, but ask yourself if it's absolutely necessary).

Edited by desht
Link to comment
Share on other sites

I understand what you're saying, but in this case, it would be far more effort to synchronize the non-virtual inventory of the ItemStackHandler with the actually virtual data that I'm presenting. Some background:

 

I'm creating an addon for ProjectE that exposes a player's transmutation data as an inventory for automation purposes. If you're not familiar with ProjectE, it allows you to convert items to/from a currency called EMC. Eg, a piece of cobble is worth 1 EMC, while a furnace is worth 8 (because it's crafted from 8 cobble). You can sell the furnace to get 8 cobble back, or another furnace, or any other 8 EMC worth of items.

 

So, what I'm doing is taking the player's knowledge (which is a list of every Item they've put into this system), and their current EMC, and exposing how many of each you can make at the moment. So, if you have 64 EMC and knowledge of Cobble and Furnaces, then I expose 64 Cobble and 8 Furnaces. If one of these items is withdrawn, I deduct the EMC, and update the book keeping internally. Similarly, if you insert an item, I basically void the item stack and credit you the EMC.

 

Therefore, there's two tricky parts that ItemStackHandler wouldn't really help with:

 

1. These virtual slots change quantity based on how much EMC you have, not based on how many items you have.

2. The idea of slots is very nebulous. You can't move items arbitrarily, and the size of the container depends on how many items you know about, since this list is coming straight from an external data source (ProjectE's api)

 

I agree that it would be possible to overcome this, but I suspect that I'd have to override every single method with implementations that look very similar to what I have, plus some extra code to sync with ItemStackHandler's idea of inventory. The only part I wouldn't have to touch is the NBT serialization, and that's because I don't need to save this inventory at all (because it doesn't really exist)

 

TL;DR: I did think about it :)

 

Edit: My implementation is complete, and is part of the repo I mentioned in the OP. The one thing I did poorly that I'll probably refactor today is that I implemented it as part of the TileEntity, and I should probably have made it it's own class. I just need to think about how to do that properly, but that's a different matter

Edited by pkmnfrk
Link to comment
Share on other sites

Just make this a subclass of the existing ItemStackHandler class that overrides the extraction and insertion code to do that synchronization. When an item is inserted, convert it to a stack of cobble, and insert that into the super implementation.

 

When non-cobble is extracted, give the player the stack without reducing how many of that stack is available for extraction (unless their EMC falls too low) and modify the EMC available based on its cost.

Apparently I'm a complete and utter jerk and come to this forum just like to make fun of people, be confrontational, and make your personal life miserable.  If you think this is the case, JUST REPORT ME.  Otherwise you're just going to get reported when you reply to my posts and point it out, because odds are, I was trying to be nice.

 

Exception: If you do not understand Java, I WILL NOT HELP YOU and your thread will get locked.

 

DO NOT PM ME WITH PROBLEMS. No help will be given.

Link to comment
Share on other sites

Join the conversation

You can post now and register later. If you have an account, sign in now to post with your account.
Note: Your post will require moderator approval before it will be visible.

Guest
Unfortunately, your content contains terms that we do not allow. Please edit your content to remove the highlighted words below.
Reply to this topic...

×   Pasted as rich text.   Restore formatting

  Only 75 emoji are allowed.

×   Your link has been automatically embedded.   Display as a link instead

×   Your previous content has been restored.   Clear editor

×   You cannot paste images directly. Upload or insert images from URL.

Announcements



  • Recently Browsing

    • No registered users viewing this page.
  • Posts

    • There's a scheme I got into where they promised to trade Bitcoin for me and take a cut as a commission. Seemed like a good idea at the time. But then, things went south real fast. They ended up transferring   $190,000 worth of my Bitcoin. I was devastated and felt completely helpless. That's when I stumbled upon the Wizard Web Recovery Tool. It was like a beacon of hope amid chaos. With this tool, I could finally start digging into what went wrong and hopefully get my Bitcoin back. Using Wizard Web was surprisingly easy. I just had to plug in some details about my Bitcoin account and let it do its thing. It started scanning the internet, looking for any clues about what happened to my Bitcoin. It felt like having a detective on my side, searching for answers. And guess what? Wizard Web found some leads. It uncovered evidence of the scheme's shady dealings and helped me track down the people responsible for losing my Bitcoin. Armed with this information, I took the case to court. After a long and hard-fought legal battle, the court ruled in my favor. The perpetrators were held accountable for their actions and faced criminal charges for their involvement in the scheme. It was a victory not just for me, but for anyone who's been taken advantage of by these kinds of scams. Thanks to Wizard Web Recovery, I was able to get justice and reclaim what was rightfully mine. It showed me that even in the face of adversity, there's always a way to fight back. And with the right tools and determination, anything is possible.   The following is the contact information for Wizard Web Recovery.   Email: wizard web recovery((@))programmer . net
    • Hello, good morning. I know some programming and I'm interested in mod creation. That's why I've decided to follow a tutorial guide on YouTube by TurtyWurty. https://www.youtube.com/watch?v=DhoX9cmAZqA&t=160s&ab_channel=TurtyWurty I've followed the tutorial perfectly. The problem is that when checking the food, the texture doesn't load for me. However, everything seems fine no matter how much I check. I'm sure it's something trivial, the problem is that I can't find it. Could you help me solve it, please? I leave a zip of my file so you can edit it freely. forge-1.20-Civicraft.rar
    • If you have nvidia graphics, it's important that you make sure Minecraft (and anything Minecraft-related) is set to prefer high performance graphics first. If you only update your AMD drivers it might fix the issue but cause severe performance loss vs Vanilla as it'll be running on the integrated graphics instead of dedicated nvidia graphics
    • Update your drivers: https://www.amd.com/en/support/downloads/drivers.html/processors/ryzen/ryzen-5000-series/amd-ryzen-5-5600g.html
  • Topics

×
×
  • Create New...

Important Information

By using this site, you agree to our Terms of Use.