How can I add redstone components?

[WillTheGameDecoder]

I've been trying to mod in a new redstone component similar to the piston.  I've searched high and low on forums and YouTube, trying to figure out how to get this to work, but I can't seem to get any proper updates or read redstone signals like I'm expecting.  In all cases, it has either has ignored all redstone signals, or it doesn't function like it should (I've tested it with onBlockActivated. it does work)  Is there something I'm missing?  Do I need a TileEntity?  Am I overriding the wrong methods?  I should also mention that I'm just setting blocks in the world to test whether code is running, and it doesn't ever seem to.

package com.willtgd.testmod.blocks;

import java.util.Random;

import net.minecraft.block.Block;
import net.minecraft.block.state.IBlockState;
import net.minecraft.client.Minecraft;
import net.minecraft.util.math.BlockPos;
import net.minecraft.world.IBlockAccess;
import net.minecraft.world.World;

public class Teleporter extends Block {
	
	public Teleporter() {} // not important to the question at hand (i think)
	
	@Override
	public void updateTick(World world, BlockPos pos, IBlockState state, Random rand) {
		if (world.isBlockPowered(pos.add(0, 0, 1))) {
			world.setBlockState(pos.add(1, 0, 0), Block.getBlockFromName("minecraft:stone").getDefaultState());
		}
	}
	
	@Override
	public void onNeighborChange(IBlockAccess access, BlockPos pos, BlockPos neighbor) {
		World world = Minecraft.getMinecraft().world;
		
		if (world.isBlockPowered(neighbor)) {
			world.setBlockState(neighbor, Block.getBlockFromName("minecraft:dirt").getDefaultState());
		}
	}
	
	@Override
	public void observedNeighborChange(IBlockState state, World world, BlockPos observerPos, Block changedBlock, BlockPos changePos) {
		if (world.isBlockPowered(changePos)) {
			world.setBlockState(changePos, Block.getBlockFromName("minecraft:dirt").getDefaultState());
		}
	}
	
	private void swapBlocks(World world, BlockPos pos) {
		BlockPos up = pos.add(0, 1, 0);
		BlockPos down = pos.add(0, -1, 0);
		
		IBlockState temp = world.getBlockState(up);
		
		world.setBlockState(up, world.getBlockState(down));
		world.setBlockState(down, temp);
	}
}

[Draco18s]

  On 7/25/2018 at 3:04 AM, WillTheGameDecoder said:

swapBlocks

Expand  

Well, you aren't calling this method...

 

  On 7/25/2018 at 3:04 AM, WillTheGameDecoder said:

World world = Minecraft.getMinecraft().world;

Expand  

Why are you doing this? Not only are you reaching across logical sides, but you were passed a world object in the parameters. It's the IBlockAccess (you know, to access block information about the world from? Take a look at what classes implement this interface...)

[WillTheGameDecoder]

  On 7/25/2018 at 4:52 AM, Draco18s said:

Well, you aren't calling this method...

 

Why are you doing this? Not only are you reaching across logical sides, but you were passed a world object in the parameters. It's the IBlockAccess (you know, to access block information about the world from? Take a look at what classes implement this interface...)

Expand  

1) I know I'm not calling the method.  I did forget to add it, yeah, but it doesn't work, even when I do add it.

2) IBlockAccess doesn't have the "isBlockPowered" method.  It only has "getStrongPower" which requires an EnumFacing as well, which I don't understand either...

[Animefan8888]

  On 7/25/2018 at 5:41 AM, WillTheGameDecoder said:

requires an EnumFacing as well, which I don't understand either...

Expand  

Then test values to understand it. Or look through the code and find out what that parameter does.

[Draco18s]

  On 7/25/2018 at 5:41 AM, WillTheGameDecoder said:

IBlockAccess doesn't have the "isBlockPowered" method

Expand  

Cast it.

[Draco18s]

  On 7/25/2018 at 3:05 PM, diesieben07 said:

No. It will not always be a World.

Expand  

Doing a cast -> always check that it's valid first.

I figure that this is implied knowledge for the level of programming knowledge required to be posting here.

[Draco18s]

  On 7/25/2018 at 3:13 PM, diesieben07 said:

Not always the case either

Expand  

I am not sure what you are getting at here. ?

[Draco18s]

  On 7/25/2018 at 4:35 PM, diesieben07 said:

In this case you do need to do the check before casting. But saying "you always need to check before casting" is not true.

Expand  

Let me clarify then:

Upcasting does not require a check (and, in some respects, the cast isn't needed at all, as the parent attributes and definition should already be available)
Downcasting does, as there may be multiple implementations or subclasses

 

Now, if there's an exception by where downcasting does not require an instanceof check, that is not specific to a given implementation (e.g. "EntityFoo is only ever extended by EntityFooBar") I'd be happy to learn about it.

[WillTheGameDecoder]

  On 7/25/2018 at 3:01 PM, Draco18s said:

Cast it.

Expand  

Well, that certainly helps in that aspect, but my original question still stands.  My block isn't being updated when receiving weak power, and the code is still breaking, in spite of it working 100% in the "onBlockActivated" method

[Animefan8888]

  On 7/25/2018 at 5:21 PM, WillTheGameDecoder said:

breaking

Expand  

Define breaking.

  On 7/25/2018 at 5:21 PM, WillTheGameDecoder said:

Well, that certainly helps in that aspect, but my original question still stands.

Expand  

Post updated code, preferably the whole class.

[Draco18s]

  On 7/25/2018 at 4:59 PM, diesieben07 said:

One such place is block methods getting their tile entity. A downcast to the actual tile entity implementation does not need a check there.

Expand  

Ok, in general, I can agree with you, due to the way the scope works there.

 

There's still, tecnically, the possibility that it could crash, but only in cases where someone else fucked up somewhere.

There's the blockBroken method that I think is called after the block is removed that messed with a whole ton of people's code during a major update (1.10 -> 1.12?), and there's the "if someone fucks up their shouldRefresh method."

 

But you are correct in general that when things are working the way they're supposed to, no instanceof is needed. However, this is a very specific scenario that I'd argue is specific to the implementation detail of TileEntities within Minecraft and in not a general rule of programming.

[WillTheGameDecoder]

  On 7/25/2018 at 6:20 PM, Animefan8888 said:

Define breaking.

Post updated code, preferably the whole class.

Expand  

https://pastebin.com/RGWBr9RW

[Animefan8888]

  On 7/25/2018 at 7:00 PM, WillTheGameDecoder said:

https://pastebin.com/RGWBr9RW

Expand  

Could it possibly be the fact that the method swapBlock is called twice

[WillTheGameDecoder]

  On 7/25/2018 at 7:03 PM, Animefan8888 said:

Could it possibly be the fact that the method swapBlock is called twice

Expand  

No.  "onNeighborChange" doesn't get triggered at all, as far as I'm aware.  I forgot to delete that code

[Animefan8888]

  On 7/25/2018 at 7:12 PM, WillTheGameDecoder said:

No.  "onNeighborChange" doesn't get triggered at all, as far as I'm aware.  I forgot to delete that code

Expand  

Does observedNeighborChange get called?

[WillTheGameDecoder]

  On 7/25/2018 at 7:15 PM, Animefan8888 said:

Does observedNeighborChange get called?

Expand  

Yeah.  I found the issue now, though.  (forgot that changing blocks counts towards calling that method as well...)