Event That Fired When the Player Pickups An Arrow From Ground?

[JanneSoon]

Hello everyone. I'm stuck at somewhere in modding. I need to customize the arrow drop (getting the arrow back from the ground you shot). All i want is; the EntityArrow on the ground gives Broken Arrow(my mod item) by a chance instead of Arrow item from vanilla. Isn't it possible to do?

I looked into LivingDropsEvent, EntityItemPickupEvent and ItemPickupEvent but i couldn't find a way to do it. These events fired only when the player pickups an arrow as an item(dropped item) from the ground. Help me please

Thank you.

I'm currently on 1.12.2

Edited July 25, 2018 by JanneSoon

[m00nl1ght]

Unfortunately, there is no such event. The arrow is added to the players inventory directly in EntityArrow#onCollideWithPlayer.

 

[JanneSoon]

3 minutes ago, m00nl1ght said:

Unfortunately, there is no such event. The arrow is added to the players inventory directly in EntityArrow#onCollideWithPlayer.

 

 There's no way to do that i wish so?

[m00nl1ght]

You could create a pull request on Forge's github if you really need this hook/event. Here you can find information about pull requests.

[jabelar]

6 hours ago, JanneSoon said:

 There's no way to do that i wish so?

You can still do it but would require doing something a bit intrusive. For example, one approach is to replace all EntityArrow with your own version that extends EntityArrow and overrides the collision method.

 

Another approach would be to set the public pickupStatus field in every EntityArrow to EntityArrow.PickupStatus.DISALLOWED and then handle the entity update event and process the collision yourself.

[Cadiboo]

On 7/26/2018 at 1:12 AM, jabelar said:

You can still do it but would require doing something a bit intrusive. For example, one approach is to replace all EntityArrow with your own version that extends EntityArrow and overrides the collision method.

 

Another approach would be to set the public pickupStatus field in every EntityArrow to EntityArrow.PickupStatus.DISALLOWED and then handle the entity update event and process the collision yourself.

Could you also use reflection to replace that bit of code that handles pickups in EntityArrow with your code?

[Animefan8888]

7 minutes ago, Cadiboo said:

Could you also use reflection to replace that bit of code that handles pickups in EntityArrow with your code?

No, reflection allows you to access code that would otherwise be inaccessible, it doesn't allow you to modify a method.

[Cadiboo]

Just now, Animefan8888 said:

No, reflection allows you to access code that would otherwise be inaccessible, it doesn't allow you to modify a method.

I meant ASM, isn’t ASM an advanced form of reflection?

[Animefan8888]

Just now, Cadiboo said:

I meant ASM, isn’t ASM an advanced form of reflection?

No they are completely different, and ASM is a terrible thing that is not recommended on this forum.