addItemStackToInventory

[Enderlook]

I'm designing a new food which is a soup, so after eating the soup, the player must get in its inventory an empty bowl.

The thing is that I've found two ways of adding the item in the inventory and I want to know which of them is "better":

@Override
protected void onFoodEaten(ItemStack stack, World worldIn, EntityPlayer player) {		
	super.onFoodEaten(stack, worldIn, player);
	if(!worldIn.isRemote) {
		// Both commands seems the same
		player.inventory.addItemStackToInventory(new ItemStack(Items.BOWL));
		player.addItemStackToInventory(new ItemStack(Items.BOWL));
	}
}

(I've used "!worldIn.isRemote" because I've read that is a good practice... is that true?)

 

Which method is better?:

• player.inventory.addItemStackToInventory(ItemStack);
• player.addItemStackToInventory(ItemStack);

 

Also, I've found "player.inventory.mainInventoryaddItemStackToInventory(ItemStack);" but that crash the game when the food is eaten.

 

This method is inside the class of my custom item ("ItemEggSoup") which inherits from generic class ("TItemFood"), which that inherits from vanilla class ("ItemFood").

 

Thanks.

 

PD: This is my first time using this forum, so tell me if I've broken any rule, not sure how questions are done here.

[Draco18s]

57 minutes ago, Enderlook said:

(I've used "!worldIn.isRemote" because I've read that is a good practice... is that true?)

That's not why you use !worldIn.isRemote. You use !worldIn.isRemote when you want code that runs on both the client and the server to only run on the server.

[Animefan8888]

1 hour ago, Enderlook said:

player.addItemStackToInventory(ItemStack)

Is just a wrapper around

1 hour ago, Enderlook said:

player.inventory.addItemStackToInventory(ItemStack)

So either works, one is just less writing.

[Enderlook]

13 hours ago, Animefan8888 said:

Is just a wrapper around

So either works, one is just less writing.

Ok, a bit stupid my question, but, which of both is more common to use?

 

Also, I'll say this in order to maintain a record in the topic for future read: a person has sent me a private message (not sure why he didn't post in the topic, but thanks anyway) saying I could also use:

ItemHandlerHelper.giveItemToPlayer(player, new ItemStack(Items.BOWL)); 

Which is better because if the inventory is full the item will be drop on the floor. So,  is that line better than the others?

[Animefan8888]

10 hours ago, Enderlook said:

Ok, a bit stupid my question, but, which of both is more common to use?

I would use player.addItemStackToInventory

10 hours ago, Enderlook said:

Which is better because if the inventory is full the item will be drop on the floor. So,  is that line better than the others?

It depends on what you mean by better ItemHandlerHelper.giveItemToPlayer will drop the item as an entity which is useful in most cases, but it also wraps the PlayerInventory in an IItemHandler and handles the input that way.