Jump to content
Search the Forums BEFORE making a new post.
Currently supported: All versions

Copy item stack capabilities

Melonslise

By Melonslise
in Modder Support

 Share

Recommended Posts

Melonslise Creeper Killer

Melonslise

Posted
Posted

I’ve noticed that when updating nbt on the server, the client (most likely) recreates the stack, but doesn’t copy the attached capabilities. Can this be fixed without syncing? My capability is updated every tick so syncing it would be quite intensive.

Animefan8888 Reality Controller

Animefan8888

Posted
Posted
15 hours ago, Melonslise said:

I’ve noticed that when updating nbt on the server, the client (most likely) recreates the stack, but doesn’t copy the attached capabilities.

It depends on what you mean by re-creates and how you are editing it. ItemStack capabilities are not synced.

 

How are you updating your capability data?

VANILLA MINECRAFT CLASSES ARE THE BEST RESOURCES WHEN MODDING

I will be posting 1.15.2 modding tutorials on this channel. If you want to be notified of it do the normal YouTube stuff like subscribing, ect.

Forge and vanilla BlockState generator.

Melonslise Creeper Killer

Melonslise

Posted
  • Author
Posted
3 hours ago, Animefan8888 said:

It depends on what you mean by re-creates and how you are editing it. ItemStack capabilities are not synced.

 

How are you updating your capability data?

Identical code runs on both sides. Currently it works perfectly without updating the nbt.

Animefan8888 Reality Controller

Animefan8888

Posted
Posted
1 minute ago, Melonslise said:

Identical code runs on both sides.

This could cause problems based on how you are doing it, hopefully you are still basing actions off of the servers data.

1 minute ago, Melonslise said:

Currently it works perfectly without updating the nbt.

Define updating the NBT.

VANILLA MINECRAFT CLASSES ARE THE BEST RESOURCES WHEN MODDING

I will be posting 1.15.2 modding tutorials on this channel. If you want to be notified of it do the normal YouTube stuff like subscribing, ect.

Forge and vanilla BlockState generator.

Melonslise Creeper Killer

Melonslise

Posted
  • Author
Posted (edited)
1 hour ago, Animefan8888 said:

This could cause problems based on how you are doing it, hopefully you are still basing actions off of the servers data.

Actually the action is started on the client whenever the player presses a key and finishes on the client whenever he releases the key. Thus sending a return packet to the client would be wasteful.

1 hour ago, Animefan8888 said:

Define updating the NBT.

Whenever I write to the stack’s compound tag, the capabilities seem to reset.

Edited by Melonslise
Draco18s Reality Controller

Draco18s

Posted
Posted
6 hours ago, Melonslise said:

Whenever I write to the stack’s compound tag, the capabilities seem to reset.

Yes, because that's what Minecraft does when the stack NBT changes: when the server sends the update packet, the client assumes it is a new stack and recreates it.

Apparently I'm a complete and utter jerk and come to this forum just like to make fun of people, be confrontational, and make your personal life miserable.  If you think this is the case, JUST REPORT ME.  Otherwise you're just going to get reported when you reply to my posts and point it out, because odds are, I was trying to be nice.

 

Exception: If you do not understand Java, I WILL NOT HELP YOU and your thread will get locked.

 

DO NOT PM ME WITH PROBLEMS. No help will be given.

Melonslise Creeper Killer

Melonslise

Posted
  • Author
Posted (edited)
1 hour ago, Draco18s said:

Yes, because that's what Minecraft does when the stack NBT changes: when the server sends the update packet, the client assumes it is a new stack and recreates it.

Yeah, that’s what I wrote in my first post. But how do I fix that without syncing every tick? Is there any way I could copy the capabilities?

Edited by Melonslise
Draco18s Reality Controller

Draco18s

Posted
Posted

You shouldn't be stuffing NBT data into the item. That's why you have a Capability.

  • Thanks 1

Apparently I'm a complete and utter jerk and come to this forum just like to make fun of people, be confrontational, and make your personal life miserable.  If you think this is the case, JUST REPORT ME.  Otherwise you're just going to get reported when you reply to my posts and point it out, because odds are, I was trying to be nice.

 

Exception: If you do not understand Java, I WILL NOT HELP YOU and your thread will get locked.

 

DO NOT PM ME WITH PROBLEMS. No help will be given.

Melonslise Creeper Killer

Melonslise

Posted
  • Author
Posted
2 hours ago, Draco18s said:

You shouldn't be stuffing NBT data into the item. That's why you have a Capability.

Oh didn’t think of that. But what if some other mod modifies the stack’s nbt? Thanks

Animefan8888 Reality Controller

Animefan8888

Posted
Posted
28 minutes ago, Melonslise said:

Oh didn’t think of that. But what if some other mod modifies the stack’s nbt? Thanks

They should also be using a capability. The only possible way to ensure that the capability stays in sync on an nbt change would be to constantly verify with the server and then send an update packet back to the client. Though as I said they should also be using a capability for ItemStack data.

VANILLA MINECRAFT CLASSES ARE THE BEST RESOURCES WHEN MODDING

I will be posting 1.15.2 modding tutorials on this channel. If you want to be notified of it do the normal YouTube stuff like subscribing, ect.

Forge and vanilla BlockState generator.

Melonslise Creeper Killer

Melonslise

Posted
  • Author
Posted (edited)

Issue not fixed. Using a serializable capability still causes the others to reset. I tried not updating the capability and it worked absolutely fine - just like without updating the nbt.

Edited by Melonslise
jabelar Reality Controller

jabelar

Posted
Posted

Is this item capability only relevant when it is held? If so you might want to change it from being an item capability to being a player capability, as that might be easier to keep synced. Basically have player capability for "holding special item in my main hand" or whatever you need to trigger the rest of your logic.

Check out my tutorials here: http://jabelarminecraft.blogspot.com/

Melonslise Creeper Killer

Melonslise

Posted
  • Author
Posted
On 8/3/2018 at 6:44 PM, jabelar said:

Is this item capability only relevant when it is held? If so you might want to change it from being an item capability to being a player capability, as that might be easier to keep synced. Basically have player capability for "holding special item in my main hand" or whatever you need to trigger the rest of your logic.

Yes, they are mostly only relevant while held. I thought about that, but I’m not sure if adding 3-4 caps to every single player for a few items is good practice.

Animefan8888 Reality Controller

Animefan8888

Posted
Posted
45 minutes ago, Melonslise said:

Yes, they are mostly only relevant while held. I thought about that, but I’m not sure if adding 3-4 caps to every single player for a few items is good practice.

Merge them all into one cap.

VANILLA MINECRAFT CLASSES ARE THE BEST RESOURCES WHEN MODDING

I will be posting 1.15.2 modding tutorials on this channel. If you want to be notified of it do the normal YouTube stuff like subscribing, ect.

Forge and vanilla BlockState generator.

Join the conversation

You can post now and register later. If you have an account, sign in now to post with your account.
Note: Your post will require moderator approval before it will be visible.

Guest
Unfortunately, your content contains terms that we do not allow. Please edit your content to remove the highlighted words below.
Reply to this topic...

×   Pasted as rich text.   Restore formatting

  Only 75 emoji are allowed.

×   Your link has been automatically embedded.   Display as a link instead

×   Your previous content has been restored.   Clear editor

×   You cannot paste images directly. Upload or insert images from URL.

×
 Share
Go to topic listing

Announcements



  • Recently Browsing

    • No registered users viewing this page.

  • Posts

    • Sandermall
      updateShape functionality deep dive

      By Sandermall · Posted

      Hello all. I'm currently grappling with the updateShape method in a custom class extending Block.  My code currently looks like this: The conditionals in CheckState are there to switch blockstate properties, which is working fine, as it functions correctly every time in getStateForPlacement.  The problem I'm running into is that when I update a state, the blocks seem to call CheckState with the position of the block which was changed updated last.  If I build a wall I can see the same change propagate across. My question thus is this: is updateShape sending its return to the neighbouring block?  Is each block not independently executing the updateShape method, thus inserting its own current position?  The first statement appears to be true, and the second false (each block is not independently executing the method). I have tried to fix this by saving the block's own position to a variable myPos at inception, and then feeding this in as CheckState(myPos) but this causes a worse outcome, where all blocks take the update of the first modified block, rather than just their neighbour.  This raises more questions than it answers, obviously: how is a different instance's variable propagating here?  I also tried changing it so that CheckState did not take a BlockPos, but had myPos built into the body - same problem. I have previously looked at neighbourUpdate and onNeighbourUpdate, but could not find a way to get this to work at all.  One post on here about updatePostPlacement and other methods has proven itself long superceded.  All other sources on the net seem to be out of date. Many thanks in advance for any help you might offer me, it's been several days now of trying to get this work and several weeks of generally trying to get round this roadblock.  - Sandermall
    • djdoyle1556
      crash dump

      By djdoyle1556 · Posted

      sorry, I might be stupid, but how do I open it? because the only options I have are too X out, copy it, which doesn't work and send crash report, which doesn't show it to me, also, sorry for taking so long.
    • Radio_Man
      Maybe wrong place to post but need help installing forge.

      By Radio_Man · Posted

      ah ok  
    • Choonster
      BUG: Cactus Flower Placement is BROKEN

      By Choonster · Posted

      Can you reproduce this with version 55.0.21? A whole lot of plant placement issues were just fixed in this PR.
    • KenshinSpirit
      java.lang.IllegalStateException: Pose stack not empty

      By KenshinSpirit · Posted

      Necro'ing that thread to ask if you found a solution ? I'm encountering the same crash on loading the world. I created the world in Creative to test my MP, went into survival to test combat, died, crashed on respawn and since then crash on loading the world. Deactivating Oculus isn't fixing it either, and I don't have Optifine (Twilight forest is incompatible)

  • Topics

×
×
  • Create New...

Important Information

By using this site, you agree to our Terms of Use.

  I accept