Copy item stack capabilities

[Melonslise]

I’ve noticed that when updating nbt on the server, the client (most likely) recreates the stack, but doesn’t copy the attached capabilities. Can this be fixed without syncing? My capability is updated every tick so syncing it would be quite intensive.

[Animefan8888]

15 hours ago, Melonslise said:

I’ve noticed that when updating nbt on the server, the client (most likely) recreates the stack, but doesn’t copy the attached capabilities.

It depends on what you mean by re-creates and how you are editing it. ItemStack capabilities are not synced.

 

How are you updating your capability data?

[Melonslise]

3 hours ago, Animefan8888 said:

It depends on what you mean by re-creates and how you are editing it. ItemStack capabilities are not synced.

 

How are you updating your capability data?

Identical code runs on both sides. Currently it works perfectly without updating the nbt.

[Animefan8888]

1 minute ago, Melonslise said:

Identical code runs on both sides.

This could cause problems based on how you are doing it, hopefully you are still basing actions off of the servers data.

1 minute ago, Melonslise said:

Currently it works perfectly without updating the nbt.

Define updating the NBT.

[Melonslise]

1 hour ago, Animefan8888 said:

This could cause problems based on how you are doing it, hopefully you are still basing actions off of the servers data.

Actually the action is started on the client whenever the player presses a key and finishes on the client whenever he releases the key. Thus sending a return packet to the client would be wasteful.

1 hour ago, Animefan8888 said:

Define updating the NBT.

Whenever I write to the stack’s compound tag, the capabilities seem to reset.

Edited August 1, 2018 by Melonslise

[Draco18s]

6 hours ago, Melonslise said:

Whenever I write to the stack’s compound tag, the capabilities seem to reset.

Yes, because that's what Minecraft does when the stack NBT changes: when the server sends the update packet, the client assumes it is a new stack and recreates it.

[Melonslise]

1 hour ago, Draco18s said:

Yes, because that's what Minecraft does when the stack NBT changes: when the server sends the update packet, the client assumes it is a new stack and recreates it.

Yeah, that’s what I wrote in my first post. But how do I fix that without syncing every tick? Is there any way I could copy the capabilities?

Edited August 1, 2018 by Melonslise

[Draco18s]

You shouldn't be stuffing NBT data into the item. That's why you have a Capability.

[Melonslise]

2 hours ago, Draco18s said:

You shouldn't be stuffing NBT data into the item. That's why you have a Capability.

Oh didn’t think of that. But what if some other mod modifies the stack’s nbt? Thanks

[Animefan8888]

28 minutes ago, Melonslise said:

Oh didn’t think of that. But what if some other mod modifies the stack’s nbt? Thanks

They should also be using a capability. The only possible way to ensure that the capability stays in sync on an nbt change would be to constantly verify with the server and then send an update packet back to the client. Though as I said they should also be using a capability for ItemStack data.

[Melonslise]

Issue not fixed. Using a serializable capability still causes the others to reset. I tried not updating the capability and it worked absolutely fine - just like without updating the nbt.

Edited August 3, 2018 by Melonslise

[jabelar]

Is this item capability only relevant when it is held? If so you might want to change it from being an item capability to being a player capability, as that might be easier to keep synced. Basically have player capability for "holding special item in my main hand" or whatever you need to trigger the rest of your logic.

[Melonslise]

On 8/3/2018 at 6:44 PM, jabelar said:

Is this item capability only relevant when it is held? If so you might want to change it from being an item capability to being a player capability, as that might be easier to keep synced. Basically have player capability for "holding special item in my main hand" or whatever you need to trigger the rest of your logic.

Yes, they are mostly only relevant while held. I thought about that, but I’m not sure if adding 3-4 caps to every single player for a few items is good practice.

[Animefan8888]

45 minutes ago, Melonslise said:

Yes, they are mostly only relevant while held. I thought about that, but I’m not sure if adding 3-4 caps to every single player for a few items is good practice.

Merge them all into one cap.