Custom lamp problem 1.12.2

[MrPablo2000]

Hi, it me   - again...

 

 

I want to make my neon letter as a redstone lamp. I use the code from RedstoneLight.class. 

When I power my block, its working. It place block NeonLetterENeonActive...but with another rotation as NeonLetterEIdle...

 

My default direction is West, but i make a method that the block rotates to player on placing. 

 

For example: Idle block is north, but when i power it, the powered block are placed with default, west rotation..

 

 

What i must change in code, to get this: when i power the block, powered block has the same ratation as unpowered?

 

I use this code - it's coppied from vanilla RedstoneLight:

Spoiler

   public void onBlockAdded(World worldIn, BlockPos pos, IBlockState state)
    {
        if (!worldIn.isRemote)
        {
            if (this.isOn && !worldIn.isBlockPowered(pos))
            {
                worldIn.setBlockState(pos, ModBlocks.neonletterENeonIdle.getDefaultState(), 2);
            }
            else if (!this.isOn && worldIn.isBlockPowered(pos))
            {
                worldIn.setBlockState(pos, ModBlocks.neonletterENeonActive.getDefaultState(), 2);
            }
        }
    }

    /**
     * Called when a neighboring block was changed and marks that this state should perform any checks during a neighbor
     * change. Cases may include when redstone power is updated, cactus blocks popping off due to a neighboring solid
     * block, etc.
     */
    public void neighborChanged(IBlockState state, World worldIn, BlockPos pos, Block blockIn, BlockPos fromPos)
    {
        if (!worldIn.isRemote)
        {
            if (this.isOn && !worldIn.isBlockPowered(pos))
            {
                worldIn.scheduleUpdate(pos, this, 4);
            }
            else if (!this.isOn && worldIn.isBlockPowered(pos))
            {
                worldIn.setBlockState(pos, ModBlocks.neonletterENeonActive.getDefaultState(), 2);
            }
        }
    }

    public void updateTick(World worldIn, BlockPos pos, IBlockState state, Random rand)
    {
        if (!worldIn.isRemote)
        {
            if (this.isOn && !worldIn.isBlockPowered(pos))
            {
                worldIn.setBlockState(pos, ModBlocks.neonletterENeonIdle.getDefaultState(), 2);
            }
        }
    }

 

Edited August 19, 2018 by MrPablo2000
language errors - sorry for my bad English..

[MrPablo2000]

I must use 2 blocks, because i use 2 the same models, but with diferrent texture.

 

Quote

You must use a state that includes the facing.

How?

[MrPablo2000]

I try to use getActualState, but its marked as @Deprected  

 

 

Why it isn't true ?

[Draco18s]

As I told you via PM, @deprecated means "do not INVOKE," not "do not override." If you look at the block class literally every method is marked @deprecated.

Edited August 20, 2018 by Draco18s

[MrPablo2000]

I still don't know how to do it.. 

 

I try this way, to use only 1 block:

public void updateTick(World worldIn, BlockPos pos, IBlockState state, Random rand)
{
    if (!worldIn.isRemote)
    {
        if (!worldIn.isBlockPowered(pos))
        {
            isActive=false;
        }
    }
}

 

In constructor:

	if(this.isActive=true)
		{
			setLightLevel(1F);
		}

 

 

and boolean:

private boolean isActive = false;	

 

 

But it stil doesn't work...  

[Cadiboo]

2 hours ago, MrPablo2000 said:

I still don't know how to do it.. 

 

I try this way, to use only 1 block:

public void updateTick(World worldIn, BlockPos pos, IBlockState state, Random rand)
{
    if (!worldIn.isRemote)
    {
        if (!worldIn.isBlockPowered(pos))
        {
            isActive=false;
        }
    }
}

 

In constructor:

	if(this.isActive=true)
		{
			setLightLevel(1F);
		}

 

 

and boolean:

private boolean isActive = false;	

 

 

But it stil doesn't work...  

Post your entire code, and preferably a GitHub 

[V0idWa1k3r]

2 hours ago, MrPablo2000 said:

public void updateTick(World worldIn, BlockPos pos, IBlockState state, Random rand)

This doesn't work the way you think it does. It's not the same as the update method of TileEntities that gets called once per tick. This method gets called once per tick... on one random block in all loaded chunks.

 

2 hours ago, MrPablo2000 said:

if(this.isActive=true)

This is always true since this sets the isActive field to true.

 

2 hours ago, MrPablo2000 said:

private boolean isActive = false;	

 

Blocks are singletons. You can't use fields to store per-block data. Use block properties.

[Draco18s]

1 hour ago, V0idWa1k3r said:

This method gets called once per tick... on one random block in all loaded chunks.

Well, I think its actually on 16 blocks per chunk, but otherwise more or less.

[MrPablo2000]

7 hours ago, V0idWa1k3r said:

This doesn't work the way you think it does. It's not the same as the update method of TileEntities that gets called once per tick. This method gets called once per tick... on one random block in all loaded chunks.

 

This is always true since this sets the isActive field to true.

 

Blocks are singletons. You can't use fields to store per-block data. Use block properties.

Block Properties? You mean .setHardness, .setLightLevel etc?

[V0idWa1k3r]

4 minutes ago, MrPablo2000 said:

Block Properties? You mean .setHardness, .setLightLevel etc?

No, I mean properties that you define in your blockstate container. For example the growth of crops, variants of stone, whether the leaves will decay, etc.

[MrPablo2000]

I try to do it with crops code, but i never works with Properties...Have you any toturial about it ?

[Animefan8888]

3 hours ago, MrPablo2000 said:

I try to do it with crops code, but i never works with Properties...Have you any toturial about it ?

Check out the forge docs on BlockStates.

[MrPablo2000]

I try it, but i don't know how to connect fancing variants and state value  

 

This is my blockstate:

https://pastebin.com/kCKusa9w

 

This is my class code:

https://pastebin.com/r2TTqG5e

 

and this is crash...

https://pastebin.com/fzNQ1xke

[V0idWa1k3r]

Quote

 "facing=north": 

That is not how you define states in forge blockstates. If you want to use vanilla syntax use vanilla format.

 

On 8/21/2018 at 3:46 PM, V0idWa1k3r said:

On 8/21/2018 at 12:51 PM, MrPablo2000 said:

public void updateTick(World worldIn, BlockPos pos, IBlockState state, Random rand)

This doesn't work the way you think it does. It's not the same as the update method of TileEntities that gets called once per tick. This method gets called once per tick... on one random block in all loaded chunks.

 

public boolean isMaxState(IBlockState state)
{
    return ((Integer)state.getValue(this.getStateProperty())).intValue() >= this.getMaxState();
}

This will never be true as your state property is within a [0-1] range and getMaxState returns 7 for whatever reason.

Also you don't need half of these methods, they just make your block class bloated. Never copy vanilla code and simply change the names of methods and variables without understanding of what's going on.

 

@Override
    public int getMetaFromState(IBlockState state) {
        return ((EnumFacing)state.getValue(FACING)).getHorizontalIndex();
}
 
    @Override
    public IBlockState getStateFromMeta(int meta) {
        return getDefaultState().withProperty(FACING, EnumFacing.getHorizontal(meta));
    }

You must include your state property in metadata serialization/deserialization.

 

@Override
    public BlockStateContainer createBlockState() {
        return new BlockStateContainer(this, FACING);
    }

You must include your state property in the BlockStateContainer created.

 

    public static final PropertyInteger STATE = PropertyInteger.create("state", 0, 1);

If your integer is only within a [0-1] range then you don't need an integer, you need a boolean. 

 

Here are the docs on the blockstates.