[1.12.2] Custom player inventory

[Asmodesu]

So I want to create my own version of the player's inventory and it's gui which will be advanced with more tabs further (just like CustomNPCs does). And at this part I am confused at the very beginning. I've tried to look up at the vanilla sources but it was abit complicated to figure out the whole sequence. So I need someone to point me the right stages for:

1. Creating own inventory as the container with custom item, equipment and hotbar slots.

2. Creating appropriate GUI which will handle all the actions with inventory.

3. Catching the event of opening vanilla inventory to substitute it with mine.

Thanks in advance.

[Cadiboo]

21 minutes ago, Asmodesu said:

So I want to create my own version of the player's inventory and it's gui which will be advanced with more tabs further (just like CustomNPCs does). And at this part I am confused at the very beginning. I've tried to look up at the vanilla sources but it was abit complicated to figure out the whole sequence. So I need someone to point me the right stages for:

1. Creating own inventory as the container with custom item, equipment and hotbar slots.

2. Creating appropriate GUI which will handle all the actions with inventory.

3. Catching the event of opening vanilla inventory to substitute it with mine.

Thanks in advance.

where are you going to be opening the GUI from? what will hold your container?

[Asmodesu]

12 minutes ago, Cadiboo said:

where are you going to be opening the GUI from? what will hold your container?

If I understood your questions correctly:

1. As I wrote, GUI will be opened instead of the vanilla one when pressing "Open Inventory" key which is E by default.

2. My container will hold actual player's inventory, his equipment slots, his items hotbar and skills hotbar contents.

Edited August 30, 2018 by Asmodesu

[Zetko]

If you want to change the vanilla inventory GUI you can do that by cancelling the GuiOpenEvent when the GUI is an instance of GuiInventory and opening your GUI after.

Edited August 30, 2018 by Zetko

[Zetko]

For the 1. and 2. question: 

You could create a Container which holds the vanilla player inventory and your custom slots.

You could try extending the vanilla GuiInventory and change it as you want.

 

Edited August 30, 2018 by Zetko

[Animefan8888]

9 hours ago, Asmodesu said:

Creating own inventory as the container with custom item, equipment and hotbar slots.

You'll have to create your own capability that stores ItemStacks and attach it to the player. You can use an IItemHandler as the actual storage if you wish, it'll ultimately be easier.

9 hours ago, Asmodesu said:

actions with inventory.

Define this. What actions.

 

[Asmodesu]

11 hours ago, Animefan8888 said:

Define this. What actions.

Standard actions with inventory like drag&drop, stacking, tooltip on hovering etc.

[Animefan8888]

5 minutes ago, Asmodesu said:

Standard actions with inventory like drag&drop, stacking, tooltip on hovering etc.

Those are all handled automatically with the vanilla stuff.

[Asmodesu]

16 hours ago, Animefan8888 said:

You'll have to create your own capability that stores ItemStacks and attach it to the player. You can use an IItemHandler as the actual storage if you wish, it'll ultimately be easier.

So I've created my Interface that extends IItemHandler and is implemented with my default implementation which has methods for inventory handling. I've created my own capability using @CapabilityInject(myInterface.class) and created my InventoryProvider which has (de)serializeNBT methods I'm currently working on.

Am I doing it right? And how then should implement the gui itself, how should I handle packets between client and server?

Edited August 31, 2018 by Asmodesu

[Animefan8888]

5 hours ago, Asmodesu said:

Am I doing it right?

Yes that is the appropriate way.

5 hours ago, Asmodesu said:

And how then should implement the gui itself

Create a Gui class that extends the one the Players inventory uses.

5 hours ago, Asmodesu said:

how should I handle packets between client and server?

You dont need to make packets unless you wanna do something special. Minecraft already has packets for inventories.

[Asmodesu]

4 minutes ago, Animefan8888 said:

Create a Gui class that extends the one the Players inventory uses.

Do you mean InventoryEffectRenderer?

[Zetko]

No, extend GuiInventory.

[Asmodesu]

Thanks, I'll give it a shot.

[Zetko]

If that doesn't work then extend InventoryEffectRenderer. 

[Cadiboo]

You have to extend at least GuiScreen or one of its subclasses, the closer to the vanilla inventory you can get the better

[Asmodesu]

Meanwhile I'm having some issues with cloning inventory capability. MC throws a NullPointerException to the 5th line any time I'm trying to resurrect after death.

ICustomInventoryCap inventoryExt = player.getCapability(CustomInventoryProvider.CUSTOM_INVENTORY_CAP, null);
        ICustomInventoryCap oldInventoryExt = event.getOriginal().getCapability(CustomInventoryProvider.CUSTOM_INVENTORY_CAP, null);

        for (int i = 0; i < inventoryExt.getSlots(); i++) {
            System.out.println (oldInventoryExt.getStackInSlot(i).getDisplayName());
            inventoryExt.insertItem(i, oldInventoryExt.getStackInSlot(i), false);
        }

Probably I'm doing something wrong trying to clone, nevertheless I have another capability which clones itself pretty well using the same algorithm.

[Cadiboo]

What exactly is null?

Is player always non null?

is getOriginal always non null?

 

do they both have your capability 100% of the time?

 

Also you should be properly copying the itemstacks, not just copying the references.

[Asmodesu]

1 hour ago, Cadiboo said:

What exactly is null?

Is player always non null?

is getOriginal always non null?

 

do they both have your capability 100% of the time?

 

Also you should be properly copying the itemstacks, not just copying the references.

As I said NullPointer refers to oldInventoryExt.getStackInSlot(i) so I guess it is the slot content to return null. For ur 2nd, 3rd and 4th questions the answer is "yes".

Also what do you mean by "proper copying". getStackInSlot returns itemstack and insertItem inserts itemstack directly to the inventory capability storage.

[Animefan8888]

5 hours ago, Asmodesu said:

As I said NullPointer refers to oldInventoryExt.getStackInSlot(i) so I guess it is the slot content to return null.

This cannot happen since ItemStacks cant, rather shouldn't be null. My guess is that it is your capability that is null or, you didn't use a NonNullList to store your ItemStacks.

[Draco18s]

3 hours ago, Animefan8888 said:

This cannot happen since ItemStacks cant, rather shouldn't be null. My guess is that it is your capability that is null or, you didn't use a NonNullList to store your ItemStacks.

I think you meant an ItemStackHandler

[Animefan8888]

Just now, Draco18s said:

I think you meant an ItemStackHandler

Technically yes, but they are ultimately stored as a NonNullList<ItemStack> ?

[Draco18s]

Yes, but you can't screw that up if you're using ItemStackHandler. It's already implemented.

[Cadiboo]

11 hours ago, Asmodesu said:

Also what do you mean by "proper copying". getStackInSlot returns itemstack and insertItem inserts itemstack directly to the inventory capability storage.

Yeah, but it inserts the same itemstack itemstack that is in your old inventory. What if something modifies the old inventory? Your new one will also be modified

[Asmodesu]

Wow, another question. I have this piece of code that should render my GUI depending on current resolution.

@SubscribeEvent //render extended health bar;
    public void renderGUI(RenderGameOverlayEvent event) {
        if (event.getType() == RenderGameOverlayEvent.ElementType.TEXT) {
            Minecraft mc = Minecraft.getMinecraft();
            ScaledResolution screen = new ScaledResolution(mc);
            int scFactor = Math.min((int) (screen.getScaledWidth() / originalWidth), (int) (screen.getScaledHeight() / originalHeight));
            //int width = (int) (hpBarWidth / originalWidth * screen.getScaledWidth()), height = (int) (hpBarHeight / originalHeight * screen.getScaledHeight());
            int x = (int) (hpBarX / originalWidth * screen.getScaledWidth()), y = (int) (hpBarY / originalHeight * screen.getScaledHeight());
            int currentWidth = (int) ((hpBarWidth / mc.player.getMaxHealth()) * mc.player.getHealth());
            GlStateManager.enableAlpha();
            GlStateManager.enableBlend();
            GlStateManager.alphaFunc(516, 0.1F);
            mc.renderEngine.bindTexture(hpBar);
            GL11.glPushMatrix();
            drawTexturedModalRect(x, y, 0, 0, hpBarWidth, hpBarHeight);
            drawTexturedModalRect(x, y, 0, hpBarHeight, currentWidth, hpBarHeight);
            drawTexturedModalRect(x, y, 0, hpBarHeight * 2, hpBarWidth, hpBarHeight);
            drawTexturedModalRect(x, y, 0, hpBarHeight * 3, hpBarWidth, hpBarHeight);
            GlStateManager.scale(scFactor, scFactor, scFactor);
            GL11.glPopMatrix();
            GlStateManager.disableBlend();
            GlStateManager.disableAlpha();
        }
    }

But seems like somewhy screen.getScaledWidth() and screen.getScaledHeight() both return zero that turns all screen adaptation system to nonsense. Probably I miss something about their implementation otherwise I don't understand how can they return zero values.

Edited September 5, 2018 by Asmodesu

[Cadiboo]

12 hours ago, Asmodesu said:

Wow, another question. I have this piece of code that should render my GUI depending on current resolution.

@SubscribeEvent //render extended health bar;
    public void renderGUI(RenderGameOverlayEvent event) {
        if (event.getType() == RenderGameOverlayEvent.ElementType.TEXT) {
            Minecraft mc = Minecraft.getMinecraft();
            ScaledResolution screen = new ScaledResolution(mc);
            int scFactor = Math.min((int) (screen.getScaledWidth() / originalWidth), (int) (screen.getScaledHeight() / originalHeight));
            //int width = (int) (hpBarWidth / originalWidth * screen.getScaledWidth()), height = (int) (hpBarHeight / originalHeight * screen.getScaledHeight());
            int x = (int) (hpBarX / originalWidth * screen.getScaledWidth()), y = (int) (hpBarY / originalHeight * screen.getScaledHeight());
            int currentWidth = (int) ((hpBarWidth / mc.player.getMaxHealth()) * mc.player.getHealth());
            GlStateManager.enableAlpha();
            GlStateManager.enableBlend();
            GlStateManager.alphaFunc(516, 0.1F);
            mc.renderEngine.bindTexture(hpBar);
            GL11.glPushMatrix();
            drawTexturedModalRect(x, y, 0, 0, hpBarWidth, hpBarHeight);
            drawTexturedModalRect(x, y, 0, hpBarHeight, currentWidth, hpBarHeight);
            drawTexturedModalRect(x, y, 0, hpBarHeight * 2, hpBarWidth, hpBarHeight);
            drawTexturedModalRect(x, y, 0, hpBarHeight * 3, hpBarWidth, hpBarHeight);
            GlStateManager.scale(scFactor, scFactor, scFactor);
            GL11.glPopMatrix();
            GlStateManager.disableBlend();
            GlStateManager.disableAlpha();
        }
    }

But seems like somewhy screen.getScaledWidth() and screen.getScaledHeight() both return zero that turns all screen adaptation system to nonsense. Probably I miss something about their implementation otherwise I don't understand how can they return zero values.

Don’t use GL11 directly, use GLStateManager

 

other than that I can’t see any obvious problems, you might be using scaled resolution incorrectly? Can you post a GitHub?