[1.12.2] Custom model doesn't render correctly

[Spaceboy Ross]

This is what the model is supposed to look like.

But this is what it looks like in game.

The class of the model is com.spaceboyross.gundam.models.ms.gundams.RX782GundamMobileSuitModel. I have the mod stored on github: https://github.com/SpaceboyRoss01/MSGundamMod

Edited October 1, 2018 by Spaceboy Ross
Mod has moved from 1.12 to 1.12.2

[Cadiboo]

I couldn’t find any client/rendering package, where is your model rendering code?

 

Your entity.render package doesn’t appear to contain any code relevant to rendering your entity

Edited October 2, 2018 by Cadiboo

[Spaceboy Ross]

  On 10/2/2018 at 2:33 AM, Cadiboo said:

I couldn’t find any client/rendering package, where is your model rendering code?

 

Your entity.render package doesn’t appear to contain any code relevant to rendering your entity

Expand  

The entity.render package is for non-Mobile Suit type entities. com.spaceboyross.gundam.models.ms.gundams.RX782GundamMobileSuitModel is the RX-78-2 Gundam Mobile Suit model class. So the com.spaceboyross.gundam.models.ms package is for the models for Mobile Suits.

[Animefan8888]

  On 10/2/2018 at 2:31 PM, Spaceboy Ross said:

The entity.render package is for non-Mobile Suit type entities. com.spaceboyross.gundam.models.ms.gundams.RX782GundamMobileSuitModel is the RX-78-2 Gundam Mobile Suit model class. So the com.spaceboyross.gundam.models.ms package is for the models for Mobile Suits.

Expand  

Not where is your model, where is the code that makes it appear on the screen?

[Spaceboy Ross]

  On 10/2/2018 at 2:43 PM, Animefan8888 said:

Not where is your model, where is the code that makes it appear on the screen?

Expand  

Oh, that is com.spaceboyross.gundam.ms.MobileSuit.MSRender

[Animefan8888]

  On 10/2/2018 at 2:44 PM, Spaceboy Ross said:

Oh, that is com.spaceboyross.gundam.ms.MobileSuit.MSRender

Expand  

Does this return the correct ResourceLocation?

[Spaceboy Ross]

Yes it does

[Cadiboo]

You should probably consider splitting up your client/common/server code more (this will probably crash on a dedicated server)

 

Also NEVER return a null itemstack. Return ItemStack.EMPTY.

`public ItemStack getRequiredItemToPilot() {

    return null;

}`

 

What exactly is going wrong with your model? How are you loading the model?

[Animefan8888]

  On 10/2/2018 at 3:01 PM, Spaceboy Ross said:

Yes it does

Expand  

Check what texture is bound in your render code in the debugger.

[Cadiboo]

Wait is it just the parts of the model with rotation that are rendering weirdly? If so I think that it might be something wrong with BlockBench’s model renderer OR the rotations/translations are being applied. Try toggling the checkbox inside BlockBench that says Origin To Geometry. Try making a smaller model with rotated pieces and also look at the JSON model text and see if the sizes look correct.

Edited October 3, 2018 by Cadiboo

[Spaceboy Ross]

  On 10/2/2018 at 11:44 PM, Cadiboo said:

You should probably consider splitting up your client/common/server code more (this will probably crash on a dedicated server)

 

Also NEVER return a null itemstack. Return ItemStack.EMPTY.

`public ItemStack getRequiredItemToPilot() {

    return null;

}`

 

What exactly is going wrong with your model? How are you loading the model?

Expand  

I've fixed it so the function returns ItemStack.EMPTY since I recently found that out before you told me and the model is rendering from the MobileSuit.MSRenderer class. Also, I didn't make the model, the model designer member made it.

[Cadiboo]

Wait so is your problem solved? Cause if not...

  On 10/3/2018 at 12:18 AM, Cadiboo said:

Wait is it just the parts of the model with rotation that are rendering weirdly? If so I think that it might be something wrong with BlockBench’s model renderer OR the rotations/translations are being applied. Try toggling the checkbox inside BlockBench that says Origin To Geometry. Try making a smaller model with rotated pieces and also look at the JSON model text and see if the sizes look correct.

Expand  

 

[Spaceboy Ross]

It's only the head that doesn't render correctly, the head rendered correctly in blockbench and other programs.

[Animefan8888]

  On 10/3/2018 at 1:30 PM, Spaceboy Ross said:

It's only the head that doesn't render correctly, the head rendered correctly in blockbench and other programs.

Expand  

Find out which one of these method calls is adding the head box and then change the position that it is being placed at.

[Spaceboy Ross]

e23 is the head, I already found that out and changing the position does nothing.

[Cadiboo]

It looks to me as though the only things that are rendering wrong are the “horns” (which both have rotations applied to them) and the 2 “torso” parts that have rotation applied to them. Additionally I think your arms are being rendered wrongly (rotated an extra 90deg Y). Because all your variables are named “e1” or similar, I can’t really see which ones are which and what they correspond to in the actual json model.

Edit: I assume they’re e27 & e28, you might want to set the rotation point & the rotation before making the box?

Edited October 3, 2018 by Cadiboo

[Animefan8888]

  On 10/3/2018 at 11:19 PM, Cadiboo said:

I can’t really see which ones are which and what they correspond to in the actual json model.

Expand  

It's an entity there is no JSON model. This is a java model.

[Cadiboo]

  On 10/4/2018 at 12:29 AM, Animefan8888 said:

It's an entity there is no JSON model. This is a java model.

Expand  

Which has been created by first making a JSON model & then copying the values to Java? Or am I wrong and BlockBench can make Java models?

[Animefan8888]

  On 10/4/2018 at 1:01 AM, Cadiboo said:

Which has been created by first making a JSON model & then copying the values to Java?

Expand  

No, by the looks of it, it was made with Techne.

 

  On 10/4/2018 at 1:01 AM, Cadiboo said:

Or am I wrong and BlockBench can make Java models?

Expand  

It might be able to, haven't used BlockBench. Plus you don't know if the modeler used that program.

[Spaceboy Ross]

  On 10/4/2018 at 1:18 AM, Animefan8888 said:

No, by the looks of it, it was made with Techne.

 

It might be able to, haven't used BlockBench. Plus you don't know if the modeler used that program.

Expand  

Blockbench has an "export to java" plugin and that's how I got the model exported.

[Cadiboo]

  On 10/4/2018 at 2:31 PM, Spaceboy Ross said:

Blockbench has an "export to java" plugin and that's how I got the model exported.

Expand  

Interesting, I think that that plugin may not have been properly tested with rotated boxes and might not be outputting your boxes with rotations correctly. I think that you should rename all your variables to make the code readable, and try moving the calls to setRotationPoint and setRotateAngle around (maybe swap which one gets called first? maybe move them above the call to addBox?)

I think that when the model is rendered it’s getting scaled before rotated when it should be getting rotated before scaled (or visa versa).

 

  On 10/4/2018 at 1:18 AM, Animefan8888 said:

you don't know if the modeler used that program.

Expand  

[Spaceboy Ross]

The modeler uses Cubix Studio but he says that he cannot figure out how to export the model to java.