[SOLVED] applyBonemeal grass/flower in radius doesn't show in client

[viveleroi]

 

 

I've designed a custom bonemeal item, which onItemUse calls "applyBonemeal":

 

@Override
    public EnumActionResult onItemUse(EntityPlayer player, World worldIn, BlockPos pos, EnumHand hand, EnumFacing facing, float hitX, float hitY, float hitZ) {
        // Run only on logical server
        if (worldIn.isRemote) {
            return EnumActionResult.PASS;
        }

        // Copy the item so we give garbage to applyBonemeal - it does
        // things to the item damage we don't like
        ItemStack phantomBonemeal = player.getHeldItem(hand).copy();

        if (ItemDye.applyBonemeal(phantomBonemeal, worldIn, pos)) {
            player.getHeldItem(hand).damageItem(1, player);
        } else {
            player.sendMessage(new TextComponentTranslation("text.scroll.incorrect_poison"));

            // Curse them
            Curses.applyMinorPoisonCurse(player);
        }

        return EnumActionResult.FAIL;
    }

 

It works as intended, except when used on grass I've noticed that the client doesn't render all updated blocks. The clicked block updates fine (a grass/flower appears) but the grass/flowers which appear in a radius don't show up until I save and quit and re-open the game. 

 

I'm not sure if I've done something or there's an issue?

Edited December 14, 2018 by viveleroi
solved

[Draco18s]

  On 12/12/2018 at 10:58 PM, viveleroi said:

// Run only on logical server

Expand  

 

  On 12/12/2018 at 10:58 PM, viveleroi said:

the client doesn't render all updated blocks

Expand  

?

[viveleroi]

I thought that any world changes had to be made server-side and it would then update the client. The docs say "Applying game logic to the logical client can cause desynchronization issues" and running logic like this on both sides in another project lead to "doubling" of the all the logic which I was then directed to run on the logical server only.

 

The docs aren't clearly explaining why some things need to happen when the world isRemote. Clearly one block is sent to the client, but not the others? If I run this on the logical client too, how does the growth produce the same results?

[V0idWa1k3r]

  On 12/12/2018 at 10:58 PM, viveleroi said:

ItemDye.applyBonemeal(phantomBonemeal, worldIn, pos)

Expand  

Use the overload that takes additional parameters - the player and the hand.

Don't return a FAIL/PASS action result - you did something, so tell the game that something happened.

Apart from that your code seems fine. Bonemeal growth only happens on the server anyway. 

[desht]

  On 12/14/2018 at 1:31 AM, viveleroi said:

I thought that any world changes had to be made server-side and it would then update the client. The docs say "Applying game logic to the logical client can cause desynchronization issues" and running logic like this on both sides in another project lead to "doubling" of the all the logic which I was then directed to run on the logical server only.

 

The docs aren't clearly explaining why some things need to happen when the world isRemote. Clearly one block is sent to the client, but not the others? If I run this on the logical client too, how does the growth produce the same results?

Expand  

Often, when in doubt, the best bet is to consult the source and see how vanilla does it.  In this case, take a look atItemDye#onItemUse().  Looking at the code there, it appears that applyBonemeal() (the overload that V0idWa1k3r mentioned) gets called both on server and client.  Indeed, a perusal of ItemDye#applyBonemeal() shows some checks for server/client, so it's clearly intended to be called on both sides.

[viveleroi]

Taking out the check for world.isRemote doesn't solve this either. The code runs twice, both on the logical client and server but the grass/flowers grown don't appear except for the single block clicked. I'll have to study the original further, something is missing or I'm doing it wrong. Even just simplifying it, using the other recommended method, etc.

 

@Override
    public EnumActionResult onItemUse(EntityPlayer player, World worldIn, BlockPos pos, EnumHand hand, EnumFacing facing, float hitX, float hitY, float hitZ) {

        ItemDye.applyBonemeal(player.getHeldItem(hand), worldIn, pos, player, hand);
        
        return EnumActionResult.PASS;
    }

 

[Cadiboo]

  On 12/14/2018 at 7:22 AM, V0idWa1k3r said:

Don't return a FAIL/PASS action result - you did something, so tell the game that something happened.

Expand  

*SUCCESS*

[viveleroi]

I'm an idiot. Thanks for pointing out what I missed.