Jump to content

[SOLVED] [1.12.2] NBT UUID loading as 00000-000 or empty string and nether not saving


hiotewdew

Recommended Posts

I'm working on a claim system mod, and I'm using WorldSavedData to serialize the claims, including UUIDs of owners/members. However, I've run into an issue. When the data is saved, it saves with the proper UUID, confirmed by NBTExplorer.

image.png.ba1bf5e14d1151f7d893695623c43058.png

However upon loading the data, if I use UUIDs instead of strings I get 000000-00000-0000 as my UUID

and if I use strings and parse it into a UUID, I get an invalid string that causes a crash. (Presumably empty string or 00000-000-000)

See comment below.

The integer array loads properly and I've ensured everything is serverside.

Another issue I've run into is that the data from the nether isn't saved.

image.png.69014f443d0acbb8952b1c8d3d1d48d3.png

There's no dat file, even though I am using perWorldStorage.

 

Here's how my serializer works.

It starts in my event handler, which has the following events:

@SubscribeEvent
	public void onWorldLoad(WorldEvent.Load e) {
		if(!e.getWorld().isRemote) {
			ClaimManager.getManager().deserialize(e.getWorld());
		}
	}

	@SubscribeEvent
	public void onWorldSave(WorldEvent.Save e) {
		if(!e.getWorld().isRemote) {
			ClaimManager.getManager().serialize(e.getWorld());
		}
	}

Which both of the following fire properly and go to my ClaimManager (responsible for adding and removing claims from the official claims list)
These two methods are the beef of the bunch:

Spoiler

 


/** Forces a world to save claim data 
	 * @param world - The world to be saved **/
	public void serialize(World world) {
		if(!world.isRemote) {
			ClaimSerializer store = ClaimSerializer.get(world);
			for(ClaimArea claim : claims) {
				if(claim.getDimensionID() == world.provider.getDimension()) {
					int[] claimVals = claim.getSelfAsInt();
					UUID owner = claim.getOwner();
					UUID ownerOffline = claim.getOwnerOffline();
					String serialName = claim.getSerialName();
					NBTTagCompound data = new NBTTagCompound();
					data.setIntArray("CLAIMINFO", claimVals);
					data.setString("OWNERUID", owner.toString());
					data.setString("OWNERUIDOFF", ownerOffline.toString());
					System.out.println("Owner: " + owner);
					for(EnumPerm perm : EnumPerm.values()) {
						NBTTagCompound members = new NBTTagCompound();
						for(UUID member : claim.getArrayForPermission(perm)) {
							members.setString("MEMBER_" + member.toString(), member.toString());
						}
						data.setTag("MEMBERS_" + perm.name(), members);
					}
					store.data.setTag("CLAIM_" + serialName, data);
					store.markDirty();
					System.out.println("Saving claim: " + serialName);
				}
			}
		}
	}

	/** Forces a world to load claim data. 
	 * Overwrites new claim data since last load!
	 * @param world - The world to be saved **/
	public void deserialize(World world) {
		if(!world.isRemote) {
			ClaimSerializer store = ClaimSerializer.get(world);
			NBTTagCompound comp = store.data;
			if(comp != null ) {
				for(String key : comp.getKeySet()) {
					System.out.println("Loading " + key);
					NBTTagCompound data = comp.getCompoundTag(key);
					int[] claimVals = data.getIntArray("CLAIMINFO");
					UUID owner = UUID.fromString(comp.getString("OWNERUID"));
					UUID ownerOffline = UUID.fromString(comp.getString("OWNERUIDOFF"));
					System.out.println("Owner: " + owner);
					if(claimVals.length > 0 && claimVals[0] == 0 && claimVals[1] == world.provider.getDimension()) {
						System.out.println("Valid version.");
						ClaimArea claim = new ClaimArea(claimVals[1], claimVals[2], claimVals[3], claimVals[4], claimVals[5], owner, ownerOffline);
						for(String key2 : data.getKeySet()) {
							if(key2.startsWith("MEMBERS_")) {
								NBTTagCompound members = data.getCompoundTag(key2);
								for(String key3 : members.getKeySet()) {
									if(key3.startsWith("MEMBER_")) {
										UUID member = UUID.fromString(members.getString(key3));
										claim.addMember(EnumPerm.valueOf(key2.replaceAll("MEMBERS_", "")), member);
									}
								}
							}
						}
						this.addClaim(claim);
					} else {
						ClaimIt.logger.log(Level.FATAL, "Detected version that doesn't exist yet! Mod was downgraded? Claim cannot be loaded.");
					}
				}
			}
		}
	}

 

This is my actual WorldSavedData (ClaimSerializer):

public class ClaimSerializer extends WorldSavedData {
	private static final String DATA_NAME = Ref.MOD_ID + "_ClaimsData";
	public NBTTagCompound data = new NBTTagCompound();
	
	public ClaimSerializer() {
		super(DATA_NAME);
	}
	
	public ClaimSerializer(String s) {
		super(s);
	}
	
	@Override
	public void readFromNBT(NBTTagCompound nbt) {
		data = nbt;
	}
	@Override
	public NBTTagCompound writeToNBT(NBTTagCompound compound) {
		compound = data;
		return compound;
	}
	
	public static ClaimSerializer get(World world) {
		ClaimSerializer save = (ClaimSerializer) world.getPerWorldStorage().getOrLoadData(ClaimSerializer.class, DATA_NAME);
		if(save == null) {
			save = new ClaimSerializer();
			world.getMapStorage().setData(DATA_NAME, save);
		}
		return save;
	}
}

 

As you can see, it uses getPerWorldStorage, and is provided the world instance from the original event to return a storage, but for some reason nothing is saved to the nether. I've tested this on both a server and singleplayer. It always loads as an empty UUID and doesn't save nether info. The UUID issue only happens when the game is exited and started. Any ideas?

 

For more context, my source: https://github.com/itsmeow/ClaimIt/tree/master/src/main/java/its_meow/claimit

Edited by hiotewdew
Mark as solved
Link to comment
Share on other sites

Nevermind on the UUID issue. I am doing comp.getString() which is not the same as data.getString(). But the nether issue still stands.

Link to comment
Share on other sites

18 hours ago, V0idWa1k3r said:

Why are you using WorldSavedData? AFAIK that's one per minecraft save file. If you want one per dimension use capabilities.

A world capability is just a wrapper around a WorldSavedData anyways.

VANILLA MINECRAFT CLASSES ARE THE BEST RESOURCES WHEN MODDING

I will be posting 1.15.2 modding tutorials on this channel. If you want to be notified of it do the normal YouTube stuff like subscribing, ect.

Forge and vanilla BlockState generator.

Link to comment
Share on other sites

Figured it out. My get method uses both getMapStorage and getPerWorldStorage.

public static ClaimSerializer get(World world) {
  // PER WORLD STORAGE
		ClaimSerializer save = (ClaimSerializer) world.getPerWorldStorage().getOrLoadData(ClaimSerializer.class, DATA_NAME);
		if(save == null) {
			save = new ClaimSerializer();
          // MAP STORAGE!
			world.getMapStorage().setData(DATA_NAME, save); 
		}
		return save;
	}
Link to comment
Share on other sites

Join the conversation

You can post now and register later. If you have an account, sign in now to post with your account.
Note: Your post will require moderator approval before it will be visible.

Guest
Unfortunately, your content contains terms that we do not allow. Please edit your content to remove the highlighted words below.
Reply to this topic...

×   Pasted as rich text.   Restore formatting

  Only 75 emoji are allowed.

×   Your link has been automatically embedded.   Display as a link instead

×   Your previous content has been restored.   Clear editor

×   You cannot paste images directly. Upload or insert images from URL.



  • Recently Browsing

    • No registered users viewing this page.
  • Posts

    • Hello all! I'm currently trying to make the Biomes o' Plenty mod (1.12.2 version) compatible with my shaderpack (BSL v8.5). Even after I've already inserted a "shaders" folder with a correctly-formatted blocks.PROPERTIES file within the assets folder of the .jar, it still does not wave the textures from the mod. I definitely thought this was going to work since I noticed the 1.19.2 version of the mod laid it out exactly like that and it worked perfectly when my PC was able to run 1.19.2 Forge... ^^;;; Could there be some missing link I'm not getting at here?
    • After much experimentation I finally realised why this doesn't work and how to fix it. The critical component to understand here, is that ItemCraftedEvent is called before the crafting ingredients are purged from the crafting slots; this all happens in ResultSlot.java's onTake method: We can see here the first line fires checkTakeAchievements, this is what fires the ItemCraftedEvent (after a few method calls). Then we can see the purge behaviour. I worked around this by creating a CarverItem class, which uses hasCraftingRemainingItem and getCraftingRemainingItem to hook into ResultSlot.onTake: Now, I reconstruct my ItemCraftedEvent handler, and using some smart tags (which I omit for brevity), I handle two cases: 1. When crafting a carved item, I damage the tool used in the recipe 2. When crafting a carving tool from a repair recipe, I manually purge the input tools as with the new CarverItem class, as otherwise items would be duplicated   This has now greatly improved implementation, beyond my expectations, for the standard crafting table and the user's inventory crafting grid. A user can now click or shift-click 'carve' items, with no duplication or issues that I have spotted so far.  
    • Hi, I'm having issues launching my Forge 1.20.1 installation (47.2.0). I keep getting error code 1, and all the logs abruptly pause with the game attempting to open GL 4.6. Latest Crash: https://pastebin.com/zsP5Wipk Debug (No idea what the real name is) Log: https://pastebin.com/CzvqhNq0   Thanks for the help!
    • In the most up to date version of Allthemods 6 (v1.9.2) the stoned bee is not able to be interacted with apart from putting it into an empty bee jar. I can't breed the bee or put it into my aviary breeder. When I try to put it into the breeder it says import unsuccessful. The stoned bee is one of the most important bees for advancing in the mod so it is rather unfortunate that it is not working as intended.
    • Everytime I try to run the Forge 1.20.1 - 47.1.0 Installer, only appears an a black window and then closes. I don't appear the installing menu anymore.
  • Topics

  • Who's Online (See full list)

×
×
  • Create New...

Important Information

By using this site, you agree to our Terms of Use.