hiotewdew Posted December 19, 2018 Share Posted December 19, 2018 (edited) I'm working on a claim system mod, and I'm using WorldSavedData to serialize the claims, including UUIDs of owners/members. However, I've run into an issue. When the data is saved, it saves with the proper UUID, confirmed by NBTExplorer. However upon loading the data, if I use UUIDs instead of strings I get 000000-00000-0000 as my UUID and if I use strings and parse it into a UUID, I get an invalid string that causes a crash. (Presumably empty string or 00000-000-000) See comment below. The integer array loads properly and I've ensured everything is serverside. Another issue I've run into is that the data from the nether isn't saved. There's no dat file, even though I am using perWorldStorage. Here's how my serializer works. It starts in my event handler, which has the following events: @SubscribeEvent public void onWorldLoad(WorldEvent.Load e) { if(!e.getWorld().isRemote) { ClaimManager.getManager().deserialize(e.getWorld()); } } @SubscribeEvent public void onWorldSave(WorldEvent.Save e) { if(!e.getWorld().isRemote) { ClaimManager.getManager().serialize(e.getWorld()); } } Which both of the following fire properly and go to my ClaimManager (responsible for adding and removing claims from the official claims list) These two methods are the beef of the bunch: Spoiler /** Forces a world to save claim data * @param world - The world to be saved **/ public void serialize(World world) { if(!world.isRemote) { ClaimSerializer store = ClaimSerializer.get(world); for(ClaimArea claim : claims) { if(claim.getDimensionID() == world.provider.getDimension()) { int[] claimVals = claim.getSelfAsInt(); UUID owner = claim.getOwner(); UUID ownerOffline = claim.getOwnerOffline(); String serialName = claim.getSerialName(); NBTTagCompound data = new NBTTagCompound(); data.setIntArray("CLAIMINFO", claimVals); data.setString("OWNERUID", owner.toString()); data.setString("OWNERUIDOFF", ownerOffline.toString()); System.out.println("Owner: " + owner); for(EnumPerm perm : EnumPerm.values()) { NBTTagCompound members = new NBTTagCompound(); for(UUID member : claim.getArrayForPermission(perm)) { members.setString("MEMBER_" + member.toString(), member.toString()); } data.setTag("MEMBERS_" + perm.name(), members); } store.data.setTag("CLAIM_" + serialName, data); store.markDirty(); System.out.println("Saving claim: " + serialName); } } } } /** Forces a world to load claim data. * Overwrites new claim data since last load! * @param world - The world to be saved **/ public void deserialize(World world) { if(!world.isRemote) { ClaimSerializer store = ClaimSerializer.get(world); NBTTagCompound comp = store.data; if(comp != null ) { for(String key : comp.getKeySet()) { System.out.println("Loading " + key); NBTTagCompound data = comp.getCompoundTag(key); int[] claimVals = data.getIntArray("CLAIMINFO"); UUID owner = UUID.fromString(comp.getString("OWNERUID")); UUID ownerOffline = UUID.fromString(comp.getString("OWNERUIDOFF")); System.out.println("Owner: " + owner); if(claimVals.length > 0 && claimVals[0] == 0 && claimVals[1] == world.provider.getDimension()) { System.out.println("Valid version."); ClaimArea claim = new ClaimArea(claimVals[1], claimVals[2], claimVals[3], claimVals[4], claimVals[5], owner, ownerOffline); for(String key2 : data.getKeySet()) { if(key2.startsWith("MEMBERS_")) { NBTTagCompound members = data.getCompoundTag(key2); for(String key3 : members.getKeySet()) { if(key3.startsWith("MEMBER_")) { UUID member = UUID.fromString(members.getString(key3)); claim.addMember(EnumPerm.valueOf(key2.replaceAll("MEMBERS_", "")), member); } } } } this.addClaim(claim); } else { ClaimIt.logger.log(Level.FATAL, "Detected version that doesn't exist yet! Mod was downgraded? Claim cannot be loaded."); } } } } } This is my actual WorldSavedData (ClaimSerializer): public class ClaimSerializer extends WorldSavedData { private static final String DATA_NAME = Ref.MOD_ID + "_ClaimsData"; public NBTTagCompound data = new NBTTagCompound(); public ClaimSerializer() { super(DATA_NAME); } public ClaimSerializer(String s) { super(s); } @Override public void readFromNBT(NBTTagCompound nbt) { data = nbt; } @Override public NBTTagCompound writeToNBT(NBTTagCompound compound) { compound = data; return compound; } public static ClaimSerializer get(World world) { ClaimSerializer save = (ClaimSerializer) world.getPerWorldStorage().getOrLoadData(ClaimSerializer.class, DATA_NAME); if(save == null) { save = new ClaimSerializer(); world.getMapStorage().setData(DATA_NAME, save); } return save; } } As you can see, it uses getPerWorldStorage, and is provided the world instance from the original event to return a storage, but for some reason nothing is saved to the nether. I've tested this on both a server and singleplayer. It always loads as an empty UUID and doesn't save nether info. The UUID issue only happens when the game is exited and started. Any ideas? For more context, my source: https://github.com/itsmeow/ClaimIt/tree/master/src/main/java/its_meow/claimit Edited December 20, 2018 by hiotewdew Mark as solved Quote All Projects found here: Website Main Programmer for: Better Animals Plus, Better Animal Models Created independently: QuickHomes, ClaimIt, ClaimIt API, CloneLand, DerpCats, QuickTeleports, QuickSpawns, MCMusicPlayer, MCDevDate, [SBM] Fluid Gun, OpenScreens Work on/Contribute to: Bewitchment Commissioned for: [SBM] Breadstone, [SBM] Infinite Falling, [SBM] Dead Man's Satchel, [SBM] Handheld Piston Link to comment Share on other sites More sharing options...
hiotewdew Posted December 19, 2018 Author Share Posted December 19, 2018 Nevermind on the UUID issue. I am doing comp.getString() which is not the same as data.getString(). But the nether issue still stands. Quote All Projects found here: Website Main Programmer for: Better Animals Plus, Better Animal Models Created independently: QuickHomes, ClaimIt, ClaimIt API, CloneLand, DerpCats, QuickTeleports, QuickSpawns, MCMusicPlayer, MCDevDate, [SBM] Fluid Gun, OpenScreens Work on/Contribute to: Bewitchment Commissioned for: [SBM] Breadstone, [SBM] Infinite Falling, [SBM] Dead Man's Satchel, [SBM] Handheld Piston Link to comment Share on other sites More sharing options...
V0idWa1k3r Posted December 19, 2018 Share Posted December 19, 2018 Why are you using WorldSavedData? AFAIK that's one per minecraft save file. If you want one per dimension use capabilities. Quote Link to comment Share on other sites More sharing options...
Animefan8888 Posted December 20, 2018 Share Posted December 20, 2018 18 hours ago, V0idWa1k3r said: Why are you using WorldSavedData? AFAIK that's one per minecraft save file. If you want one per dimension use capabilities. A world capability is just a wrapper around a WorldSavedData anyways. Quote VANILLA MINECRAFT CLASSES ARE THE BEST RESOURCES WHEN MODDING I will be posting 1.15.2 modding tutorials on this channel. If you want to be notified of it do the normal YouTube stuff like subscribing, ect. Forge and vanilla BlockState generator. Link to comment Share on other sites More sharing options...
hiotewdew Posted December 20, 2018 Author Share Posted December 20, 2018 Figured it out. My get method uses both getMapStorage and getPerWorldStorage. public static ClaimSerializer get(World world) { // PER WORLD STORAGE ClaimSerializer save = (ClaimSerializer) world.getPerWorldStorage().getOrLoadData(ClaimSerializer.class, DATA_NAME); if(save == null) { save = new ClaimSerializer(); // MAP STORAGE! world.getMapStorage().setData(DATA_NAME, save); } return save; } Quote All Projects found here: Website Main Programmer for: Better Animals Plus, Better Animal Models Created independently: QuickHomes, ClaimIt, ClaimIt API, CloneLand, DerpCats, QuickTeleports, QuickSpawns, MCMusicPlayer, MCDevDate, [SBM] Fluid Gun, OpenScreens Work on/Contribute to: Bewitchment Commissioned for: [SBM] Breadstone, [SBM] Infinite Falling, [SBM] Dead Man's Satchel, [SBM] Handheld Piston Link to comment Share on other sites More sharing options...
Recommended Posts
Join the conversation
You can post now and register later. If you have an account, sign in now to post with your account.
Note: Your post will require moderator approval before it will be visible.