Right Click Heal With Item

[Justin_Perry]

I am trying to have my item heal when the player right clicks with it out. How should I go about this? Thank you. I realize I know how to increase the health, add a cooldown, I'm familiar with getting health, setting health. I would use itemInteractionForEntity however, I do not know how to heal without interacting with an entity which may be compromising in an intense fight. 

Edited March 27, 2019 by Justin_Perry

[DavidM]

Item#onItemUse.

[Justin_Perry]

21 minutes ago, DavidM said:

Item#onItemUse.

public class stimSelf extends Item implements IHasModel {
	
public stimSelf(String name) {
		
		setUnlocalizedName(name);
		setRegistryName(name);
		setCreativeTab(CreativeTabs.MISC);
		modItems.ITEMS.add(this);
	}
	
	@Override
	public void registerModels() {
		Main.proxy.registerItemRenderer(this, 0, "inventory");
	}
	
	@Override
	public ActionResult<ItemStack> onItemUse(ItemStack itemStack, World world, EntityPlayer player) {
		
		if (player.getHealth() < player.getMaxHealth()) {
			System.out.println("We healed.");
			player.setHealth(player.getHealth() + 5.0F);
			player.getCooldownTracker().setCooldown(modItems.STIM_SELF, 300);
		}else {
			System.out.println("We have not healed.");
		}
		
		return null;
	}
}

 

I have no output. Can you help?

 

Warning: The method onItemUse(ItemStack, World, EntityPlayer) of type stimSelf must override or implement a supertype method.

 

Thank you.

[Keitaro]

4 minutes ago, Justin_Perry said:

Warning: The method onItemUse(ItemStack, World, EntityPlayer) of type stimSelf must override or implement a supertype method. 

It usually means your signature doesn't match with the function you are overriding.

As a result your function doesn't get called at all.

 

Also i think your return value should be FAILED or SUCCESS.

I am not sure at the moment, look at what the parents function does.

[Justin_Perry]

17 minutes ago, Keitaro said:

It usually means your signature doesn't match with the function you are overriding.

As a result your function doesn't get called at all.

 

Also i think your return value should be FAILED or SUCCESS.

I am not sure at the moment, look at what the parents function does.

Not very helpful.

[DavidM]

3 minutes ago, Justin_Perry said:

Not very helpful.

... He literally just told you what is problem is and how to fix it.

 

Like what Keitaro said:

21 minutes ago, Keitaro said:

It usually means your signature doesn't match with the function you are overriding.

As a result your function doesn't get called at all.

, check your parameters. An overriding method must have the same parameters as the method it is overriding.

Edited March 28, 2019 by DavidM

[Justin_Perry]

Just now, DavidM said:

... He literally just told you what is problem is and how to fix it.

 

Check your parameters. An overriding method must have the same parameters as the method it is overriding.

Something that may be easy for you to understand and interpret can be hard for others. I have checked my parameters. 

public class stimSelf extends Item implements IHasModel {
	
public stimSelf(String name) {
		
		setUnlocalizedName(name);
		setRegistryName(name);
		setCreativeTab(CreativeTabs.MISC);
		modItems.ITEMS.add(this);
	}
	
	@Override
	public void registerModels() {
		Main.proxy.registerItemRenderer(this, 0, "inventory");
	}
	
	@Override
	public ActionResult<ItemStack> onItemUse(ItemStack stack, EntityPlayer player, World world, int x, int y, int z, int par7, float xFloat, float yFloat, float zFloat) {
		
		if (player.getHealth() < player.getMaxHealth()) {
			System.out.println("We healed.");
			player.setHealth(player.getHealth() + 5.0F);
			player.getCooldownTracker().setCooldown(modItems.STIM_SELF, 300);
			return new ActionResult<ItemStack>(EnumActionResult.SUCCESS, stack);
		}else {
			System.out.println("We have not healed.");
			return new ActionResult<ItemStack>(EnumActionResult.FAIL, stack);
		}
		
	
	}
}

You tell me.

[DavidM]

46 minutes ago, Justin_Perry said:

Something that may be easy for you to understand and interpret can be hard for others

"Overriding" is basic java knowledge; you are expected to know it according to the forum rules.

 

46 minutes ago, Justin_Perry said:

You tell me.

Since you did not specify the version of Minecraft you are modding for, I'm going to assume it's 1.12.2.

Item#onItemUse is defined as:

public EnumActionResult onItemUse (EntityPlayer player, World world, BlockPos pos, EnumHand hand, EnumFacing facing, float hitX, float hitY, float hitZ)

Well as you can see:

• "EnumActionResult" is not spelt "ActionResult<ItemStack>"
• "EntityPlayer" is not spelt "ItemStack"
• "BlockPos" is not spelt "int"

Therefore, you are creating a new method instead of overriding an existing one.

 

As a general suggestion, you should always use your IDE to do the overriding for you instead of manually typing it out.

Edited March 28, 2019 by DavidM

[Justin_Perry]

4 minutes ago, DavidM said:

"Overriding" is basic java knowledge; you are expected to know it according to the forum rules.

 

Since you did not specify the version of Minecraft you are modding for, I'm going to assume it's 1.12.2.

Item#onItemUse is defined as:

public EnumActionResult onItemUse (EntityPlayer player, World world, BlockPos pos, EnumHand hand, EnumFacing facing, float hitX, float hitY, float hitZ)

Well as you can see:

• "EnumActionResult" is not spelt "ActionResult<ItemStack>"
• "EntityPlayer" is not spelt "ItemStack"
• "BlockPos" is not spelt "int"

As a general suggestion, you should always use your IDE to do the overriding for you instead of manually typing it out.

Alright, thank you for nothing. I will figure everything else I'll need to make this mod by myself or by reading. Thanks

[DavidM]

2 minutes ago, Justin_Perry said:

Alright, thank you for nothing. I will figure everything else I'll need to make this mod by myself or by reading. Thanks

You won't get far without the understanding of basic java.

As a general suggestion, learn java before making a mod.

Edited March 28, 2019 by DavidM

[Justin_Perry]

Just now, DavidM said:

I doubt you will get anywhere without the understanding of basic java.

As a general suggestion, learn java before making a mod.

I would rather have a lesser understanding of java on my own than continue to be ridiculed. I searched high and low on information on onItemUse, while your eventual solution may have worked, you have made me really discouraged from asking for more help. I haven't learned everything in Java, no. But I do know how to make classes, variables, functions, and a bit more. Again, I appreciate your help, but you are not a nice person. Please refrain from talking to me anymore.

[DaemonUmbra]

Telling you that we expect you to have a working knowledge of the language you are using is not ridicule.

If Java is the first programming language you are learning, I'm afraid learning through Minecraft modding is about the worst way to go about it, please see if you can take an online course or something.

[Justin_Perry]

1 minute ago, DaemonUmbra said:

Telling you that we expect you to have a working knowledge of the language you are using is not ridicule.

If Java is the first programming language you are learning, I'm afraid learning through Minecraft modding is about the worst way to go about it, please see if you can take an online course or something.

Telling me I don't know how to override is a complete insult. I have at least an item that heals others. I obviously had to override to do that. The issue is mostly the lack of forge documentation for low-level modders to look into. I have learned Python, taken C++ courses, and learned a moderate amount of Java.

[DaemonUmbra]

Where did you get the method/function signature for onItemUse, did you copy it from a tutorial or from the base/super class?

[Justin_Perry]

3 minutes ago, DaemonUmbra said:

Where did you get the method/function signature for onItemUse, did you copy it from a tutorial or from the base/super class?

I was googling what other people used to execute a function when an item was right clicked. I found some old information and tried to incorporate it in 1.12. Apparently, it did not work. I found a youtube video that used the ActionResult<ItemStack> other than that, I was at a loss. I found no information that would have lead me to EnumActionResult. I have since implemented what DavidM suggested and it works. 

[DaemonUmbra]

You looked at random people's code for answers before looking at the class you were extending?

[Justin_Perry]

1 minute ago, DaemonUmbra said:

You looked at random people's code for answers before looking at the class you were extending?

I was looking at how to use onItemUse, nothing more.

[DaemonUmbra]

And you chose to not look directly at the class and method you were overriding for the method signature, then got confused when you got the error that your override didn't work.

[DavidM]

1.

1 hour ago, Justin_Perry said:

Telling me I don't know how to override is a complete insult. I have at least an item that heals others. I obviously had to override to do that.

3 hours ago, Justin_Perry said:

I have no output. Can you help?

 

Warning: The method onItemUse(ItemStack, World, EntityPlayer) of type stimSelf must override or implement a supertype method.

Your problem is caused by not (fully) knowing how overriding works, or else this error won’t occur.

The IDE is telling you "hey this method does not exist in the parent class", therefore you should make sure your method matches the method in the superclass.

 

2. Always look at the source code first, as the source code is definitely updated and functional, whereas answers on the internet can be old and not fitted to use in the current version.

Edited March 28, 2019 by DavidM

[Justin_Perry]

Alright, I give up on modding, thanks guys.

[Cadiboo]

If you know about

On 3/28/2019 at 12:11 PM, Justin_Perry said:

functions

you should really, really already know about overriding. Unless you meant methods, in which case overriding should probably be the next thing you learn.

[DiamondMiner88]

On 3/27/2019 at 6:35 PM, Justin_Perry said:

Telling me I don't know how to override is a complete insult.

We have 4 people so far telling you that you should know how to override. All of them are more experienced than you at java from what we've seen so far. If you don't want to learn the java, we are no help to you until you know at least the basics.

On 3/27/2019 at 5:03 PM, Justin_Perry said:

Not very helpful.

 

On 3/27/2019 at 5:06 PM, DavidM said:

... He literally just told you what is problem is and how to fix it.

The post could have been ended right then and there if you knew how to override.