Does this World gen look ok?

[AssassinHero]

I am making ore to generate into the overworld and some in the end and nether

 

I have put the three that spawn in the overworld into the code now

 

I am just wondering if this looks ok

 

package assassinhero.parallelworlds.common;

import java.util.Random;

import assassinhero.parallelworlds.ParallelWorlds;

import net.minecraft.world.World;
import net.minecraft.world.chunk.IChunkProvider;
import net.minecraft.world.gen.feature.WorldGenMinable;
import cpw.mods.fml.common.IWorldGenerator;

public class WorldGenerator implements IWorldGenerator{

@Override
public void generate(Random random, int chunkX, int chunkZ, World world,
		IChunkProvider chunkGenerator, IChunkProvider chunkProvider) {
	switch (world.provider.dimensionId){
	case -1:
		generateNether(world, random, chunkX * 16, chunkZ * 16);
		break;
	case 0:
		generateSurface(world, random, chunkX * 16, chunkZ * 16);
		break;
	case 1:
		generateEnd(world, random, chunkX * 16, chunkZ * 16);

	}

}

private void generateEnd(World world, Random random, int i, int j) {


}

private void generateSurface(World world, Random random, int i, int j) {
	for(int k = 0; k < 10; k++){
		int NightOreXCoord = i + random.nextInt(16);
		int NightOreYCoord = random.nextInt(25);
		int NightOreZCoord = j + random.nextInt(16);

		(new WorldGenMinable(ParallelWorlds.NightOre.blockID, 5)).generate(world, random, NightOreXCoord, NightOreYCoord, NightOreZCoord);

	}

	for(int l = 0; l < 10; l++){
		int TimeOreXCoord = i + random.nextInt(16);
		int TimeOreYCoord = random.nextInt(15);
		int TimeOreZCoord = j + random.nextInt(16);

		(new WorldGenMinable(ParallelWorlds.TimeOre.blockID, 4)).generate(world, random, TimeOreXCoord, TimeOreYCoord, TimeOreZCoord);
	}

	for(int m = 0; m < 10; m++){
		int HeavenlyOreXCoord = i + random.nextInt(16);
		int HeavenlyOreYCoord = random.nextInt(30);
		int HeavenlyOreZCoord = j + random.nextInt(16);

		(new WorldGenMinable(ParallelWorlds.HeavenlyOre.blockID, 5)).generate(world, random, HeavenlyOreXCoord, HeavenlyOreYCoord, HeavenlyOreZCoord);

	}




}

[Draco18s]

What does WorldGenMinable do?

[AssassinHero]

What does WorldGenMinable do?

 

I believe it makes the blocks become an 'ore' as such

[Draco18s]

Oh, a vanilla class.

 

*Peers at it*

 

That looks like it should work.  But only for the overworld  WorldGenMinable's generate calls block.isGenMineableReplaceable which will only return true for smooth stone.

 

Don't even ask me why it takes a world, x, y, and z parameters, it doesn't use them.  No really:

 

public boolean isGenMineableReplaceable(World world, int x, int y, int z)
    {
        return blockID == stone.blockID;
    }

[Mazetar]

Don't even ask me why it takes a world, x, y, and z parameters, it doesn't use them.  No really:

 

public boolean isGenMineableReplaceable(World world, int x, int y, int z)
    {
        return blockID == stone.blockID;
    }

 

Beacuse it's possible to override it. And then the world etc. come inn handy.

[Draco18s]

Beacuse it's possible to override it. And then the world etc. come inn handy.

 

What I mean is, I don't know why the coordinates of the block are relevant.

 

I mean, we already did this: Block block = Block.blocksList[par1World.getBlockId(var38, var41, var44)];

 

So we're already looking at the block that we want to replace, why would we want that block's mine-ability to be based on...not itself?