Removing Vanilla Stuff???

[perigrine3]

THANK YOU! 

[perigrine3]

Could I use that to disable recipes too?

[DavidM]

52 minutes ago, perigrine3 said:

Could I use that to disable recipes too?

Yes. Do something similar to that. (that was terribly explained, sorry)

 

I meant you should do something logically similar: iterate through the list of recipes and remove the recipe if it matches certain criteria.

Edited April 27, 2019 by DavidM

[perigrine3]

So I found this online (for removing RECIPES): 

     @SubscribeEvent
     public static void registerRecipes(RegistryEvent.Register<IRecipe> event) {
          ResourceLocation theButton = new ResourceLocation("minecraft:wooden_button");
          IForgeRegistryModifiable modRegistry = (IForgeRegistryModifiable) event.getRegistry();
          modRegistry.remove(theButton);
     }

And using your code, nov4e (for removing ITEMS associated with Minecraft): 

     @SubscribeEvent
     public void hideCreativeItems(FMLPostInitializationEvent event) {
          for(Item item : ForgeRegistries.ITEMS) {
               if(item.getCreatorModId(new ItemStack(item)).equals("minecraft")) {
                    item.setCreativeTab(null);
               }
          }
     }

I created this: 

     @SubscribeEvent
     public void removeRecipes(RegistryEvent.Register<IRecipe> event) {
          for(IRecipe recipe : ForgeRegistries.RECIPIES) {
               if(recipe.getCreatorModId(new ResourceLocation(recipe)).equals("minecraft")) {
                    modRegistry.remove(recipe);
               }
          }
     }

 

I figured if I made a variable for the recipe, it would work for all of them, especially if I used nov4e's code to make it apply only to items in vanilla Minecraft, but instead of items, recipes. I assumed because both are part of the ForgeRegistries, it could be applied similarly to both. It's very likely that I'm off, but I feel like I can't be TOO far off. 

 

I'm still new to coding java and I'm only using prior coding knowledge to guess my way through my problems, but I am trying, and I do understand what a good portion of this code means, it's only some parts I don't understand, and the big words make it difficult. 

Edited April 27, 2019 by perigrine3

[DavidM]

Don't put it in the IRecipe registry event; put it in something like the post init instead.

Edited April 27, 2019 by DavidM

[Cadiboo]

On 4/27/2019 at 1:08 AM, nov4e said:

You can just hide every item doing:

for(Item i : ForgeRegistries.ITEMS) {
	if(i.getCreatorModId(new ItemStack(i)).equals("minecraft")) {
				i.setCreativeTab(null);
	}
}

That means for every item in forge, if the item has the modid "minecraft" it will set the item's creative tab to null.

Use Item.getRegistryName().getDomain().equals(modid) instead.

[perigrine3]

But won't that get stuff that ISN'T vanilla too? I mean, I'm probably wrong cuz I'm a noob, but still, just want to check before I use it. 

[perigrine3]

I know what the code does though, just so nobody thinks I have no clue. I just don't know what the modid part is. 

Edited April 28, 2019 by perigrine3

[DavidM]

2 hours ago, perigrine3 said:

I know what the code does though, just so nobody thinks I have no clue. I just don't know what the modid part is. 

That is for checking whether the item's domain is equal to something...

The method names should be pretty self-explanatory.

[nov4e]

4 hours ago, perigrine3 said:

I know what the code does though, just so nobody thinks I have no clue. I just don't know what the modid part is. 

Well, when you execute the command /give in game, you need to put "minecraft:the_item_you_want" right? Well, forge consider minecraft as a mod so the minecraft modid is simply "minecraft".

[perigrine3]

Okay, that makes sense. 

[perigrine3]

This doesn't appear to be working, but I don't know why: 

//Removes existing recipes// 
     @SubscribeEvent 
     public void removeRecipes(FMLPostInitializationEvent event) {
          for(IRecipe recipe : ForgeRegistries.RECIPIES && Item item : ForgeRegistries.ITEMS) {
               if(recipe.getCraftingResult(new ResourceLocation(item)).equals("minecraft")) {
                    IForgeRegistryModifiable.remove(recipe);
                    
               }
          }
     }

I don't see why it is wrong. Before, I hadn't put in the && Item item : ForgeRegistries.ITEMS, but now that I have it, ResourceLocation can work correctly, using the getCraftingResult method to get the item, and then connect it with ForgeRegistries, but it doesn't seem to be working. 

What could it be? 

[DavidM]

The iterable of items is not necessarily in the same order as the iterable of recipes. In fact, they might not even be the same size.

I don't see why you need to iterate through the items; just go through all the recipes and remove them if the result match a certain criteria.

 

Is that even going to compile though? I've never seen such syntax before.

Edited April 29, 2019 by DavidM

[Draco18s]

19 hours ago, perigrine3 said:

if(recipe.getCraftingResult(new ResourceLocation(item)).equals("minecraft")) {

"Get the crafting result, is that object equal to the string 'minecraft'?"

 

Almost certainly not.