Jump to content

Recommended Posts

Posted

My game crashes by using shift click in my custom container, is there a way to fix that? i readed about @Override the transferStackinslot but i cant fint that anymore, maybe its gotten removed or got an other name?

Posted

Post your code and crash.

Some tips:

  Reveal hidden contents

 

Posted
  On 5/15/2019 at 11:18 PM, DavidM said:

and

Expand  

Funny thing is there is no crash and are nor errors, its seems to do an infinity loop or something but idk why, i heard you need to override transferstack or something but i have no plan how to use that. Can you see the minecraft workbench transferstack?

Posted

Post your code then.

Some tips:

  Reveal hidden contents

 

Posted
  On 5/16/2019 at 11:08 AM, DavidM said:

Post your code

Expand  

 

About Me

  Reveal hidden contents

Versions below 1.14.4 are no longer supported on this forum. Use the latest version to receive support.

When asking support remember to include all relevant log files (logs are found in .minecraft/logs/), code if applicable and screenshots if possible.

Only download mods from trusted sites like CurseForge (minecraft.curseforge.com). A list of bad sites can be found here, with more information available at stopmodreposts.org

Edit your own signature at www.minecraftforge.net/forum/settings/signature/ (Make sure to check its compatibility with the Dark Theme)

Posted

If you just extend Container then you need to override Container#transferStackInSlot, as you've said yourself.

  On 5/15/2019 at 8:53 PM, Schleim_time said:

i cant fint that anymore

Expand  

It's still very much there on my end, so I don't know what your issue here is. Afaik the method didn't get renamed.

 

 

  • Thanks 1
Posted
  On 5/16/2019 at 1:58 PM, V0idWa1k3r said:

as

Expand  

Ok i found out how to use that, i have to use that in the container bit o dont understand the syntax of that because its returning an itemstack, why will it still crash on return null instead of doing nothing on shift? Shift isnt important for me, so is it easy to only make that it return nothing? Or what can i do in there? Return an itemstack is weird :/ i also tried return air but it still crashes instead of replacing the slot with air

Posted (edited)
  On 5/16/2019 at 4:01 PM, Schleim_time said:

Ok i found out how to use that, i have to use that in the container bit o dont understand the syntax of that because its returning an itemstack, why will it still crash on return null instead of doing nothing on shift?

Expand  

ItemStacks cannot be null. They cannot be null because a stack of size zero is empty and should be treated as a non-existent stack. 

  Quote

Shift isnt important for me, so is it easy to only make that it return nothing? Or what can i do in there? Return an itemstack is weird :/ i also tried return air but it still crashes instead of replacing the slot with air

Expand  

This is why ItemStack.EMPTY exists. 

Edited by Draco18s

Apparently I'm a complete and utter jerk and come to this forum just like to make fun of people, be confrontational, and make your personal life miserable.  If you think this is the case, JUST REPORT ME.  Otherwise you're just going to get reported when you reply to my posts and point it out, because odds are, I was trying to be nice.

 

Exception: If you do not understand Java, I WILL NOT HELP YOU and your thread will get locked.

 

DO NOT PM ME WITH PROBLEMS. No help will be given.

Posted

I did empty, return null stoops server and crash and return empty do crash without error

  On 5/16/2019 at 5:29 PM, Draco18s said:

ItemStacks cannot be null. They cannot be null because a stack of size zero is empty and should be treated as a non-existent stack. 

This is why ItemStack.EMPTY exists. 

Expand  

 

Posted
  On 5/16/2019 at 5:29 PM, Draco18s said:

ItemStacks cannot be null. They cannot be null because a stack of size zero is empty and should be treated as a non-existent stack. 

This is why ItemStack.EMPTY exists. 

Expand  

So im only tring to do that shift will not crash, shift dont need a function but i have no plan how to do this, im not understanding the method

Posted (edited)

You still haven't post your code...

 

  On 5/16/2019 at 7:14 PM, Schleim_time said:

im not understanding the method

Expand  

IIRC the method takes in a player and an index indicating who clicked on the slot and which slot he/she clicked on.

The method also handles the inventory manipulation during the shift-click process.

The ItemStack the method returns is the ItemStack that should remain in the slot after the shift-click operation.

Edited by DavidM

Some tips:

  Reveal hidden contents

 

Posted

Thank you david, i will try my best but as first i copied the crafting table one because i also want to do something like that

  On 5/16/2019 at 10:56 PM, DavidM said:

You still haven't post your code...

 

IIRC the method takes in a player and an index indicating who clicked on the slot and which slot he/she clicked on.

The method also handles the inventory manipulation during the shift-click process.

The ItemStack the method returns is the ItemStack that should remain in the slot after the shift-click operation.

Expand  

 

Join the conversation

You can post now and register later. If you have an account, sign in now to post with your account.
Note: Your post will require moderator approval before it will be visible.

Guest
Unfortunately, your content contains terms that we do not allow. Please edit your content to remove the highlighted words below.
Reply to this topic...

×   Pasted as rich text.   Restore formatting

  Only 75 emoji are allowed.

×   Your link has been automatically embedded.   Display as a link instead

×   Your previous content has been restored.   Clear editor

×   You cannot paste images directly. Upload or insert images from URL.

Announcements



  • Recently Browsing

    • No registered users viewing this page.
  • Posts

    • just rewatched the tutorial and my code is exactly the same as kaupenjoe's.  the item is added into the game but like i said to start it doesnt have a texture or a proper name for whatever reason.
    • yes the name is en_us.json and it is in resources -> assests -> testmod -> lang folders.  i have checked my code and am pretty confident that the code itself is correct.  i even tried loading the project in eclipse and it has the same problems, I think i will just rewatch the whole tutorial and will give an update on the situation.
    • same error, I also tried removing Valkyrian skies as well because I noticed it coming up a lot in the debug log errors
    • Hey man,    i have only been modding Minecraft for a few days but maybe I can help you. First of all make sure to follow every step of Kaupenjoe's tutorial, I found it to been very helpful and complete. The game uses the raw translation key for the item (in your case "item.testmod.alexandrite") if it can't find the correct lang file. Make sure it's name is "en_us.json" and it is saved under "ressources" -> "assets" -> "testmod".
    • whenever I try to get this item to render into the game it appears with the not texture purple and black squares and calls itself by the lang translation file path instead of the name i gave it.   { "item.testmod.alexandrite": "Alexandrite" } this is the lang json file package net.Hurst.testmod.item; import net.Hurst.testmod.TestMod; import net.minecraft.world.item.Item; import net.minecraftforge.eventbus.api.IEventBus; import net.minecraftforge.registries.DeferredRegister; import net.minecraftforge.registries.ForgeRegistries; import net.minecraftforge.registries.RegistryObject; public class ModItems { public static final DeferredRegister<Item> ITEMS = DeferredRegister.create(ForgeRegistries.ITEMS, TestMod.MOD_ID); public static final RegistryObject<Item> ALEXANDRITE = ITEMS.register("alexandrite", () -> new Item(new Item.Properties())); public static void register(IEventBus eventBus){ ITEMS.register(eventBus); } } this is my ModItems.java file package net.Hurst.testmod; import com.mojang.logging.LogUtils; import net.Hurst.testmod.item.ModItems; import net.minecraft.world.item.CreativeModeTabs; import net.minecraftforge.api.distmarker.Dist; import net.minecraftforge.common.MinecraftForge; import net.minecraftforge.event.BuildCreativeModeTabContentsEvent; import net.minecraftforge.event.server.ServerStartingEvent; import net.minecraftforge.eventbus.api.IEventBus; import net.minecraftforge.eventbus.api.SubscribeEvent; import net.minecraftforge.fml.ModLoadingContext; import net.minecraftforge.fml.common.Mod; import net.minecraftforge.fml.config.ModConfig; import net.minecraftforge.fml.event.lifecycle.FMLClientSetupEvent; import net.minecraftforge.fml.event.lifecycle.FMLCommonSetupEvent; import net.minecraftforge.fml.javafmlmod.FMLJavaModLoadingContext; import org.slf4j.Logger; // The value here should match an entry in the META-INF/mods.toml file @Mod(TestMod.MOD_ID) public class TestMod { public static final String MOD_ID = "testmod"; private static final Logger LOGGER = LogUtils.getLogger(); public TestMod() { IEventBus modEventBus = FMLJavaModLoadingContext.get().getModEventBus(); modEventBus.addListener(this::commonSetup); ModItems.register(modEventBus); MinecraftForge.EVENT_BUS.register(this); modEventBus.addListener(this::addCreative); ModLoadingContext.get().registerConfig(ModConfig.Type.COMMON, Config.SPEC); } private void commonSetup(final FMLCommonSetupEvent event) { } // Add the example block item to the building blocks tab private void addCreative(BuildCreativeModeTabContentsEvent event) { if(event.getTabKey() == CreativeModeTabs.INGREDIENTS){ event.accept(ModItems.ALEXANDRITE); } } // You can use SubscribeEvent and let the Event Bus discover methods to call @SubscribeEvent public void onServerStarting(ServerStartingEvent event) { } // You can use EventBusSubscriber to automatically register all static methods in the class annotated with @SubscribeEvent @Mod.EventBusSubscriber(modid = MOD_ID, bus = Mod.EventBusSubscriber.Bus.MOD, value = Dist.CLIENT) public static class ClientModEvents { @SubscribeEvent public static void onClientSetup(FMLClientSetupEvent event) { } } } this is my TestMod.java file { "parent": "minecraft:item/generated", "textures": { "layer0": "testmod:item/generated" } } this is my model file for the item. I am using intellij 2025.1.2 with fdk 1.21 and java 21 I would appreciate the help.
  • Topics

×
×
  • Create New...

Important Information

By using this site, you agree to our Terms of Use.