(1.12.2) Recipe GoldenApple:1

[MrSawZ]

Hello,

I have created a recipe for the golden apple data 1 in my mod but i got this error:

 

[00:56:42] [main/ERROR] [FML]: Parsing error loading recipe sm:gap
com.google.gson.JsonSyntaxException: Unknown recipe type: sm:crafting_shaped
	at net.minecraftforge.common.crafting.CraftingHelper.getRecipe(CraftingHelper.java:407) ~[CraftingHelper.class:?]
	at net.minecraftforge.common.crafting.CraftingHelper.lambda$loadRecipes$22(CraftingHelper.java:711) ~[CraftingHelper.class:?]
	at net.minecraftforge.common.crafting.CraftingHelper.findFiles(CraftingHelper.java:822) ~[CraftingHelper.class:?]
	at net.minecraftforge.common.crafting.CraftingHelper.loadRecipes(CraftingHelper.java:668) ~[CraftingHelper.class:?]
	at java.util.ArrayList.forEach(Unknown Source) [?:1.8.0_201]
	at net.minecraftforge.common.crafting.CraftingHelper.loadRecipes(CraftingHelper.java:620) [CraftingHelper.class:?]
	at net.minecraftforge.fml.common.Loader.initializeMods(Loader.java:742) [Loader.class:?]
	at net.minecraftforge.fml.client.FMLClientHandler.finishMinecraftLoading(FMLClientHandler.java:336) [FMLClientHandler.class:?]
	at net.minecraft.client.Minecraft.init(Minecraft.java:581) [Minecraft.class:?]
	at net.minecraft.client.Minecraft.run(Minecraft.java:421) [Minecraft.class:?]
	at net.minecraft.client.main.Main.main(Main.java:118) [Main.class:?]
	at sun.reflect.NativeMethodAccessorImpl.invoke0(Native Method) ~[?:1.8.0_201]
	at sun.reflect.NativeMethodAccessorImpl.invoke(Unknown Source) ~[?:1.8.0_201]
	at sun.reflect.DelegatingMethodAccessorImpl.invoke(Unknown Source) ~[?:1.8.0_201]
	at java.lang.reflect.Method.invoke(Unknown Source) ~[?:1.8.0_201]
	at net.minecraft.launchwrapper.Launch.launch(Launch.java:135) [launchwrapper-1.12.jar:?]
	at net.minecraft.launchwrapper.Launch.main(Launch.java:28) [launchwrapper-1.12.jar:?]
	at sun.reflect.NativeMethodAccessorImpl.invoke0(Native Method) ~[?:1.8.0_201]
	at sun.reflect.NativeMethodAccessorImpl.invoke(Unknown Source) ~[?:1.8.0_201]
	at sun.reflect.DelegatingMethodAccessorImpl.invoke(Unknown Source) ~[?:1.8.0_201]
	at java.lang.reflect.Method.invoke(Unknown Source) ~[?:1.8.0_201]
	at net.minecraftforge.gradle.GradleStartCommon.launch(GradleStartCommon.java:97) [start/:?]
	at GradleStart.main(GradleStart.java:25) [start/:?]

 

Here's my recipe:

{
    "type": "crafting_shaped",
    "pattern": [
        "#D#",
        "DGD",
        "#D#"
    ],
    "key": {
        "#": {
            "item": "minecraft:gold_block"
        },
        "D": {
            "item": "minecraft:diamond_block"
        },
        "G": {
            "item": "minecraft:golden_apple",
            "data": 0
        }
    },
    "result": {
        "item": "minecraft:golden_apple",
        "data": 1,
        "count": 1
    }
}

 

Can you help me, please? :c 

 

[TheKingElessar]

2 hours ago, MrSawZ said:

Unknown recipe type: sm:crafting_shaped

 

2 hours ago, MrSawZ said:

"type": "crafting_shaped",

 

This seems to be your problem. According to the documentation here, the proper type is "minecraft:crafting_shaped", not "crafting_shaped". It looks like that by leaving off "minecraft:" the game assumes you are using a custom recipe, which is why it's looking for the recipe type "sm:crafting_shaped" ("sm" must be your modid).

 

If you're trying to use a custom recipe type, perhaps the name you gave it in your _factories.json file isn't "crafting_shaped" because you had a typo.

 

On another note, it would be good to get a longer modid. You might be using a two-letter one because of a tutorial you followed, but there is pretty much no reason to not use a longer, more descriptive one. That will minimize the chances for conflicts between your mod and other mod!

[MrSawZ]

Oh yeah, that's work!

I have missed "minecraft::" on the documentation.

and for the modid, it's a private mod for my server so the conflicts are minimal but that's a good tip,

 

Thanks !

[DavidM]

"sm" is a bad mod ID that will conflict with other mods.

You should use a longer mod ID than just 2 letters.

[Draco18s]

14 hours ago, MrSawZ said:

it's a private mod for my server so the conflicts are minimal but that's a good tip

You have 64 characters worth of length available. Use it.