My things do not register. Some help?

[superminerJG]

Minecraft 1.14.3 Forge.

 

As in the title, I used registry events to register an item and a block. But they don't register. Why?

 

REPO here ---> https://github.com/JGgithub2018/Fluxed-Machinery?files=1

[Draco18s]

30 minutes ago, superminerJG said:

I used registry events to register an item and a block.

Really?

https://github.com/JGgithub2018/Fluxed-Machinery/blob/master/src/main/java/jgcodes/fluxmachines/ModClass.java#L70-L81

[IAmAFrenchFry]

In your mod setup class, you need to add this to your item registry function:

event.getRegistry().register(new FirstItem());

FirstItem will be replaced with the name of your item class in src/main/java/jgcodes/fluxmachines/items and your constructor name in that class (their names should be the same).

 

Also, textures are client side, and you put your texture in the data folder which is server side. Your redstone ingot PNG file should go into src/main/resources/assets/fluxmachines/textures/item. 

 

Lastly, this is preference (I believe), but I’d name your Mod class to the name of your mod, like FluxMachines.java,  it ModClass.java.

 

Remember, you still need a model, a class, and an optional recipe.

 

If you need more help, here is my git repo (it has some other stuff in it that need to be ignored, such as a GUI): https://github.com/IAmAFrenchFry/CadeMod

 

Hope this helps.

[superminerJG]

Thanks.

32 minutes ago, Draco18s said:

Really?

https://github.com/JGgithub2018/Fluxed-Machinery/blob/master/src/main/java/jgcodes/fluxmachines/ModClass.java#L70-L81

Ahem. Somehow ended up not pushing some changes. *pls read edit message*

Edited July 12, 2019 by superminerJG
I just pushed those changes, hope it helps

[Cadiboo]

Can you please explain this and this?

Don't keep lists of your objects around.

[DavidM]

You don't have an event subscriber for the registry events.

Pretty sure you need a @SubscribeEvent here.

Don't make your own setup system; it is pointless and unreadable. Keep things simple and use the event subscriber normally.

Edited July 12, 2019 by DavidM

[superminerJG]

After cleanup and moving registries to FluxMachines.java, I don't know how it doesn't register still.

 

I checked McJty's 1.14 tutorial, and I don't get how it shouldn't work now. 

 

Edited July 12, 2019 by superminerJG
OK, I added a line.

[superminerJG]

Well, even more tweaks. still nothing. ?

 

NEWEST COMMIT HERE!!!

[PhilipChonacky]

You're using static fields in you registry entries

Instantiate your blocks and items at the same place you register them 

 

It should look more like this:

public static void onBlocksRegistry(final RegistryEvent.Register<Block> blockRegistryEvent) {
    			blockRegistryEvent.getRegistry().registerAll(
    					new Block(Block.Properties.create(Material.IRON)).setRegistryName(MODID,"test_block")); 
        }

 

For blocks, you will either need an Object Holder, or iterate the Block Registry to register the corresponding ItemBlocks