HarvestDropsEvent not working as expected.

[Andrew Murdza]

I'm making a mod for 1.14.4 which affects the drops of blocks depending on the biome at the location where they were harvested. I think that the best way to do this is with the HarvestDropsEvent. The problem is that my HarvestDropEvent method does not get called when I mine a sand block with a diamond shovel in survival on a test world. I could use the OnBlockBreakEvent method (which does get called under the same situation) but I only want the additional drops to be added if the conditions of the harvest drops event are satisfied and the tool is not a silk-touch tool. Note that I have strange code inside of both methods because I first want to make sure I get the onEvent method to fire and then I will replace the inside code with things relevant to my mod.

 

Please tell if there is a way to get the onEvent method to be called when I harvest blocks like wheat, melons, ores, etc.

 

My code is below:

 

 

 

 

 

Spoiler

package com.amurdza.aoemod.blocks;

import java.util.List;
import java.util.logging.*;

import com.amurdza.aoemod.LoggerClass;

import net.minecraft.block.Block;
import net.minecraft.block.Blocks;
import net.minecraft.entity.player.PlayerEntity;
import net.minecraft.item.Item;
import net.minecraft.item.ItemStack;
import net.minecraft.item.Items;
import net.minecraft.util.math.BlockPos;
import net.minecraft.world.World;
import net.minecraftforge.event.world.BlockEvent;
import net.minecraftforge.event.world.BlockEvent.HarvestDropsEvent;
import net.minecraftforge.eventbus.api.EventPriority;
import net.minecraftforge.eventbus.api.SubscribeEvent;
import net.minecraftforge.fml.common.Mod.EventBusSubscriber;

@EventBusSubscriber
public class BlockEventHandler {

    private static final Logger logger=LoggerClass.logSetup();
    @SubscribeEvent
    public static void OnBlockBreakEvent(BlockEvent.BreakEvent event) {
        Block block=event.getState().getBlock();
        logger.info("this ran");
        World worldIn=event.getWorld().getWorld();
        BlockPos pos=event.getPos();
        PlayerEntity player=event.getPlayer();
        
        Item activeItem=player.getHeldItemMainhand().getItem();
        //if(activeItem.canHarvestBlock(event.getState())) {
            logger.info("this ran 1");
            if(!activeItem.equals(Items.SHEARS)) {
                logger.info("this ran 2");
                if(!player.isCreative()) {
                    logger.info("this ran 3");
                    
                }
            }
        //}
        
        Block.spawnAsEntity(worldIn, pos, new ItemStack(Items.GOLD_INGOT,4));        
        if(block.equals(Blocks.JUNGLE_LEAVES)) {
            logger.info("this ran 2");
            World worldIn1=event.getWorld().getWorld();
            BlockPos pos1=event.getPos();
            Block.spawnAsEntity(worldIn1, pos1, new ItemStack(Items.JUNGLE_SAPLING,4));
        }
    }
    
    
    @SubscribeEvent(priority=EventPriority.NORMAL, receiveCanceled=true)
    public static void onEvent(HarvestDropsEvent event) {
        List<ItemStack> drops=event.getDrops();
        logger.info("this ran");
        if(drops.contains(new ItemStack(Items.SAND,1))) {
            logger.info("this ran 2");
            World worldIn=event.getWorld().getWorld();
            BlockPos pos=event.getPos();
            Block.spawnAsEntity(worldIn, pos, new ItemStack(Items.GOLD_INGOT,4));        
        }
    }
}

 

Thanks, Andrew Murdza

[Animefan8888]

5 hours ago, Andrew Murdza said:

@EventBusSubscriber

You need to provide the bus in the annotation. It needs to be Bus.FORGE I believe.

[Choonster]

2 hours ago, Animefan8888 said:

You need to provide the bus in the annotation. It needs to be Bus.FORGE I believe.

Bus.FORGE is the default, so it doesn't need to be specified manually.

[Animefan8888]

10 minutes ago, Choonster said:

Bus.FORGE is the default, so it doesn't need to be specified manually.

Right.

 

8 hours ago, Andrew Murdza said:

logger.info("this ran");

Does this log statement run?

 

8 hours ago, Andrew Murdza said:

 if(drops.contains(new ItemStack(Items.SAND,1))) {

This is probably your problem. Your asking if a new instance of ItemStack is in the drops list. That doesn't work.

[Andrew Murdza]

The log statements in OnBlockBreak all run, while the log statement in the HarvestDropsEvent does not. This means that the if statement is not reached.

 

How could I change the if statement so that it would work? (This is something I would have to deal with after I get the HarvestDropsEvent to fire)

 

Thanks, Andrew Murdza

 

[Azaka7]

I'm using the latest Forge MDK for 1.15.2 and the HarvestDropsEvent event sill isn't being fired. Other types of BlockEvent are fired. I used Eclipse to search for references, and found that while there IS a method that posts the HarvestDropsEvent, that method is never called. Basically the event is never fired unless fired by a mod. I think this is a bug.

[Draco18s]

And modifications to such are still being worked on.

https://github.com/MinecraftForge/MinecraftForge/pull/6401

[Andrew Murdza]

I am now making a mod for 1.15 I would like to know when the event comes to forge 1.15. I went to the link Draco18s provided and it seems that there is no project or milestone. I subscribed to that github thread, but I was wondering if anyone has a time estimate for the number of months before it gets added.

[Draco18s]