MatsCraft1 Posted August 30, 2019 Share Posted August 30, 2019 So here is my code package com.aug15.morestuff.items; import net.minecraft.block.DispenserBlock; import net.minecraft.entity.LivingEntity; import net.minecraft.entity.player.PlayerEntity; import net.minecraft.inventory.EquipmentSlotType; import net.minecraft.item.ArmorItem; import net.minecraft.item.Item; import net.minecraft.item.ItemStack; import net.minecraft.item.UseAction; import net.minecraft.util.*; import net.minecraft.util.math.MathHelper; import net.minecraft.world.World; import net.minecraftforge.api.distmarker.Dist; import net.minecraftforge.api.distmarker.OnlyIn; import net.minecraftforge.event.entity.living.LivingAttackEvent; import net.minecraftforge.eventbus.api.SubscribeEvent; public class ItemShield extends Item { public ItemShield(Item.Properties builder) { super(builder); this.addPropertyOverride(new ResourceLocation("blocking"), (ItemStack stack, World worldIn, LivingEntity player1) -> { return player1 != null && player1.isHandActive() && player1.getActiveItemStack() == stack ? 1.0F : 0.0F; }); DispenserBlock.registerDispenseBehavior(this, ArmorItem.DISPENSER_BEHAVIOR); } public String getTranslationKey(ItemStack stack) { return stack.getChildTag("BlockEntityTag") != null ? this.getTranslationKey() : super.getTranslationKey(stack); } public UseAction getUseAction(ItemStack stack) { return UseAction.BLOCK; } public int getUseDuration(ItemStack stack) { return 300; } public ActionResult<ItemStack> onItemRightClick(World worldIn, PlayerEntity playerIn, Hand handIn) { ItemStack itemstack = playerIn.getHeldItem(handIn); playerIn.setActiveHand(handIn); return new ActionResult<>(ActionResultType.SUCCESS, itemstack); } @SubscribeEvent @OnlyIn(Dist.CLIENT) public void attackEvent(LivingAttackEvent e) { float damage = e.getAmount(); ItemStack activeItemStack; PlayerEntity player; if (!(e.getEntityLiving() instanceof PlayerEntity)) { return; } player = (PlayerEntity) e.getEntityLiving(); if (player.getActiveItemStack() == null) { return; } activeItemStack = player.getActiveItemStack(); if (damage > 0.0F && activeItemStack != null && activeItemStack.getItem() instanceof ItemShield) { int i = 1 + MathHelper.floor(damage); activeItemStack.damageItem(i, NO IDEA HERE); if (activeItemStack.getCount() <= 0) { Hand enumhand = player.getActiveHand(); net.minecraftforge.event.ForgeEventFactory.onPlayerDestroyItem(player, activeItemStack, enumhand); if (enumhand == Hand.MAIN_HAND) { player.setItemStackToSlot(EquipmentSlotType.MAINHAND, (ItemStack) null); } else { player.setItemStackToSlot(EquipmentSlotType.OFFHAND, (ItemStack) null); } activeItemStack = null; player.playSound(SoundEvents.ITEM_SHIELD_BREAK, 0.8F, 0.8F + player.world.rand.nextFloat() * 0.4F); } } } } } The problem is this part if (damage > 0.0F && activeItemStack != null && activeItemStack.getItem() instanceof ItemShield) { int i = 1 + MathHelper.floor(damage); activeItemStack.damageItem(i, NO IDEA HERE); if I do "activeItemStack.damageItem(i, EntityLiving);" or "activeItemStack.damageItem(i, player);" it tells me it's wrong... I have no idea what to do there?! Quote Link to comment Share on other sites More sharing options...
Animefan8888 Posted August 30, 2019 Share Posted August 30, 2019 3 minutes ago, MatsCraft1 said: (player.getActiveItemStack() == null) ItemStacks are no longer nukl. Use ItemStack#isEmpty 5 minutes ago, MatsCraft1 said: it tells me it's wrong... Not sure what that means. What does it say. If its eclipse telling you it's wrong then it's a Java problem not a forge problem ask elsewhere/learn the Java language. Quote VANILLA MINECRAFT CLASSES ARE THE BEST RESOURCES WHEN MODDING I will be posting 1.15.2 modding tutorials on this channel. If you want to be notified of it do the normal YouTube stuff like subscribing, ect. Forge and vanilla BlockState generator. Link to comment Share on other sites More sharing options...
MatsCraft1 Posted August 30, 2019 Author Share Posted August 30, 2019 1 minute ago, Animefan8888 said: ItemStacks are no longer nukl. Use ItemStack#isEmpty Not sure what that means. What does it say. If its eclipse telling you it's wrong then it's a Java problem not a forge problem ask elsewhere/learn the Java language. 1. I use IDEA 2. If I put activeItemStack.damageItem(i, LivingEntity); it tells me that it expects an expression. If I put activeItemStack.damageItem(i, player); it tells me that it cannot be applied to "player" Quote Link to comment Share on other sites More sharing options...
Draco18s Posted August 30, 2019 Share Posted August 30, 2019 1 hour ago, MatsCraft1 said: activeItemStack.damageItem(i, LivingEntity); That's because LivingEntity is a type name, not an object instance. Quote Apparently I'm a complete and utter jerk and come to this forum just like to make fun of people, be confrontational, and make your personal life miserable. If you think this is the case, JUST REPORT ME. Otherwise you're just going to get reported when you reply to my posts and point it out, because odds are, I was trying to be nice. Exception: If you do not understand Java, I WILL NOT HELP YOU and your thread will get locked. DO NOT PM ME WITH PROBLEMS. No help will be given. Link to comment Share on other sites More sharing options...
MatsCraft1 Posted August 31, 2019 Author Share Posted August 31, 2019 (edited) 15 hours ago, Draco18s said: That's because LivingEntity is a type name, not an object instance. okay this might sound totally stupid but... what should I put in there? It feels like my last brain cell just died. Edited August 31, 2019 by MatsCraft1 Quote Link to comment Share on other sites More sharing options...
DavidM Posted August 31, 2019 Share Posted August 31, 2019 2 hours ago, MatsCraft1 said: what should I put in there? An instance of LivingEntity. Note that in 1.14 there is a third parameter that takes in a Consumer<? extends LivingEntity>. If you need help on creating a consumer, you can read about lambdas and consumers in Java here. Quote Some tips: Spoiler Modder Support: Spoiler 1. Do not follow tutorials on YouTube, especially TechnoVision (previously called Loremaster) and HarryTalks, due to their promotion of bad practice and usage of outdated code. 2. Always post your code. 3. Never copy and paste code. You won't learn anything from doing that. 4. Quote Programming via Eclipse's hotfixes will get you nowhere 5. Learn to use your IDE, especially the debugger. 6. Quote The "picture that's worth 1000 words" only works if there's an obvious problem or a freehand red circle around it. Support & Bug Reports: Spoiler 1. Read the EAQ before asking for help. Remember to provide the appropriate log(s). 2. Versions below 1.11 are no longer supported due to their age. Update to a modern version of Minecraft to receive support. Link to comment Share on other sites More sharing options...
Recommended Posts
Join the conversation
You can post now and register later. If you have an account, sign in now to post with your account.
Note: Your post will require moderator approval before it will be visible.