Simple Summon Lightning on Right Click with Sword 1.12.2

[sarxworks]

Hello All :), I am relatively new to minecraft modding so I might be a bit unsure about certain things. I have a basic grasp on Java programming so I would say I somewhat understand how the code works and I'm constantly trying to learn but I've hit a snag. Basically I'm trying to make a basic sword that fires lightning bolts on right click however I can't seem to get the code to work. This is currently what I'm using:

public BoltSword(String unlocalizedName, ToolMaterial material) {
        super(unlocalizedName, material);
    }
    public ActionResult<ItemStack> onItemRightClick(ItemStack itemStackIn, World worldIn, EntityPlayer playerIn, EnumHand hand) {
        if (worldIn.isRemote) {
            RayTraceResult result = playerIn.rayTrace(100, 1F);
            int x = result.getBlockPos().getX();
            int y = result.getBlockPos().getY();
            int z = result.getBlockPos().getZ();
            EntityLightningBolt lightning = new EntityLightningBolt(worldIn, x, y, z, false);
            worldIn.addWeatherEffect(lightning);
            
        }
        return new ActionResult(EnumActionResult.SUCCESS, itemStackIn);

I've tried searching endless posts and this was the furthest I've gotten however it still won't work. I will appreciate any help given and I'm open to any suggestions you guys may recommend me. Thanks!

[DavidM]

Entity summoning are controlled on the server side, thus summoning lightning bolts on the client will not work.

Send a packet to the server when the sword is right clicked with; write a handler for that packet that summons the lightning.

[DavidM]

  On 9/2/2019 at 11:40 AM, diesieben07 said:

Not needed, onItemRightClick is called on the server, too.

Expand  

I thought OP needed RayTracing. If I recall correctly RayTracing is client only?

[Differentiation]

  On 9/2/2019 at 7:33 AM, sarxworks said:

Hello All :), I am relatively new to minecraft modding so I might be a bit unsure about certain things. I have a basic grasp on Java programming so I would say I somewhat understand how the code works and I'm constantly trying to learn but I've hit a snag. Basically I'm trying to make a basic sword that fires lightning bolts on right click however I can't seem to get the code to work. This is currently what I'm using:

public BoltSword(String unlocalizedName, ToolMaterial material) {
        super(unlocalizedName, material);
    }
    public ActionResult<ItemStack> onItemRightClick(ItemStack itemStackIn, World worldIn, EntityPlayer playerIn, EnumHand hand) {
        if (worldIn.isRemote) {
            RayTraceResult result = playerIn.rayTrace(100, 1F);
            int x = result.getBlockPos().getX();
            int y = result.getBlockPos().getY();
            int z = result.getBlockPos().getZ();
            EntityLightningBolt lightning = new EntityLightningBolt(worldIn, x, y, z, false);
            worldIn.addWeatherEffect(lightning);
            
        }
        return new ActionResult(EnumActionResult.SUCCESS, itemStackIn);

I've tried searching endless posts and this was the furthest I've gotten however it still won't work. I will appreciate any help given and I'm open to any suggestions you guys may recommend me. Thanks!

Expand  

Check for !World::isRemote. Also, EntityPlayer::rayTrace(double blockReachDistance, float partialTicks) has @SideOnly(Side.CLIENT) annotation, so you can't run it on server thread or you'll crash. Use World::rayTraceBlocks(Vec3d start, Vec3d end) instead.

One more thing, make an instance of BlockPos instead of calling the same method three times.

Edited September 2, 2019 by Differentiation

[sarxworks]

Alright so I first realized that one of the value "worldIn" was a mistake by me. I meant to use "world". I have changed the code around and used world.isRemote however I'm still not getting a response from right clicking. I'm not worrying too much about cleaning up the code as of right now, just trying to test things out. This is what I have: 

  Quote

public class LightningBoltEvent{
        @SubscribeEvent
        public ActionResult<ItemStack> onItemRightClick(ItemStack itemStackIn, World world, EntityPlayer playerIn, EnumHand hand){
            if(!world.isRemote) {
                  RayTraceResult result = playerIn.rayTrace(100, 1F);
                  int x = result.getBlockPos().getX();
                  int y = result.getBlockPos().getY();
                  int z = result.getBlockPos().getZ();
                  EntityLightningBolt lightning = new EntityLightningBolt(world, x, y, z, false);
                  world.addWeatherEffect(lightning);
            }
                return new ActionResult<ItemStack>(EnumActionResult.SUCCESS, itemStackIn);

Expand  

I even tried referencing the class in the main class to see if the event was not initializing but no change. Is it that I did not use the @Override annotation or no?

[Animefan8888]

  On 9/5/2019 at 1:00 AM, sarxworks said:

I even tried referencing the class in the main class to see if the event was not initializing but no change

Expand  

What you have there is not an event.

How much do you know Java? If not much I don't recommend starting with creating a Minecraft Modding.

If you know Java you don't have the right method signature It's Item#onItemRightClick(World, EntityPlayer, EnumHand) You don't get the ItemStack but you can get it via EntityPlayer#getHeldItem()

[sarxworks]

I've taken a MOOC class over the summer so I understand the basics of the Java like OOP, Basic methods, modifiers, flow statements and the other fundamentals. If I need to know more I'm more than willing to learn. I figured that after a while because I was wondering what purpose the ItemStack had in the method. Alright I will try that.

Edited September 5, 2019 by sarxworks

[sarxworks]

Alright I've gotten the lightning to work, it only shows in the sky however but I did that purposely by removing one of the lines of code. Thanks to everybody who gave their help