Jump to content
View in the app

A better way to browse. Learn more.

Forge Forums

A full-screen app on your home screen with push notifications, badges and more.

To install this app on iOS and iPadOS
  1. Tap the Share icon in Safari
  2. Scroll the menu and tap Add to Home Screen.
  3. Tap Add in the top-right corner.
To install this app on Android
  1. Tap the 3-dot menu (⋮) in the top-right corner of the browser.
  2. Tap Add to Home screen or Install app.
  3. Confirm by tapping Install.

Featured Replies

Posted

Hi, I want to make an item with durability that will give you another item when the durability reaches 0, this item applies various effects when right clicked on a mob, but when his durability is 0 it never gives the player the item

 

Here is the code:

public class PepperSpray extends Item {
	public PepperSpray(Item.Properties properties) {
		super(properties.maxDamage(20));
	}

	   @Override
	   public boolean itemInteractionForEntity(ItemStack stack, PlayerEntity playerIn, LivingEntity target, net.minecraft.util.Hand hand) {
		   if (target.world.isRemote) return false;
	         if (target instanceof LivingEntity) {
	        	 target.addPotionEffect(new EffectInstance(Effects.POISON, 40));
	        	 target.addPotionEffect(new EffectInstance(Effects.BLINDNESS, 125));
	        	 target.addPotionEffect(new EffectInstance(Effects.WEAKNESS, 20));
	        	 stack.damageItem(1, target, e -> e.sendBreakAnimation(hand));
	        	 if (stack.isEmpty()) {
	                 stack = new ItemStack(Items.BEETROOT);
	              }
	         }

	        playerIn.getEntityWorld().playSound(null, playerIn.getPosition(), SoundEvents.ENTITY_CREEPER_HURT, SoundCategory.PLAYERS, 0.9f, 3.0f);
	        playerIn.swingArm(hand);
	 		playerIn.setActiveHand(hand);
	 		playerIn.addStat(Stats.ITEM_USED.get(this));
			return true;
	      }
	   
}

And here is the part that doesn't work.

if (stack.isEmpty()) {
	                 stack = new ItemStack(Items.BEETROOT);
	              }

Any help is appreciated.

Edited by Jebano

Use player.addItemStackToInventory(...) instead of stack = new ItemStack. Also, why are you checking if target is an instance of LivingEntity? It is already defined as a LivingEntity. Did you mean to check if it is an instance of PlayerEntity?

  • Author

Thanks, it worked! The only problem is that if you grab an item when durability reaches 0 (like if you have lots of items on the ground and you automatically pick up one), it won't give you the item because it doesn't detect it as an "empty" stack.

2 hours ago, Jebano said:

Thanks, it worked! The only problem is that if you grab an item when durability reaches 0 (like if you have lots of items on the ground and you automatically pick up one), it won't give you the item because it doesn't detect it as an "empty" stack.

You need to handle that case yourself. addItemStackToInventory returns a value. Use that value to know whether or not you must spawn an EntityItem where the player is.

VANILLA MINECRAFT CLASSES ARE THE BEST RESOURCES WHEN MODDING

I will be posting 1.15.2 modding tutorials on this channel. If you want to be notified of it do the normal YouTube stuff like subscribing, ect.

Forge and vanilla BlockState generator.

Join the conversation

You can post now and register later. If you have an account, sign in now to post with your account.
Note: Your post will require moderator approval before it will be visible.

Guest
Unfortunately, your content contains terms that we do not allow. Please edit your content to remove the highlighted words below.
Reply to this topic...

Important Information

By using this site, you agree to our Terms of Use.

Configure browser push notifications

Chrome (Android)
  1. Tap the lock icon next to the address bar.
  2. Tap Permissions → Notifications.
  3. Adjust your preference.
Chrome (Desktop)
  1. Click the padlock icon in the address bar.
  2. Select Site settings.
  3. Find Notifications and adjust your preference.