Jump to content

[1.14.3] make blocks naturally generate


MrNoodles75

Recommended Posts

Here is example, just replace YOUR_BLOCK with your registered block and all property.<type> with your values

@Mod.EventBusSubscriber(modid = MODID, bus = Mod.EventBusSubscriber.Bus.FORGE)
public class ForgeEventSubscriber {
    @SubscribeEvent
    public static void onInitBiomesGen(WorldTypeEvent.BiomeSize event) {
        for (Biome biome : ForgeRegistries.BIOMES) {
                biome.addFeature(
                    GenerationStage.Decoration.UNDERGROUND_ORES,
                    Biome.createDecoratedFeature(
                        Feature.ORE,
                        new OreFeatureConfig(OreFeatureConfig.FillerBlockType.NATURAL_STONE, YOUR_BLOCK.getDefaultState(), property.veinSize),
                        Placement.COUNT_RANGE,
                        new CountRangeConfig(property.veinCount, property.heightMin, property.heightBase, property.heightMax))
                );
        }
    }
}
Edited by Yanny7
Link to comment
Share on other sites

16 minutes ago, Yanny7 said:

Here is example, just replace YOUR_BLOCK with your registered block and all property.<type> with your values


@Mod.EventBusSubscriber(modid = MODID, bus = Mod.EventBusSubscriber.Bus.FORGE)
public class ForgeEventSubscriber {
    @SubscribeEvent
    public static void onInitBiomesGen(WorldTypeEvent.BiomeSize event) {
        for (Biome biome : ForgeRegistries.BIOMES) {
            for (OresEnum oresEnum : OresEnum.values()) {
                biome.addFeature(
                    GenerationStage.Decoration.UNDERGROUND_ORES,
                    Biome.createDecoratedFeature(
                        Feature.ORE,
                        new OreFeatureConfig(OreFeatureConfig.FillerBlockType.NATURAL_STONE, YOUR_BLOCK.getDefaultState(), property.veinSize),
                        Placement.COUNT_RANGE,
                        new CountRangeConfig(property.veinCount, property.heightMin, property.heightBase, property.heightMax))
                );
        }
    }
}

@Yanny7 when I do this I get an error because it does not know what OresEnum is.

 

            for (OresEnum oresEnum : OresEnum.values()) {
                                     ^
  symbol:   variable OresEnum

Link to comment
Share on other sites

Just now, MrNoodles75 said:

@Yanny7 when I do this I get an error because it does not know what OresEnum is.

 

            for (OresEnum oresEnum : OresEnum.values()) {
                                     ^
  symbol:   variable OresEnum

My bad, I copied more than I intended. I already updated my post 

Link to comment
Share on other sites

@Yanny7 Thanks, but one more thing,

so my blocks are created in a class

107102568_ScreenShot2019-09-24at2_11_27PM.png.d8193c6c6689f36b030024c002afe652.png

 

and then the item form of the block is made in a ModBlocks class.

1198703469_ScreenShot2019-09-24at2_11_55PM.png.7a31cb666424cbf706f83d88d5c9c478.png

 

so should I use the ModBlocks Version or the regular class version?

987929958_ScreenShot2019-09-24at2_12_16PM.thumb.png.291a5eba89fb0cf43e679aec0d9c137f.png

when I use the class it says

Non-static method getDefaultState() cannot be referenced from a static context.

so I should use ModBlocks.PLASTICORE right?

Edited by MrNoodles75
Link to comment
Share on other sites

@Mod.EventBusSubscriber(modid = "YOUR_MODID", bus = Mod.EventBusSubscriber.Bus.FORGE)
public class ForgeEventSubscriber {
    @SubscribeEvent
    public static void onInitBiomesGen(WorldTypeEvent.BiomeSize event) {
        for (Biome biome : ForgeRegistries.BIOMES) {
                biome.addFeature(
                    GenerationStage.Decoration.UNDERGROUND_ORES,
                    Biome.createDecoratedFeature(
                        Feature.ORE,
                        new OreFeatureConfig(OreFeatureConfig.FillerBlockType.NATURAL_STONE, YOUR_BLOCK.getDefaultState(), 8),
                        Placement.COUNT_RANGE,
                        new CountRangeConfig(10, 0, 40, 120))
                );
        }
    }
}

 

Link to comment
Share on other sites

@diesieben07

so,

 

@SubscribeEvent
public static void onInitBiomesGen(FMLCommonSetupEvent event) {
    for (Biome biome : ForgeRegistries.BIOMES) {
        biome.addFeature(
                GenerationStage.Decoration.UNDERGROUND_ORES,
                Biome.createDecoratedFeature(
                        Feature.ORE,
                        new OreFeatureConfig(OreFeatureConfig.FillerBlockType.NATURAL_STONE, ModBlocks.PLASTICORE.getDefaultState(), PlasticOre.veinSize),
                        Placement.COUNT_RANGE,
                        new CountRangeConfig(PlasticOre.veinCount, PlasticOre.heightMin, PlasticOre.heightBase, PlasticOre.heightMax))
        );
    }
}
Link to comment
Share on other sites

 

@diesieben07

okay, so I did this,

I added a System.out.println();

1930940818_ScreenShot2019-09-24at4_16_47PM.thumb.png.1c759000b5582bf9afbcd0a08f95f7a8.png

and it didn't ever generate.

I moved around the world so I would be generating new blocks but I

never saw the message,

meaning that it never got called.

 

also if you look at the image above you can see that the method is unused but as you can see below the block registry and the item registry(also in RegistryEvents along with onInitBiomesGen())

are also unused but they still work.

970745045_ScreenShot2019-09-24at4_30_25PM.png.c5ab60eb1e0208c0885320e53d348ae4.png

 

one more thing the answer could be that the method is within RegistryEvents and not in the ForgeEventSubscriber class

Link to comment
Share on other sites

4 hours ago, MrNoodles75 said:

FMLCommonSetupEvent

This is a Mod LifeCycle event. You'd typically have this in your @Mod class and have it registered in that classes constructor with FMLJavaModLoadingContext.get().getModEventBus().addListener(this::commonSetup);

VANILLA MINECRAFT CLASSES ARE THE BEST RESOURCES WHEN MODDING

I will be posting 1.15.2 modding tutorials on this channel. If you want to be notified of it do the normal YouTube stuff like subscribing, ect.

Forge and vanilla BlockState generator.

Link to comment
Share on other sites

Join the conversation

You can post now and register later. If you have an account, sign in now to post with your account.
Note: Your post will require moderator approval before it will be visible.

Guest
Unfortunately, your content contains terms that we do not allow. Please edit your content to remove the highlighted words below.
Reply to this topic...

×   Pasted as rich text.   Restore formatting

  Only 75 emoji are allowed.

×   Your link has been automatically embedded.   Display as a link instead

×   Your previous content has been restored.   Clear editor

×   You cannot paste images directly. Upload or insert images from URL.

Announcements



  • Recently Browsing

    • No registered users viewing this page.
  • Posts

    • I'm using Modrinth as a launcher for a forge modpack on 1.20.1, and can't diagnose the issue on the crash log myself. Have tried repairing the Minecraft instillation as well as removing a few mods that have been problematic for me in the past to no avail. Crash log is below, if any further information is necessary let me know. Thank you! https://paste.ee/p/k6xnS
    • Hey folks. I am working on a custom "Mecha" entity (extended from LivingEntity) that the player builds up from blocks that should get modular stats depending on the used blocks. e.g. depending on what will be used for the legs, the entity will have a different jump strength. However, something unexpected is happening when trying to override a few of LivingEntity's functions and using my new own "Mecha" specific fields: instead of their actual instance-specific value, the default value is used (0f for a float, null for an object...) This is especially strange as when executing with the same entity from a point in the code specific to the mecha entity, the correct value is used. Here are some code snippets to better illustrate what I mean: /* The main Mecha class, cut down for brevity */ public class Mecha extends LivingEntity { protected float jumpMultiplier; //somewhere later during the code when spawning the entity, jumpMultiplier is set to something like 1.5f //changing the access to public didn't help @Override //Overridden from LivingEntity, this function is only used in the jumpFromGround() function, used in the aiStep() function, used in the LivingEntity tick() function protected float getJumpPower() { //something is wrong with this function //for some reason I can't correctly access the fields and methods from the instanciated entity when I am in one of those overridden protected functions. this is very annoying LogUtils.getLogger().info(String.valueOf(this.jumpMultiplier))) //will print 0f return this.jumpMultiplier * super.getJumpPower(); } //The code above does not operate properly. Written as is, the entity will not jump, and adding debug logs shows that when executing the code, the value of this.jumpMultiplier is 0f //in contrast, it will be the correct value when done here: @Override public void tick() { super.tick(); //inherited LivingEntity logic //Custom logic LogUtils.getLogger().info(String.valueOf(this.jumpMultiplier))) //will print 1.5f } } My actual code is slightly different, as the jumpMuliplier is stored in another object (so I am calling "this.legModule.getJumpPower()" instead of the float), but even using a simple float exactly like in the code above didn't help. When running my usual code, the object I try to use is found to be null instead, leading to a crash from a nullPointerException. Here is the stacktrace of said crash: The full code can be viewed here. I have found a workaround in the case of jump strength, but have already found the same problem for another parameter I want to do, and I do not understand why the code is behaving as such, and I would very much like to be able to override those methods as intended - they seemed to work just fine like that for vanilla mobs... Any clues as to what may be happening here?
    • Please delete post. Had not noticed the newest edition for 1.20.6 which resolves the issue.
    • https://paste.ee/p/GTgAV Here's my debug log, I'm on 1.18.2 with forge 40.2.4 and I just want to get it to work!! I cant find any mod names in the error part and I would like some help from the pros!! I have 203 mods at the moment.
  • Topics

×
×
  • Create New...

Important Information

By using this site, you agree to our Terms of Use.