Jump to content
Search In
  • More options...
Find results that contain...
Find results in...

[Forge 1.14] Optifine Light Modification Conflict


geekles
 Share

Recommended Posts

Recently I had the idea of recreating mods such as "Hardcore Darkness" so that they were up to date. I ran into the issue though where the torches' brightness weren't strong enough to counter the darker world that I created by lowering the world's gamma. However, I found out about the Dimension#generateLightBrightnessTable() function which is used to calculate the light levels of surrounding blocks. By modifying a particular constant, I was able to achieve higher levels of brightness from the torches so that more than one didn't need to be used within 3 blocks of one another. Everything was fine until I ran into an issue with Optifine. With optifine, it appears Dimension#generateLightBrightnessTable() is redundant and unused since it is called (shown through debugging) but doesn't produce the brightness output as it would when testing in a development environment without it. Below you will see two images with a side by side comparison of the differences in brightness. 

 
 
 
 
Spoiler

Without Optifine

2019-10-04_00_09_58.png.628150a0e8aef24583957d6419f5966d.png

 
 
 
 
Spoiler

With Optifine

2019-10-04_00_12_10.png.c9ac7f92db3af85c52d1ad3fa6ddb060.png

Any insight on what Optifine is doing that is preventing me from getting the same brightness result in both scenarios would be great. 

 

Some additional details you may find useful:

Forge-Version: 1.14.4-28.1.10

Optifine-Version: preview_OptiFine_1.14.4_HD_U_F4_pre4

Link to comment
Share on other sites

1 hour ago, geekles said:

Any insight on what Optifine is doing that is preventing me from getting the same brightness result in both scenarios would be great. 

First we should address how you are changing it. I assume you are using reflection, but how are you doing it?

VANILLA MINECRAFT CLASSES ARE THE BEST RESOURCES WHEN MODDING

I will be posting 1.15.2 modding tutorials on this channel. If you want to be notified of it do the normal YouTube stuff like subscribing, ect.

Forge and vanilla BlockState generator.

Link to comment
Share on other sites

9 hours ago, Animefan8888 said:

First we should address how you are changing it. I assume you are using reflection, but how are you doing it?

Essentially I created a method that I use to update the World's instance with my custom Dimension instance.

    public static void injectDimension(World world, Dimension dimension) {
        try {
            Field dimensionField = World.class.getDeclaredField("dimension");
            dimensionField = removeFinalModifier(dimensionField);
            dimensionField.set(world, dimension);
        } catch (Exception ex) {
            ex.printStackTrace();
        }
    }

The custom Dimension class that is passed where I mainly just overrode the Dimension#generateLightBrightnessTable() method and tweaked the equation so that the lightBrightnessTable array is updated with larger light values. In vanilla, this array is often referenced to get the light values. However, this doesn't appear to be the case. I may need to utilize reflection again for debugging purposes to see if any new field names were injected into the instance or were modified that Optifine may perhaps be using. 

Edited by geekles
Link to comment
Share on other sites

2 hours ago, geekles said:

Field dimensionField = World.class.getDeclaredField("dimension");

This wont work outside of the development environment because Minecrafts variables and fields(etc) are obfuscated. You should use ObfuscationReflectionHelper or something similar instead.

VANILLA MINECRAFT CLASSES ARE THE BEST RESOURCES WHEN MODDING

I will be posting 1.15.2 modding tutorials on this channel. If you want to be notified of it do the normal YouTube stuff like subscribing, ect.

Forge and vanilla BlockState generator.

Link to comment
Share on other sites

1 hour ago, Animefan8888 said:

This wont work outside of the development environment because Minecrafts variables and fields(etc) are obfuscated. You should use ObfuscationReflectionHelper or something similar instead.

So I realized this could be the case after debugging and reading all the fields in the class. I can't tell which field it is and the ObfuscationReflectionHelper throws an exception regarding a field not being found. I also tried manually changing all three of the fields that share the float[] datatype knowing that the lightBrightnessTable shared the same type. Unfortunately, it appears it has had no effect on the world's lighting. Ideas?

ObfuscationReflectionHelper.findField(Dimension.class, "lightBrightnessTable")

 

public class CustomBlackoutDimension extends Dimension {
	[...]
    /**
     * Creates the light to brightness table
     */
    @Override
    protected void generateLightBrightnessTable() {
        [...]

        try {
            Field f1 = Dimension.class.getDeclaredField("field_111203_a");
            f1 = DimensionalReflectionUtil.removeFinalModifier(f1);

            if(Minecraft.getInstance().player != null) {
                for(float fv : (float[]) f1.get(this))
                    Minecraft.getInstance().player.sendChatMessage("" + fv);
            }

            f1.set(f1, lightBrightnessTable);

            Field f2 = Dimension.class.getDeclaredField("field_76573_f");
            f2 = DimensionalReflectionUtil.removeFinalModifier(f2);
            f2.set(this, lightBrightnessTable);

            if(Minecraft.getInstance().player != null) {
                for(float fv : (float[]) f2.get(this))
                    Minecraft.getInstance().player.sendChatMessage("" + fv);
            }

            Field f3 = Dimension.class.getDeclaredField("field_76580_h");
            f3 = DimensionalReflectionUtil.removeFinalModifier(f3);
            f3.set(this, lightBrightnessTable);

            if(Minecraft.getInstance().player != null) {
                for(float fv : (float[]) f3.get(this))
                    Minecraft.getInstance().player.sendChatMessage("" + fv);
            }
        } catch(IllegalAccessException | NoSuchFieldException e) {
            e.printStackTrace();
        }

    }
  [...]

 

Link to comment
Share on other sites

4 minutes ago, geekles said:

Unfortunately, it appears it has had no effect on the world's lighting. Ideas?

You can download a couple files here that link field names to their obfuscated names and the same thing with methods and parameters.

VANILLA MINECRAFT CLASSES ARE THE BEST RESOURCES WHEN MODDING

I will be posting 1.15.2 modding tutorials on this channel. If you want to be notified of it do the normal YouTube stuff like subscribing, ect.

Forge and vanilla BlockState generator.

Link to comment
Share on other sites

12 minutes ago, Animefan8888 said:

You can download a couple files here that link field names to their obfuscated names and the same thing with methods and parameters.

Hmm, interesting, although I am mildly confused now. This is what comes up in the table for the field name.

field_76573_f lightBrightnessTable
field_76575_d

lightBrightnessTable

 

lightBrightnessTable points to two obfuscated fields. Not sure then if I have to update both of their fields with the value of the lightBrightnessTable field. I'll give it a try, but interested to know if I am wrong. 

 

Also how do I find where the location of these fields are? 

Edited by geekles
Link to comment
Share on other sites

Join the conversation

You can post now and register later. If you have an account, sign in now to post with your account.
Note: Your post will require moderator approval before it will be visible.

Guest
Reply to this topic...

×   Pasted as rich text.   Restore formatting

  Only 75 emoji are allowed.

×   Your link has been automatically embedded.   Display as a link instead

×   Your previous content has been restored.   Clear editor

×   You cannot paste images directly. Upload or insert images from URL.

 Share



×
×
  • Create New...

Important Information

By using this site, you agree to our Privacy Policy.