creating item that change the state of a block

[matt1999rd]

Hello everyone,

For a 1.14 mod,

I try to create an item that change the state of a block. To do that I'm using setBlockState method of World object. The code for doing this use a variable that confirmed that the rest of the code is working well.

As I search into setBlockState method I find these lines :

/**
 * Sets a block state into this world.Flags are as follows:
 * 1 will cause a block update.
 * 2 will send the change to clients.
 * 4 will prevent the block from being re-rendered.
 * 8 will force any re-renders to run on the main thread instead
 * 16 will prevent neighbor reactions (e.g. fences connecting, observers pulsing).
 * 32 will prevent neighbor reactions from spawning drops.
 * 64 will signify the block is being moved.
 * Flags can be OR-ed
 */

 

 

I think this may change the behaviour but I try for the flag that match the best what I wanted and I trye for 7 and 11 but none of them changes the behaviour.

 

Here is the method where I use the method setBlockState :

private void updatePoweredState(World world, BlockState state,BlockPos pos,BlockState oldState) {
    isPowered = !isPowered;
    if (isPowered){
        System.out.println("etat du block : turn");
        world.setBlockState(pos,state.with(SWITCH_POSITION,Corners.TURN),flags);

    }else {
        System.out.println("etat du block : straight");
        world.setBlockState(pos,state.with(SWITCH_POSITION,Corners.STRAIGHT),flags);
    }
}

 

flags has the value 7 or 11.

 

what the code is doing is changing the state switchposition and then almost instantly changing the state to the previous one.

Edited October 5, 2019 by matt1999rd

[matt1999rd]

Thanks for advice I've corrected my code and here is the new method updatePoweredState :

public void updatePoweredState(World world, BlockState state, BlockPos pos, int flags) {
    if (world.isRemote){
        boolean isPowered = state.get(SWITCH_POSITION).getName().equals("turn");
        System.out.println(isPowered);
        if (isPowered){
            world.setBlockState(pos,state.with(SWITCH_POSITION,Corners.TURN));
        }else {
            world.setBlockState(pos,state.with(SWITCH_POSITION,Corners.STRAIGHT));
        }
        System.out.println(state.get(SWITCH_POSITION));
    }
}

I'm using a proper EnumProperty for my block based on enum called Corners which contains these two attributes. But it's unfortunately not working because every time I use my item to change the blockstate from Corners.STRAIGHT to Corners.TURN something is changing to Corners.STRAIGHT again one tick after and I don't know where I can block this action.

 

Another strange action is when some block are nearby this actually change the RailShape properties.

Edited October 5, 2019 by matt1999rd

[Draco18s]

49 minutes ago, matt1999rd said:

I'm using a proper EnumProperty

Then why are you converting it to a string?

 

boolean isPowered = state.get(SWITCH_POSITION) == Corners.TURN

 

And I don't think that this is what you want to check anyway.

Edited October 5, 2019 by Draco18s

[matt1999rd]

11 minutes ago, diesieben07 said:

You are now checking for client-side.

 

What on earth is this?

I will give the full definition of this :

protected static EnumProperty<Corners> SWITCH_POSITION ;

static  {
    SWITCH_POSITION = EnumProperty.create("switch_position",Corners.class,(corner)-> {
        return (corner == Corners.STRAIGHT || corner == Corners.TURN);
    });
}

here is the definition of my EnumProperty

It use the class enum called Corners as used in the BlockStateProperty

And here is the Corners class :

public enum Corners implements IStringSerializable {
    TURN(0,"turn"),
    STRAIGHT(1,"straight"),
    TURN_LEFT(2,"turn_left"),
    TURN_RIGHT(3,"turn_right");


    private final int meta ;
    private final String name;



    private Corners(int meta, String name) {
        this.meta=meta;
        this.name=name;

    }

    @Override
    public String getName() {
        return this.name;
    }
}

 

 

[matt1999rd]

I'm checking the name of the property to know what will be the next state of the block.

[matt1999rd]

I use string to compare rather than using boolean because it seems not to work with booleanProperty POWERED (that the property I used before)

[matt1999rd]

I've understand here is the code :

public void updatePoweredState(World world, BlockState state, BlockPos pos, int flags) {
    if (!world.isRemote){
        boolean isPowered = (state.get(SWITCH_POSITION) == Corners.TURN);
        if (!isPowered){
            world.setBlockState(pos,state.with(SWITCH_POSITION,Corners.TURN),flags);
        }else {
            world.setBlockState(pos,state.with(SWITCH_POSITION,Corners.STRAIGHT),flags);
        }
        System.out.println(state.get(SWITCH_POSITION));
    }
}

 

I don't need string but this enumproperty will be usefull in my future block I filtered the position from now

Edited October 5, 2019 by matt1999rd

[matt1999rd]

so have you got an idea of what is not working ? I'm pretty sure it's the function setBlockState but I do not understood what flags changes..

[matt1999rd]

the ispowered is always at true statement

Edited October 5, 2019 by matt1999rd

[matt1999rd]

the state is not changing and it is not working

[Animefan8888]

3 hours ago, matt1999rd said:

the state is not changing and it is not working

Where do you call updatePoweredState?

[matt1999rd]

now the problem is solved but in fact one problem remain is that the main block I use for creating the block is herited from AbstractRailBlock so when I put the block within the game the switch change the shape when I call this function

[matt1999rd]

Rail are changing depending on the other rail but I don't know if I can modify the function that change the position regarding neighbor rail..

[matt1999rd]

my block is actally in this tags as I've overriden the function isIn. I think that may be the point.

I've not tried though

[Draco18s]

5 hours ago, matt1999rd said:

my block is actally in this tags as I've overriden the function isIn. I think that may be the point.

I've not tried though

That's not how that works.

https://github.com/Draco18s/ReasonableRealism/tree/1.14.4/src/main/resources/data/minecraft/tags/blocks