(SOLVED) [1.14.4] Block Ticking and Properties

MineModder2000 · October 8, 2019

I want to update a block (change it's state) after a certain period of time, if an action has been done.

This is what I did just as a test, I know it's wrong.

Spoiler


package mymod;

import java.util.Random;

import net.minecraft.block.Block;
import net.minecraft.block.BlockState;
import net.minecraft.block.Blocks;
import net.minecraft.util.math.BlockPos;
import net.minecraft.world.World;

public class Copper extends Block {
	
	private int i;

	public Copper(Properties properties) {
		
		super(properties);
	}
	
	@Override
	public void animateTick(BlockState stateIn, World worldIn, BlockPos pos, Random rand) {

		i++;

		if (i > 5) {

			worldIn.setBlockState(pos, Blocks.LAVA.getDefaultState());
		}
	}
}

This'll work for the first block and get it to turn into lava after 5 or however many ticks. I'm not sure what method to actually use, as the other tick ones are deprecated and don't work. I also need to be able to grab a capability in the method so that I can use that and not an instance variable that wont work when there are multiple instances. Or.....is there a better way altogether?

Edited October 21, 2019 by MineModder2000

MineModder2000 · October 8, 2019

14 hours ago, diesieben07 said:

Look at repeaters.

I see, that is very helpful ?

Edited October 8, 2019 by MineModder2000

MineModder2000 · October 9, 2019

How exactly do I get boolean properties to work in blocks? I tried this :

Spoiler


public class Copper extends Block {
	
	public static final BooleanProperty LIT = BlockStateProperties.LIT;

	public Copper(Properties properties) {
		
		super(properties);
	}

	public boolean onBlockActivated(BlockState state, World worldIn, BlockPos pos, PlayerEntity player, Hand handIn, BlockRayTraceResult hit) {
		
		worldIn.setBlockState(pos, state.with(LIT, Boolean.valueOf(true)), 1);  
	}
	
	@OnlyIn(Dist.CLIENT)
	public void animateTick(BlockState stateIn, World worldIn, BlockPos pos, Random rand) {
		
		if (stateIn.get(LIT)) {
				
        	// do stuff
                }
	}
}

But got this : Cannot set property BooleanProperty{name=lit, clazz=class java.lang.Boolean, values=[true, false]} as it does not exist in Block{mymod:copper}

Edited October 9, 2019 by MineModder2000

Animefan8888 · October 9, 2019

3 minutes ago, MineModder2000 said:

How exactly do I get boolean properties to work in blocks?

You need to override Block#fillBlockState

MineModder2000 · October 9, 2019

20 minutes ago, Animefan8888 said:

You need to override Block#fillBlockState

Ah, it's fillStateContainer actually. I am trying to make it do certain animations upon activation only, however nothing inside of my if statement within animateTick is run upon such. I set it to false on block added because its true by default.

Spoiler


public class Copper extends Block {
	
	public static final BooleanProperty LIT = BlockStateProperties.LIT;

	public Copper(Properties properties) {
		
		super(properties);
	}

        @Override
        @SuppressWarnings("deprecation")
        public void onBlockAdded(BlockState state, World worldIn, BlockPos pos, BlockState oldState, boolean isMoving) {
        
                super.onBlockAdded(state, worldIn, pos, oldState, isMoving);
        
                worldIn.setBlockState(pos, state.with(LIT, Boolean.valueOf(false)), 1);
        }

	public boolean onBlockActivated(BlockState state, World worldIn, BlockPos pos, PlayerEntity player, Hand handIn, BlockRayTraceResult hit) {
		
		worldIn.setBlockState(pos, state.with(LIT, Boolean.valueOf(true)), 1);  
	}
	
	@OnlyIn(Dist.CLIENT)
	public void animateTick(BlockState stateIn, World worldIn, BlockPos pos, Random rand) {
		
		if (stateIn.get(LIT)) {
				
        	// do stuff
                }
	}

        protected void fillStateContainer(StateContainer.Builder<Block, BlockState> builder) {
        
                builder.add(LIT);
        }
}

Edited October 9, 2019 by MineModder2000

Animefan8888 · October 9, 2019

Just now, MineModder2000 said:

Ah, it's fillStateContainer actually. I am trying to make it do certain animations upon activation only, however nothing inside of my if statement within animateTick is run upon such. I set it to false on block added because its true by default.

It be better if you posted all of your code unmodified.

MineModder2000 · October 9, 2019

1 minute ago, Animefan8888 said:

It be better if you posted all of your code unmodified.

Spoiler


package mymod;

import java.util.Random;

import net.minecraft.block.Block;
import net.minecraft.block.BlockState;
import net.minecraft.block.Blocks;
import net.minecraft.block.FireBlock;
import net.minecraft.entity.player.PlayerEntity;
import net.minecraft.item.Items;
import net.minecraft.particles.ParticleTypes;
import net.minecraft.state.BooleanProperty;
import net.minecraft.state.StateContainer;
import net.minecraft.state.properties.BlockStateProperties;
import net.minecraft.util.Direction;
import net.minecraft.util.Hand;
import net.minecraft.util.math.BlockPos;
import net.minecraft.util.math.BlockRayTraceResult;
import net.minecraft.world.TickPriority;
import net.minecraft.world.World;
import net.minecraftforge.api.distmarker.Dist;
import net.minecraftforge.api.distmarker.OnlyIn;

public class Copper extends Block {
	
	public static final BooleanProperty LIT = BlockStateProperties.LIT;

	public Copper(Properties properties) {
		
		super(properties);
	}
	
	@Override
    @SuppressWarnings("deprecation")
	public void onBlockAdded(BlockState state, World worldIn, BlockPos pos, BlockState oldState, boolean isMoving) {
		
	    super.onBlockAdded(state, worldIn, pos, oldState, isMoving);
	    
	    worldIn.setBlockState(pos, state.with(LIT, Boolean.valueOf(false)), 1);
	}
	
	@Override
	public void tick(BlockState state, World worldIn, BlockPos pos, Random random) {
		
		worldIn.setBlockState(pos, state.with(LIT, Boolean.valueOf(true)), 1);
		
		BlockPos blockpos = pos.offset(Direction.UP);
		BlockState blockstate = ((FireBlock)Blocks.FIRE).getStateForPlacement(worldIn, pos);
		
		worldIn.setBlockState(blockpos, blockstate);
		worldIn.getPendingBlockTicks().scheduleTick(pos, this, 180, TickPriority.HIGH);
	}
	
	public boolean onBlockActivated(BlockState state, World worldIn, BlockPos pos, PlayerEntity player, Hand handIn, BlockRayTraceResult hit) {
		
		if (!player.abilities.allowEdit) {
			 
	        return false;
	    } 
		 
		else {

			if (player.getHeldItemMainhand().getItem() == Items.TORCH) {
				
				worldIn.getPendingBlockTicks().scheduleTick(pos, this, 60, TickPriority.HIGH);
			}
		
	        return true;
	    }
	}
	
	@OnlyIn(Dist.CLIENT)
	public void animateTick(BlockState stateIn, World worldIn, BlockPos pos, Random rand) {
		
		if (stateIn.get(LIT) && rand.nextInt(5) == 0) {  
				
            for(int i = 0; i < rand.nextInt(1) + 1; ++i) {
            		
                worldIn.addParticle(ParticleTypes.LAVA, (double)((float)pos.getX() + 0.5F), (double)((float)pos.getY() + 0.5F), (double)((float)pos.getZ() + 0.5F), (double)(rand.nextFloat() / 2.0F), 5.0E-5D, (double)(rand.nextFloat() / 2.0F));
                //worldIn.addParticle(ParticleTypes.LARGE_SMOKE, (double)((float)pos.getX() + 0.5F), (double)((float)pos.getY() + 0.5F), (double)((float)pos.getZ() + 0.5F), (double)(rand.nextFloat() / 2.0F), 5.0E-5D, (double)(rand.nextFloat() / 2.0F));
            }
        }
	}
	
	protected void fillStateContainer(StateContainer.Builder<Block, BlockState> builder) {
		
	    builder.add(LIT);
	}
}

Animefan8888 · October 9, 2019

2 minutes ago, MineModder2000 said:

setBlockState

You should really read the javadoc of this method.

MineModder2000 · October 9, 2019

14 minutes ago, Animefan8888 said:

You should really read the javadoc of this method.

I did, and I thought I selected the correct int flag : 1. Tried 2 as well, the rest don't seem right.

Spoiler

/**
* Sets a block state into this world.Flags are as follows:
* 1 will cause a block update.
* 2 will send the change to clients.
* 4 will prevent the block from being re-rendered.
* 8 will force any re-renders to run on the main thread instead
* 16 will prevent neighbor reactions (e.g. fences connecting, observers pulsing).
* 32 will prevent neighbor reactions from spawning drops.
* 64 will signify the block is being moved.
* Flags can be OR-ed
*/

Animefan8888 · October 9, 2019

Just now, MineModder2000 said:

* Flags can be OR-ed

OR-ed means to use the bitwise OR operator. Which would be 3. This will cause a block update which is necessary and send the change to the clients which is needed because animateTick is client only.

MineModder2000 · October 9, 2019

2 minutes ago, Animefan8888 said:

OR-ed means to use the bitwise OR operator. Which would be 3. This will cause a block update which is necessary and send the change to the clients which is needed because animateTick is client only.

3 ain't working honey.

Animefan8888 · October 9, 2019

2 minutes ago, MineModder2000 said:

3 ain't working honey.

Then your code is never ran and as such the setBlockState method is never being called. Can you confirm what part of your code is not executing?

MineModder2000 · October 9, 2019

3 minutes ago, Animefan8888 said:

Then your code is never ran and as such the setBlockState method is never being called. Can you confirm what part of your code is not executing?

I have confirmed that all methods are being called. The if statement inside animateTick gets runs without the check for stateIn.get(LIT). The tick method is definitely called, as my block gets a fire on top of it when activated (after 60 ticks).

Animefan8888 · October 9, 2019

Just now, MineModder2000 said:

I have confirmed that all methods are being called. The if statement inside animateTick gets runs without the check for stateIn.get(LIT). The tick method is definitely called, as my block gets a fire on top of it when activated (after 60 ticks).

Post your updated code then.

MineModder2000 · October 9, 2019

17 hours ago, Animefan8888 said:

Post your updated code then.

That's already it, I just changed the 1 to a 3.

Spoiler


package mymod;

import java.util.Random;

import net.minecraft.block.Block;
import net.minecraft.block.BlockState;
import net.minecraft.block.Blocks;
import net.minecraft.block.FireBlock;
import net.minecraft.entity.player.PlayerEntity;
import net.minecraft.item.Items;
import net.minecraft.particles.ParticleTypes;
import net.minecraft.state.BooleanProperty;
import net.minecraft.state.StateContainer;
import net.minecraft.state.properties.BlockStateProperties;
import net.minecraft.util.Direction;
import net.minecraft.util.Hand;
import net.minecraft.util.math.BlockPos;
import net.minecraft.util.math.BlockRayTraceResult;
import net.minecraft.world.TickPriority;
import net.minecraft.world.World;
import net.minecraftforge.api.distmarker.Dist;
import net.minecraftforge.api.distmarker.OnlyIn;

public class Copper extends Block {
	
	public static final BooleanProperty LIT = BlockStateProperties.LIT;

	public Copper(Properties properties) {
		
		super(properties);
	}
	
	@Override
    @SuppressWarnings("deprecation")
	public void onBlockAdded(BlockState state, World worldIn, BlockPos pos, BlockState oldState, boolean isMoving) {
		
	    super.onBlockAdded(state, worldIn, pos, oldState, isMoving);
	    
	    worldIn.setBlockState(pos, state.with(LIT, Boolean.valueOf(false)), 3);
	}
	
	@Override
	public void tick(BlockState state, World worldIn, BlockPos pos, Random random) {
		
		worldIn.setBlockState(pos, state.with(LIT, Boolean.valueOf(true)), 3);
		
		BlockPos blockpos = pos.offset(Direction.UP);
		BlockState blockstate = ((FireBlock)Blocks.FIRE).getStateForPlacement(worldIn, pos);
		
		worldIn.setBlockState(blockpos, blockstate);
		worldIn.getPendingBlockTicks().scheduleTick(pos, this, 180, TickPriority.HIGH);
	}
	
	@Override
	public boolean onBlockActivated(BlockState state, World worldIn, BlockPos pos, PlayerEntity player, Hand handIn, BlockRayTraceResult hit) {
		
		if (!player.abilities.allowEdit) {
			 
	        return false;
	    } 
		 
		else {

			if (player.getHeldItemMainhand().getItem() == Items.TORCH) {
				
				worldIn.getPendingBlockTicks().scheduleTick(pos, this, 60, TickPriority.HIGH);
			}
		
	        return true;
	    }
	}
	
	@Override
	@OnlyIn(Dist.CLIENT)
	public void animateTick(BlockState stateIn, World worldIn, BlockPos pos, Random rand) {
		
		if (stateIn.get(LIT) && rand.nextInt(5) == 0) {  
				
            for(int i = 0; i < rand.nextInt(1) + 1; ++i) {
            		
            	System.out.println("xyz968");
            	
                worldIn.addParticle(ParticleTypes.LAVA, (double)((float)pos.getX() + 0.5F), (double)((float)pos.getY() + 0.5F), (double)((float)pos.getZ() + 0.5F), (double)(rand.nextFloat() / 2.0F), 5.0E-5D, (double)(rand.nextFloat() / 2.0F));
                //worldIn.addParticle(ParticleTypes.LARGE_SMOKE, (double)((float)pos.getX() + 0.5F), (double)((float)pos.getY() + 0.5F), (double)((float)pos.getZ() + 0.5F), (double)(rand.nextFloat() / 2.0F), 5.0E-5D, (double)(rand.nextFloat() / 2.0F));
            }
        }
	}
	
	@Override
	protected void fillStateContainer(StateContainer.Builder<Block, BlockState> builder) {
		
	    builder.add(LIT);
	}
}

Draco18s · October 10, 2019

So, just a few things (but not related to your issue, just code style problems):

3 hours ago, MineModder2000 said:

Boolean.valueOf(true)

This is copy-pasted decompiled code. There's no reason to use Boolean.valueOf

3 hours ago, MineModder2000 said:

((FireBlock)Blocks.FIRE)

There's no reason for a cast here.

3 hours ago, MineModder2000 said:

player.getHeldItemMainhand()

You are passed a hand in this function, you should query based on the hand given to you.

3 hours ago, MineModder2000 said:

worldIn.getPendingBlockTicks().scheduleTick(pos, this, 180, TickPriority.HIGH);

If the purpose of this code is to continuously set the block above to be fire, there's a better way to do this. Make your block infinitely burnable (like netherack) and set the fire once in onBlockActivated. Then you don't need the tick method or the LIT property at all.

MineModder2000 · October 10, 2019

35 minutes ago, Draco18s said:

So, just a few things (but not related to your issue, just code style problems):

This is copy-pasted decompiled code. There's no reason to use Boolean.valueOf

There's no reason for a cast here.

You are passed a hand in this function, you should query based on the hand given to you.

If the purpose of this code is to continuously set the block above to be fire, there's a better way to do this. Make your block infinitely burnable (like netherack) and set the fire once in onBlockActivated. Then you don't need the tick method or the LIT property at all.

Okay I got rid of the Boolean.valueOf.
The cast is necessary in order for that particular method to be accessible.
I tried the hand parameter to begin with, but I couldn't see any way to get the held item from it.
Yes, this code is temporary, and I am contemplating even having the block constantly on fire. The reason for the lit property is that I didn't want the block to start throwing particles until it was on fire.

Draco18s · October 10, 2019

5 minutes ago, MineModder2000 said:

but I couldn't see any way to get the held item from it.

player.getHeldItem(hand)?

Animefan8888 · October 10, 2019

15 minutes ago, MineModder2000 said:

The reason for the lit property is that I didn't want the block to start throwing particles until it was on fire.

World#getBlockState(abovePos).getBlock() some condition to check fire.

MineModder2000 · October 10, 2019

19 minutes ago, Draco18s said:

player.getHeldItem(hand)?

Oh duh, I was thinking of starting with handIn and using its methods. This is functionally the same either way, I still changed it though.

10 minutes ago, Animefan8888 said:

World#getBlockState(abovePos).getBlock() some condition to check fire.

This did the trick, however I would still like to know why the other thing didn't work, it bothers me not knowing. Also I may have to do something like that in the future.

Animefan8888 · October 10, 2019

42 minutes ago, MineModder2000 said:

however I would still like to know why the other thing didn't work

Have you run through your code with your IDE's debugger? What about using the f3 menu/gui to look at the blocks state?

MineModder2000 · October 10, 2019

10 minutes ago, Animefan8888 said:

Have you run through your code with your IDE's debugger? What about using the f3 menu/gui to look at the blocks state?

I'll do this. I want to also know how to alter a block's color / texture without changing it's state, if possible.

Animefan8888 · October 10, 2019

1 minute ago, MineModder2000 said:

I want to also know how to alter a block's color / texture without changing it's state, if possible.

Not without rendering it every frame with a TESR. Changing its state is the only way to force the chunk to recreate its mesh and push it to the GPU.

MineModder2000 · October 10, 2019

15 hours ago, Animefan8888 said:

Not without rendering it every frame with a TESR. Changing its state is the only way to force the chunk to recreate its mesh and push it to the GPU.

I see, I'll just make two blocks instead, much easier and better for my purposes. Anyways back to the boolean property, I figured out the issue. The line : worldIn.setBlockState(pos, state.with(LIT, true), 3); in the tick method doesn't set the value to true, as confirmed by println. So whatever value it's set to in the onBlockAdded method, is what it stays as. Hence the reason the if statement check in the animateTick method fails....

MineModder2000 · October 11, 2019

So....... no idea why the property doesn't get changed?

Sign In

(SOLVED) [1.14.4] Block Ticking and Properties

Recommended Posts

Top Posters In This Topic

Popular Days

Top Posters In This Topic

Popular Days

Popular Posts

Draco18s

Animefan8888

Animefan8888

Join the conversation

Announcements

Recently Browsing

Posts

Topics

Who's Online (See full list)

Important Information