crops 1.14

[Guest]

6 minutes ago, Animefan8888 said:

It exists in the Block class. You need to override it in your Block class I believe is called MPlant.

there's only two things that don't have an @Override already:

 

    public MPlant(Properties builder)
    {
        super(builder);
        this.setDefaultState(this.stateContainer.getBaseState().with(this.getAgeProperty(), Integer.valueOf(0)));
    }

_____________________________________________________________________________________________________________

and this one: 

 

 @OnlyIn(Dist.CLIENT)
    public ItemStack getItem(IBlockReader worldIn, BlockPos pos, BlockState state)
    {
       return new ItemStack(this.getSeedsItem());
    }

 

 

 

I assume its the first one?

 

 

edit: nevermind. its not the first one

Edited October 13, 2019 by Guest

[Animefan8888]

Just now, DrMDGG said:

I assume its the first one?

No. You don't know Java do you? First the @Override annotation doesn't actually do anything. It just lets you know that you are overriding a method from a parent class(hurray for inheritance). Secondly the method is a new one you have to add to your class. If it doesn't exist with the name fillStateContainer then it's likely that you are using an outdated version of forge. I'm only on 28.1.19

[Guest]

38 minutes ago, Animefan8888 said:

No. You don't know Java do you? First the @Override annotation doesn't actually do anything. It just lets you know that you are overriding a method from a parent class(hurray for inheritance). Secondly the method is a new one you have to add to your class. If it doesn't exist with the name fillStateContainer then it's likely that you are using an outdated version of forge. I'm only on 28.1.19

yeah. I updated forge, and low and behold, it came up.

https://github.com/drmdgg/marijuanacraft/blob/master/src/main/java/drmdgg/marijuanacraft/init/blocks/plants/MPlant.java

 

so I added that and changed getAge to getCropAge

 

what did I do wrong?

[Animefan8888]

2 minutes ago, DrMDGG said:

what did I do wrong?

I assume the same "error" is happening?

[Guest]

21 minutes ago, Animefan8888 said:

I assume the same "error" is happening?

yeah. block breaks properly. no bonemeal. no growing. no texture

[Guest]

On 10/13/2019 at 9:11 AM, Animefan8888 said:

I assume the same "error" is happening?

is this error happening due to the lack of references to my plant seed not being in my seed class and the mplant class not referencing my mplant?

[Draco18s]

You only need two references:

 

1. The block instance is passed to the seed item's constructor
2. The item instance is returned in the block's getSeedsItem method via a ModItems (ItemList) reference.

That's it.

[Guest]

4 minutes ago, Draco18s said:

You only need two references:

 

1. The block instance is passed to the seed item's constructor
2. The item instance is returned in the block's getSeedsItem method via a ModItems (ItemList) reference.

That's it.

okay, well it has all that...so what's the problem. at one point I get this in my runclient:

[16:51:03] [Server-Worker-2/WARN] [minecraft/ModelBakery]: Exception loading blockstate definition: 'marijuanacraft:blockstates/mplant.json' in resourcepack: 'main' for variant: 'age=5': Unknown blockstate property: 'age'

 

 

[Animefan8888]

56 minutes ago, DrMDGG said:

Exception loading blockstate definition: 'marijuanacraft:blockstates/mplant.json' in resourcepack: 'main' for variant: 'age=5': Unknown blockstate property: 'age'

For some reason it isnt recognizing that your block has an age property and when it is reading the blockstate json its seeing this and going "HUH?!?!"

[Guest]

3 minutes ago, Animefan8888 said:

For some reason it isnt recognizing that your block has an age property and when it is reading the blockstate json its seeing this and going "HUH?!?!"

any guesses on how to fix that? I've checked that json file and the others a billion times against the carrots and the wheat (which are obviously the same)

[Animefan8888]

4 minutes ago, DrMDGG said:

any guesses on how to fix that? I've checked that json file and the others a billion times against the carrots and the wheat (which are obviously the same)

The problem doesnt lie within the json. The problem lies within the code. Specifically why your block isnt getting the age property. Have you looked at the f3 screen while looking at your block to see if it has the age property on the right hand side of the screen?

[Guest]

10 minutes ago, Animefan8888 said:

The problem doesnt lie within the json. The problem lies within the code. Specifically why your block isnt getting the age property. Have you looked at the f3 screen while looking at your block to see if it has the age property on the right hand side of the screen?

it definitely does not

[Animefan8888]

6 minutes ago, DrMDGG said:

it definitely does not

Double check that in your fillStateContainer method you add your age property to the Builder parameter.

[Guest]

15 minutes ago, Animefan8888 said:

Double check that in your fillStateContainer method you add your age property to the Builder parameter.

like this?

 

    @Override
    protected void fillStateContainer(Builder<Block, BlockState> builder) {
        
        builder.add(CROP_AGE);
        
        

[Guest]

2 hours ago, Animefan8888 said:

Double check that in your fillStateContainer method you add your age property to the Builder parameter.

okay, so I triple...or maybe quadruple checked the cropsblock class and the code there is "builder.add(AGE);"

but if i'm extending CropsBlock then shouldn't all the age stuff be automatically added and unnecessary for me to add?

[Animefan8888]

1 minute ago, DrMDGG said:

but if i'm extending CropsBlock then shouldn't all the age stuff be automatically added and unnecessary for me to add?

Exactly make sure your fillStateContainer is being called though. I'm curious if something is broken.

[Guest]

6 minutes ago, Animefan8888 said:

Exactly make sure your fillStateContainer is being called though. I'm curious if something is broken.

please...be my guest...you'd see it faster than me, i'm sure:

 

https://pastebin.com/Ji2QtwnG

[Guest]

12 hours ago, Animefan8888 said:

Exactly make sure your fillStateContainer is being called though. I'm curious if something is broken.

i also noticed that it will spawn on any block, not just farmland

[Draco18s]

I suspect that the block being used by your seed item is not actually your crop block. But with the code you have, I'm not sure why that is.

My guess is that the item you're holding is not the one that we've been talking about, but another item entirely.

[Guest]

1 hour ago, Draco18s said:

I suspect that the block being used by your seed item is not actually your crop block. But with the code you have, I'm not sure why that is.

My guess is that the item you're holding is not the one that we've been talking about, but another item entirely.

I've gone through all my code. i must have missed something. 

 

you've seen my code in full. what item or block could possibly be doing this?

[Draco18s]

58 minutes ago, DrMDGG said:

you've seen my code in full. what item or block could possibly be doing this?

*Shrug*

From my point of view, you created a bunch of stuff all at once (maybe copy-pasted from an old version?) without checking any of it to make sure it worked before going for more.

 

Always work on one block or item or system at a time, make sure its working 100%^* before moving on to another.

 

*Sure, there are things that interleave sometimes, such as a crop and its seed, those can be worked on as a single operational group. And sometimes you need to break a thing down into smaller pieces and work on them and they won't be 100% until the larger structure is done, but you can handle that with placeholders and TODOs, but there you know what part isn't complete when you test it (for example, my ore system relies heavily on Custom Ore Gen and several ore generation events that don't exist, but that doesn't mean I can't make the blocks, items, loot tables, recipes, and enchantments, I just know I can't test the ore gen and prospecting systems until those events exist).

[Guest]

9 minutes ago, Draco18s said:

*Shrug*

From my point of view, you created a bunch of stuff all at once (maybe copy-pasted from an old version?) without checking any of it to make sure it worked before going for more.

 

Always work on one block or item or system at a time, make sure its working 100%^* before moving on to another.

 

*Sure, there are things that interleave sometimes, such as a crop and its seed, those can be worked on as a single operational group. And sometimes you need to break a thing down into smaller pieces and work on them and they won't be 100% until the larger structure is done, but you can handle that with placeholders and TODOs, but there you know what part isn't complete when you test it (for example, my ore system relies heavily on Custom Ore Gen and several ore generation events that don't exist, but that doesn't mean I can't make the blocks, items, loot tables, recipes, and enchantments, I just know I can't test the ore gen and prospecting systems until those events exist). 

the original mod I made was for 1.8.9 so I couldn't copy anything.
but now everything is working order except for these damn crops thanks to you guys. I guess I'll just have to figure this out on my own if you can't help me further. thanks for the help. you'll be in my credits lol