[1.12.2] Adding an item to a loot table

[Eilux]

I have tried the following code:

@Mod.EventBusSubscriber
public class HorseMeatDrops {
    @SubscribeEvent
    public void onLootTablesLoaded(LootTableLoadEvent event){

        if (event.getName().equals(LootTableList.ENTITIES_HORSE)){
            final LootPool main = event.getTable().getPool("main");
            if (main != null) {
                new SetCount(new LootCondition[0],new RandomValueRange(1,3));
                main.addEntry(new LootEntryItem(ModItems.RAW_HORSE, 10, 0, new LootFunction[0], new LootCondition[0], "loottable:rawhorse" ));
            }
        }
    }

}

It dose not seem to be working however any help would be appreciated.

[Draco18s]

44 minutes ago, Eilux said:

new SetCount(new LootCondition[0],new RandomValueRange(1,3));

This is unused. You create a SetCount object and then immediately discard it.

 

Also, you should definitely do this json-ly.

https://github.com/Draco18s/ReasonableRealism/blob/1.14.4/src/main/java/com/draco18s/harderfarming/EventHandlers.java#L49-L57

https://github.com/Draco18s/ReasonableRealism/blob/1.14.4/src/main/resources/data/harderfarming/loot_tables/entities/leather.json

[Eilux]

Some of the things like LootPool.builder() and TableLootEntry don't seem to be working is this because of different mappings? if so do you know the 1.12.2 equivalent (using mcp stable_39)  

[SerpentDagger]

I don't think there's a LootPool builder in 1.12, so you have to set them up just with normal constructors*.

What I've done is as follows:

   Declare a LootEntry object using new LootEntryTable(ResourceLocation tableIn, int weightIn, int qualityIn, LootCondition[]

      conditionsIn, String entryName), where the ResourceLocation points towards your json file.

   Declare a new LootPool using the LootEntry with new LootPool(LootEntry[] lootEntriesIn, LootCondition[] poolConditionsIn, 

      RandomValueRange rollsIn, RandomValueRange bonusRollsIn, String name).

   Add the pool to the event's table

 

*Unless I'm unaware of something here?

Edited October 17, 2019 by SerpentDagger
Formatting is a fickle beast

[Eilux]

I'm having a bit of trouble getting this to work could you show me some kind of example?

[SerpentDagger]

34 minutes ago, Eilux said:

could you show me some kind of example?

This adds my custom loot, defined in the json file simple_chest, to all entries whose name contains "chests".

	@SubscribeEvent
	public void lootLoad(LootTableLoadEvent evt)
	{
		//Check for chest loot
		if (evt.getName().toString().contains("chests"))
		{
			//Declare entry
			LootEntry simpleDungeonEntry = new LootEntryTable(new ResourceLocation("artificialartificing:simple_chest"), 1, 0,
					new LootCondition[0], "artificialartificing:simple_chest_entry");
			
			//Declare pool with entry inside
			LootPool simpleDungeonPool = new LootPool(new LootEntry[] {simpleDungeonEntry}, new LootCondition[0],
					new RandomValueRange(1), new RandomValueRange(0, 1), "artificialartificing:simple_chest_pool");
			
			//Add pool to chest loot
			evt.getTable().addPool(simpleDungeonPool);
			
			//Print table that loot is being added to
			System.out.println("AA loot added to table: " + evt.getName().toString());
		}
	}

simple_chest.json

[Eilux]

It still don't seem to work here is my code:

@Mod.EventBusSubscriber
public class HorseMeatDrops {
    @SubscribeEvent
    public void onLootTablesLoaded(LootTableLoadEvent event){

        if (event.getName().equals(LootTableList.ENTITIES_HORSE)){

            LootEntry rawEntry = new LootEntryTable(new ResourceLocation("eatahorse:raw_horse"), 1, 0,
                    new LootCondition[0], "eatahorse:raw_horse_entry");

            LootPool rawPool = new LootPool(new LootEntry[] {rawEntry}, new LootCondition[0],
                    new RandomValueRange(1), new RandomValueRange(0, 1), "eatahorse:raw_horse_pool");

            event.getTable().addPool(rawPool);
        }
    }
}

and here is the json file, the filepath to it is: resources/data/eatahorse/loot_tables/entities/raw_horse.json

{
  "type": "minecraft:entity",
  "pools": [
    {
      "rolls": 1,
      "entries": [
        {
          "type": "minecraft:item",
          "functions": [
            {
              "function": "minecraft:set_count",
              "count": {
                "min": 2.0,
                "max": 3.0,
                "type": "minecraft:uniform"
              }
            },
            {
              "function": "minecraft:looting_enchant",
              "count": {
                "min": 0.0,
                "max": 1.0
              }
            }
          ],
          "name": "eatahorse:raw_horse"
        }
      ]
    }
  ]
}

 

[SerpentDagger]

As an aside, you've made sure that the methods run, right? lol

Beyond that, though, I think your json should be placed in resources/assets/eatahorse/loot_tables/, unless you change the path accordingly. Your json file also has some differences in formatting from mine, which might or might not be fine (I'm not fabulous with loot jsons, so I'll leave that to someone else)*.

 

*Edit: Here's a link to the loot table wiki. Tag structure is described in depth there.

Edited October 18, 2019 by SerpentDagger

[poopoodice]

Isn't name suppose to be in front of the rolls?

[poopoodice]

29 minutes ago, SerpentDagger said:

As an aside, you've made sure that the methods run, right? lol

Beyond that, though, I think your json should be placed in resources/assets/eatahorse/loot_tables/, unless you change the path accordingly. Your json file also has some differences in formatting from mine, which might or might not be fine (I'm not fabulous with loot jsons, so I'll leave that to someone else).

Yeah you need to check if the class has been registered correctly, add some printlns to check is it actually being called

[poopoodice]

Also have a look at this Forge Doc

It uses

(evt.getName().toString().equals("minecraft:chests/simple_dungeon"))

which means the way you are doing it might be wrong

(event.getName().equals(LootTableList.ENTITIES_HORSE))

or at least add a println to check if it does work

Edited October 18, 2019 by poopoodice

[Draco18s]

6 hours ago, SerpentDagger said:

1.12

Oh. 1.12

Use this:

https://github.com/Draco18s/ReasonableRealism/blob/1.12.1/src/main/java/com/draco18s/hardlib/util/LootUtils.java

 

Take that whole thing, put it in your project in (use your own package) and invoke its methods during the LootTableLoadEvent. (Yes, you can use it, its a utility class, I really don't care. I did a lot of futzing around figuring out how the stuff works so you don't have to)

Example usage
https://github.com/Draco18s/ReasonableRealism/blob/1.12.1/src/main/java/com/draco18s/farming/FarmingEventHandler.java#L425

Edited October 18, 2019 by Draco18s

[Eilux]

I can't get it to work I created a test one that is very close to the example provided but it dose not seem to be doing anything.

@Mod.EventBusSubscriber(modid = Main.MODID)
public class HorseMeatDrops {
    @SubscribeEvent
    public void lootTableLoad(LootTableLoadEvent event) {
        //FamingBase.logger.log(Level.INFO, event.getName());
        LootCondition[] chance;
        LootCondition[] lootingEnchant;
        LootFunction[] count;
        LootEntryItem[] item;
        LootPool newPool;
        LootTable loot = event.getTable();
        if (event.getName().getPath().equals("entities/cow")) {
            LootUtils.removeLootFromTable(loot, Items.DIAMOND);
            LootUtils.addItemToTable(loot, Items.DIAMOND, 1, 2, 1, 2, 5, 0, 1, "minecraft:diamond",
                    new LootUtils.IMethod() {
                        @Override
                        public void FunctionsCallback(ArrayList<LootFunction> lootfuncs) {
                            LootCondition[] condition = {new EntityHasProperty(new EntityProperty[]{new EntityOnFire(true)}, LootContext.EntityTarget.THIS)};
                            LootFunction cooked = new Smelt(condition);
                            lootfuncs.add(cooked);
                            LootFunction looting = new LootingEnchantBonus(null, new RandomValueRange(1, 3), 0);
                            lootfuncs.add(looting);
                        }
                    });
        }
    }
}

 

[Draco18s]

15 minutes ago, Eilux said:

HorseMeatDrops

15 minutes ago, Eilux said:

equals("entities/cow")

You seem to be wanting to affect the horse, but you look for cow.

 

16 minutes ago, Eilux said:

LootUtils.removeLootFromTable(loot, Items.DIAMOND);

That item doesn't exist in that loot table, so I'm not sure why you're doing that.

 

17 minutes ago, Eilux said:

LootUtils

Hopefully you pulled in my LootUtils class, yes?

[Eilux]

It's name HorseMeatDrops because I wasn't sure what the filepath for horse was so i was testing it with the cow, and i do have the LootUtils class.

[Draco18s]

I'm not sure what's up, then. I pretty rigorously made sure I got things working when I updated stuff.

[Eilux]

I've found the problem the method lootTableLoad was not static it is working fine now. Thank you for your help.

Edited October 20, 2019 by Eilux

[Draco18s]

1 hour ago, Eilux said:

was not static

That'd do it.