[1.14.4] create ItemStack using registry name?

[andGarrett]

slot.putStack(new ItemStack(???);

 

I'm trying to create an ItemStack using itemRegistryNames. I want to use a list of itemRegistryNames to fill 12 inventory slots. I know how to set a slot to empty "slot.putStack(ItemStack.EMPTY);", but not how to actually create an itemStack to put in the slots. Please help.

[Draco18s]

Get the Item from the Registry by name.

Make a new stack from the Item.

[andGarrett]

  On 11/6/2019 at 11:29 PM, Draco18s said:

Get the Item from the Registry by name.

Expand  

how? I tried "ForgeRegistries.ITEMS", but I can't find a way to get an item by it's registry name. It's possible to get an item by it's resource location, but I would much rather get it by registry name as I have a lot of code already written using the registry names.

[Draco18s]

ForgeRegistries.ITEMS.getValue(key)

 

I'm not sure how you couldn't find that.

 

You can construct a resource location from a string. String -> RL -> Item -> Stack

[Animefan8888]

  On 11/7/2019 at 9:36 PM, andGarrett said:

but I can't find a way to get an item by it's registry name. It's possible to get an item by it's resource location

Expand  

The registry name is a resource location. You probably have it in String form in which case just pass it into the ResourceLocation constructor.

[andGarrett]

  On 11/7/2019 at 10:23 PM, Draco18s said:

ForgeRegistries.ITEMS.getValue(key)

 

I'm not sure how you couldn't find that.

Expand  

 

lol, the "key" in "ForgeRegistries.ITEMS.getValue(key)" is the ResourceLocation I mentioned here:

 

  On 11/7/2019 at 9:36 PM, andGarrett said:

It's possible to get an item by it's resource location

Expand  

 

unfortunately for me, I didn't write my code in such a way as to work well with converting the registry names into resource locations. I would have to create new ResourceLocations too often to be considered efficient. I may need to rethink some of my code.

[DaemonUmbra]

ResourceLocation is literally just two strings with utility methods attached, I don't think there's much performance hit creating new ones

[andGarrett]

  On 11/8/2019 at 3:27 AM, DaemonUmbra said:

ResourceLocation is literally just two strings with utility methods attached, I don't think there's much performance hit creating new ones

Expand  

I would have to do it a LOT given my current code.

[DaemonUmbra]

By "A LOT" you don't mean every tick, do you?

[andGarrett]

  On 11/8/2019 at 8:04 AM, diesieben07 said:

Short-lived objects (aka "create resource location, look up in map, drop resource location") are heaven for modern Java GCs. Don't worry about it.

Expand  

so, hypothetically, something like ForgeRegistries.ITEMS.getValue(new ResourceLocation("minecraft:polished_diorite")); done a hundred times isn't a problem?

 

  On 11/8/2019 at 5:05 AM, DaemonUmbra said:

By "A LOT" you don't mean every tick, do you?

Expand  

actually, now that I've gone through the code again, it isn't all that much.

Edited November 8, 2019 by andGarrett

[Draco18s]

  On 11/8/2019 at 5:49 PM, andGarrett said:

done a hundred times isn't a problem?

Expand  

It takes 100,000 to even calculate preformance.

[herobib]

  On 11/6/2019 at 11:26 PM, andGarrett said:

slot.putStack(new ItemStack(???);

Expand  

slot.putStack(new ItemStack(Items.Your_Item);

Edited March 30, 2024 by herobib